Re: Literal text WWW in ports Makefile (Was: git: 4bb2e36e912e - main - sysutils/gol: New port: All-in-one log viewer in browser)

From: Daniel Engberg <diizzy_at_FreeBSD.org>
Date: Sat, 15 Nov 2025 23:43:09 UTC
On 2025-11-15 19:16, Max Brazhnikov wrote:
> On Sat, 15 Nov 2025 12:55:03 -0400 DtxdF@disroot.org wrote:
>>> Can we avoid variables in WWW for easier reading when taking a look at
>>> Makefiles? I remember that this subject was discussed some time ago...
>>   From rene@, when we talked about this a while ago:
>>
>>> Well, WWW is variable parsed by make, not by humans, so referencing
> The whole Makefile is parsed by the make, however we do have style rules to
> ease reading Makefiles by contributes and committers.
>
>>> PORTNAME is legal here. It *was* a literal text back when it was
>>> part of pkg-descr.
> WWW also was a literal text when it just migrated to Makefile. Why it should
> be obfuscated now? No difference for the make, but less convenient for humans:
> plain text url can be opened from the editor without running the make.
>
> I propose to supplement Porter's Handbook with a recommendation to avoid
> variables in WWW when it is explicitly set in the Makefile.
>
> Shall we put it to the vote? :)
>
> Cheers,
> Max
I'd echo this one, just because you can doesn't mean that should. Also, 
Porters Handbook already suggests this given the examples already listed 
such as 
https://docs.freebsd.org/en/books/porters-handbook/book/#porting-makefile

Best regards,
Daniel