From nobody Fri May 16 04:35:53 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZzDm95689z5w2qd; Fri, 16 May 2025 04:35:53 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZzDm94J7nz41Xb; Fri, 16 May 2025 04:35:53 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747370153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pvfWNdY3pQNTq5uQvL1z0t0GA7UTygOhc9VhtulVldE=; b=eZrT29YXe1qitQE5lB7I/5J8DaEJlWfdzFxdunJFCf9TU57PSSfU3HHfVefRavvvAJ8pvS 1s5EOmERepOZ7hfIOIGnWqy9P6U+7U/eRUb19crPEnN+D2OjJxNI0QtJB7ERQi9zz8BRAH c/OGHsxIVusbl9qGrSz+Rd2eFBjei1s7miWd5uDbDCPSuso18hXLENqnkAXVJ4tdHriIDj 7mAfAo3PRqowmJutO9VVnJL/PIzrsBJ9s5Gs2LYvvGRz5EB5MZ7wnDIYAD4fdGXHNUSrLs +OkZgyoNsxEOjoQKEiJYsLPB2uINfljX7N7YnRygWS/ujis5x3Lg7D1RlIEDhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747370153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pvfWNdY3pQNTq5uQvL1z0t0GA7UTygOhc9VhtulVldE=; b=aFd+RIivy0mzHx8KF35TZIDCrQFFb3r7G6tXmBLkG8EuN0sNF976n++OkhVAgfsLaXds3e iMhzn1AT66WL+38iWOflmKgsQ3vpQGM63wjyEk2+2wOjwZfHtJMetyPqLThLApQtczqpxr jY/L5KdRzvHP0uNSHwV01T3sEfEMGjwDt3o2Ll8WE8XTwx644KAEHXpHJ447QVRckgT1EB Hcnp9MW30kM/wL36KEBzRxjQ5BXReeqfg8q1bY8T7BkpYqej1AdGv8cY1SfE7TIUvwHtwl n/5JHyCaezhfMMR3gekDkRGPMfJUryt434/EIz3NrXqHU3em4FivG4WWObUVNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747370153; a=rsa-sha256; cv=none; b=ipe0zfpazTHacDXl+eXzKoXvuHme0JCZD/TiONukpUtNVzK8KtJUKQYv3X+Hti+Q1z5HYT a+iHIFqV0/3J3q+VSlxTOXGLpep4qdv3HZNR6PJSYDKfzWgb64rxQnZ5AVhoXs/MyZHSua EV3WJeqSBG3zTabx8xS2ifVQqNfJN9WpNVPWvmvj+Lcaml0TJv2RYIVKLjpcOtL6ZzNzFa 4+QoCx76ReUjpTL26Y5XNjFmX41IdMQUnDAGFgoqZH4jCUhNinWct9ZXtZvHOKIokjAmvR 475fLYW6bFH88SWON5lMgi8y9vqDAaUKSB2odcMh/WVkAhjSkKLe5rOznLonhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: by freefall.freebsd.org (Postfix, from userid 1033) id 73BCD10219; Fri, 16 May 2025 04:35:53 +0000 (UTC) Date: Fri, 16 May 2025 04:35:53 +0000 From: Alexey Dokuchaev To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: aba04fabf169 - main - audio/fluidsynth: Update to 2.4.6 and drop SDL(2) support Message-ID: References: <202505141958.54EJwREE079591@gitrepo.freebsd.org> <87e8daed-7c61-489e-b6be-e7df5754f48f@FreeBSD.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87e8daed-7c61-489e-b6be-e7df5754f48f@FreeBSD.org> On Thu, May 15, 2025 at 07:17:35PM +0200, Daniel Engberg wrote: > On 2025-05-15 06:49, Alexey Dokuchaev wrote: > > On Wed, May 14, 2025 at 07:58:27PM +0000, Daniel Engberg wrote: > > > commit aba04fabf1691f62f219f55d8fe0e461dd3efb6b > > > > > > audio/fluidsynth: Update to 2.4.6 and drop SDL(2) support > > > > > > * Drop SDL(2) support and move SDL(3) into SDL variable > > > > Why? From what I see in the CMakeLists.txt SDL2 is still supported, > > as it is more widely used, please kindly put it back would you? > > ...and if you read further, > https://github.com/FluidSynth/fluidsynth/blob/v2.4.6/CMakeLists.txt#L671 That means that the SDL2 option should be removed together with the actual support, i.e. in 2.5.0 or whatever that SDL2-less version would be. OTOH, since it's not enabled by default and SDL3 won't be pulled into my system I guess I can cope with it this time. > If anything we should start looking into > https://github.com/libsdl-org/sdl2-compat like other distros are already > doing such as: > > https://archlinux.org/packages/extra/x86_64/sdl2-compat/ > https://pkgs.alpinelinux.org/package/edge/community/x86_64/sdl2-compat That would be nice, but orthogonal to premature option removal. ./danfe