Re: git: c0407032f0cd - main - deskutils/nextcloudclient: Update to 3.16.0

On 12/03/25 16:59, Vladimir Druzenko wrote:
> 12.03.2025 17:07, Guido Falsi пишет:
>> On 12/03/25 14:20, Michael Reifenberger wrote:
>>> The branch main has been updated by mr:
>>>
>>> URL: https://cgit.FreeBSD.org/ports/commit/? 
>>> id=c0407032f0cd9e6d1acb2c3afd874841310b07b1
>>>
>>> commit c0407032f0cd9e6d1acb2c3afd874841310b07b1
>>> Author:     Michael Reifenberger <mr@FreeBSD.org>
>>> AuthorDate: 2025-03-12 13:19:35 +0000
>>> Commit:     Michael Reifenberger <mr@FreeBSD.org>
>>> CommitDate: 2025-03-12 13:19:35 +0000
>>>
>>>      deskutils/nextcloudclient: Update to 3.16.0
>>> ---
>>>   deskutils/nextcloudclient/Makefile                 |   5 +-
>>>   deskutils/nextcloudclient/distinfo                 |   6 +-
>>>   .../nextcloudclient/files/patch-doc_CMakeLists.txt |   9 +-
>>>   .../nextcloudclient/files/patch-doc_building.rst   |   8 +-
>>>   .../files/patch-src_csync_ConfigureChecks.cmake    |   4 +-
>>>   .../files/patch-src_libsync_configfile.cpp         |   4 +-
>>>   deskutils/nextcloudclient/pkg-plist                | 232 ++++++++++ 
>>> ++++++++++-
>>>   7 files changed, 244 insertions(+), 24 deletions(-)
>>>
>> [...]
>>> diff --git a/deskutils/nextcloudclient/files/patch- 
>>> src_libsync_configfile.cpp b/deskutils/nextcloudclient/files/patch- 
>>> src_libsync_configfile.cpp
>>> index 09f5dc7f7598..95097102e956 100644
>>> --- a/deskutils/nextcloudclient/files/patch-src_libsync_configfile.cpp
>>> +++ b/deskutils/nextcloudclient/files/patch-src_libsync_configfile.cpp
>>> @@ -1,6 +1,6 @@
>>> ---- src/libsync/configfile.cpp.orig    2017-12-20 15:03:02 UTC
>>> +--- src/libsync/configfile.cpp.orig    2025-03-06 09:00:02 UTC
>>>   +++ src/libsync/configfile.cpp
>>> -@@ -448,11 +448,22 @@ bool ConfigFile::skipUpdateCheck(const QString 
>>> &connec
>>> +@@ -653,11 +653,22 @@ bool ConfigFile::skipUpdateCheck(const QString 
>>> &connec
>>>        if (connection.isEmpty())
>>>            con = defaultConnection();
>>>    diff --git a/deskutils/nextcloudclient/pkg-plist b/deskutils/ 
>>> nextcloudclient/pkg-plist
>>> index 392339975592..578e54e1cfdb 100644
>>> --- a/deskutils/nextcloudclient/pkg-plist
>>> +++ b/deskutils/nextcloudclient/pkg-plist
>>> @@ -11,17 +11,229 @@ include/nextcloudsync/mirall/syncengine.h
>>>   include/nextcloudsync/mirall/syncfileitem.h
>>>   include/nextcloudsync/mirall/syncresult.h
>>>   lib/libnextcloud_csync.so
>>> -lib/libnextcloud_csync.so.%%VERSION%%
>>>   lib/libnextcloud_csync.so.0
>>> -%%KDE%%lib/libnextclouddolphinpluginhelper.so
>>> +lib/libnextcloud_csync.so.%%VERSION%%
>>> +lib/libnextclouddolphinpluginhelper.so
>>
>> Whi removing the KDE condition? I suspect this breaks the port when 
>> compiling with the KDE option disabled.
>>
>>>   lib/libnextcloudsync.so
>>> -lib/libnextcloudsync.so.%%VERSION%%
>>>   lib/libnextcloudsync.so.0
>>> +lib/libnextcloudsync.so.%%VERSION%%
>>>   lib/nextcloudsync_vfs_suffix.so
>>> -%%KDE%%%%QT_PLUGINDIR%%/kf6/kfileitemaction/ 
>>> nextclouddolphinactionplugin.so
>>> -%%KDE%%%%QT_PLUGINDIR%%/kf6/overlayicon/ 
>>> nextclouddolphinoverlayplugin.so
>>> +%%QT_PLUGINDIR%%/kf6/kfileitemaction/nextclouddolphinactionplugin.so
>>> +%%QT_PLUGINDIR%%/kf6/overlayicon/nextclouddolphinoverlayplugin.so
>>> share/applications/com.nextcloud.desktopclient.nextcloud.desktop
>>> -%%GNOME%%share/caja-python/extensions/syncstate-Nextcloud.py
>>> +share/caja-python/extensions/syncstate-Nextcloud.py
>>
>> Same here regarding gnome, and there are a few more later.
> 
>> -%%DOCS%%share/man/man1/nextcloud.1.gz
>> -%%DOCS%%share/man/man1/nextcloudcmd.1.gz
>> +share/man/man1/nextcloud.1.gz
>> +share/man/man1/nextcloudcmd.1.gz
>>  share/mime/packages/nextcloud.xml
>> -%%GNOME%%share/nautilus-python/extensions/syncstate-Nextcloud.py
>> -%%GNOME%%share/nemo-python/extensions/syncstate-Nextcloud.py
>> +share/nautilus-python/extensions/syncstate-Nextcloud.py
>> +share/nemo-python/extensions/syncstate-Nextcloud.py
>>
> %%DOCS%% and %%GNOME%% removed too.
> 

While testing I also discovered there is an issue when the WEBENGINE 
options is disabled, due to upstream changes.

I'll post a PR with fixes as soon as I have one ready.

-- 
Guido Falsi <madpilot@FreeBSD.org>