Re: git: f74c9aef8fe7 - main - misc/spnavcfg-devel: spacenavd config program

Am 28.07.25 um 18:07 schrieb Michael:
> Hi,
> 
> 
> Am 26. Juli 2025 10:11:59 MESZ schrieb Matthias Andree 
> <mandree@FreeBSD.org>:
> 
>     Am 23.07.25 um 11:34 schrieb Michael Reifenberger:
> 
>         The branch main has been updated by mr:
> 
>         URL: https://cgit.FreeBSD.org/ports/commit/?
>         id=f74c9aef8fe7e3f70ae89af6611bb389be723206 <https://
>         cgit.FreeBSD.org/ports/commit/?
>         id=f74c9aef8fe7e3f70ae89af6611bb389be723206>
> 
>         commit f74c9aef8fe7e3f70ae89af6611bb389be723206
>         Author: Michael Reifenberger <mr@FreeBSD.org>
>         AuthorDate: 2025-07-23 09:30:16 +0000
>         Commit: Michael Reifenberger <mr@FreeBSD.org>
>         CommitDate: 2025-07-23 09:33:31 +0000
> 
>         misc/spnavcfg-devel: spacenavd config program
>         Interactive configuration program for the Spacenav daemon
>         (misc/spacenavd-devel). Allows customizing the Axis and Button
>         behaviors.
>         There is a pending PR for misc/spnavcfg-devel but currently the
>         owner of it
>         is not responding so this is a adopted devel version
>         PR: 283067
>         ------------------------------------------------------------------------
>         misc/spnavcfg-devel/Makefile | 52 +
>         misc/spnavcfg-devel/Makefile.git_rev | 2 +
>         misc/spnavcfg-devel/distinfo | 3 +
>         misc/spnavcfg-devel/files/icons/devices.png.uu | 6396 ++++++++++
>         ++++++++++
>         .../files/icons/spnavcfg-128x128.png.uu | 307 +
>         .../files/icons/spnavcfg-256x256.png.uu | 903 +++
>         .../files/icons/spnavcfg-48x48.png.uu | 76 +
>         misc/spnavcfg-devel/files/icons/spnavcfg.png.uu | 2967 +++++++++
>         misc/spnavcfg-devel/files/newVersion.sh | 22 +
>         misc/spnavcfg-devel/pkg-descr | 2 +
>         10 files changed, 10730 insertions(+)
> 
> 
>     Michael,
> 
>     Please don't add binary stuff to the tree. uuencoding or base64
>     encoding it makes it even bulkier.
> 
>     Please find or place the icons/pngs somewhere reliable to download
>     and reference them. If that makes for different sites, see <https://
>     docs.freebsd.org/en/books/porters-handbook/book/#porting-master-
>     sites-n <https://docs.freebsd.org/en/books/porters-handbook/book/
>     #porting-master-sites-n>>
> 
> The problem I tried to circumvent here is the fact that the upstream
> repo uses GIT-LFS for the icons and so they are missing in the regular 
> github download.

> I found the workaround with uudecode in other ports too so I used it too.

We should fix those other ports, too.

> If there is a way to extract the icons during download directly from the 
> GIT-LFS repo that would be fine but I found none...

...so, either you FETCH_DEPENDS on git-lfs, and pre-fetch set up git-lfs 
for use with the download area,

ALTERNATIVE:

...or you use the download links on Github and add these as distfiles 
from a separate source as proposed in my earlier mail.  For instance, 
you don't need git-lfs to download
https://github.com/FreeSpacenav/spnavcfg/raw/refs/heads/master/icons/spnavcfg-128x128.png?download=
or
https://github.com/FreeSpacenav/spnavcfg/blob/v1.3/icons/spnavcfg-128x128.png?download=

...or you can put them into a subdir of public_distfiles/ on 
freefall.freebsd.org and reference them through LOCAL/mr/

> This is only a issue for the devel port since the release contains the 
> correct icons...

Still we don't need to bloat the ports/ tree with stuff that's readily 
available for download.

-- 
Matthias Andree
FreeBSD ports committer