Re: git: 42c7fa35dcb9 - main - Mk/bsd.port.mk: remove developer recommendations to apply pathfix

From: Daniel Engberg <diizzy_at_FreeBSD.org>
Date: Thu, 24 Jul 2025 16:15:17 UTC 
On 2025-07-24 10:44, Baptiste Daroussin wrote:
> The branch main has been updated by bapt:
>
> URL:https://cgit.FreeBSD.org/ports/commit/?id=42c7fa35dcb9fd63e338ef6ac1a7e8b5fe4ca173
>
> commit 42c7fa35dcb9fd63e338ef6ac1a7e8b5fe4ca173
> Author:     Baptiste Daroussin<bapt@FreeBSD.org>
> AuthorDate: 2025-07-23 15:55:41 +0000
> Commit:     Baptiste Daroussin<bapt@FreeBSD.org>
> CommitDate: 2025-07-24 08:44:29 +0000
>
>      Mk/bsd.port.mk: remove developer recommendations to apply pathfix
>      
>      The framework is already dealing with making sure the .pc files in
>      lib/pkgconfig are moved to libdata/pkgconfig since 2017
>      The other location where .pc files can be installed (share/pkgconfig)
>      is valid since 2022, so pathfix to deal with .pc files is now useless.
>      
>      Reviewed by:    mat (over matrix)
>      Differential Revision:https://reviews.freebsd.org/D51476
> ---
>   Mk/bsd.port.mk | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/Mk/bsd.port.mk b/Mk/bsd.port.mk
> index fb3e0cc839eb..0aa79aed7ed0 100644
> --- a/Mk/bsd.port.mk
> +++ b/Mk/bsd.port.mk
> @@ -3600,10 +3600,6 @@ install-ldconfig-file:
>   fixup-lib-pkgconfig:
>   	@if [ -d ${STAGEDIR}${PREFIX}/lib/pkgconfig ]; then \
>   		if [ -z "$$(${FIND} ${STAGEDIR}${PREFIX}/lib/pkgconfig -maxdepth 0 -empty)" ]; then \
> -			if [ -n "${DEVELOPER:Dyes}" ]; then \
> -				${ECHO_MSG} "===>   File(s) found in lib/pkgconfig while correct path is libdata/pkgconfig"; \
> -				${ECHO_MSG} "       Applying fix but consider using USES= pathfix or adjust install path"; \
> -			fi; \
>   			${MKDIR} ${STAGEDIR}${PREFIX}/libdata/pkgconfig; \
>   			${MV} ${STAGEDIR}${PREFIX}/lib/pkgconfig/* ${STAGEDIR}${PREFIX}/libdata/pkgconfig; \
>   		fi; \

Hi,

What's the rationale behind this except for obfuscation?You'll now end 
up with mismatching logs without any explanation as to why and it also 
adds more confusion especially for new users of the framework / new to 
porting.

Best regards, Daniel