git: 72eb9c02573a - main - check_have_symbols.sh: remove pipefail shell option

From: Andriy Gapon <avg_at_FreeBSD.org>
Date: Thu, 03 Jul 2025 15:52:14 UTC
The branch main has been updated by avg:

URL: https://cgit.FreeBSD.org/ports/commit/?id=72eb9c02573a4921df8151b3a7edb22904480310

commit 72eb9c02573a4921df8151b3a7edb22904480310
Author:     Andriy Gapon <avg@FreeBSD.org>
AuthorDate: 2025-07-03 15:43:07 +0000
Commit:     Andriy Gapon <avg@FreeBSD.org>
CommitDate: 2025-07-03 15:51:58 +0000

    check_have_symbols.sh: remove pipefail shell option
    
    There is only one pipeline, with two commands, in the script and the
    receiving awk script is carefully written to produce a correct exit
    status for any situation.
    
    For that reason pipefail was already redundant.  More than that,
    pipefail was actually harmful because the awk script would terminate
    early upon detecting success.  Because of that, readelf could get
    SIGPIPE and terminate with non-zero status.  "Thanks" to pipefail the
    whole pipeline would have non-zero exit status well.
    
    The issue manifested itself as sporadic failures of the script during
    bulk poudriere builds.
    
    Discussed with: bapt
---
 Mk/Scripts/check_have_symbols.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Mk/Scripts/check_have_symbols.sh b/Mk/Scripts/check_have_symbols.sh
index ee3095dabf74..652c975109dd 100644
--- a/Mk/Scripts/check_have_symbols.sh
+++ b/Mk/Scripts/check_have_symbols.sh
@@ -1,7 +1,6 @@
 #!/bin/sh
 
 set -eu
-set -o pipefail
 
 # the 3 implementations of readelf we can use have different output, but they all have a similarity
 # for the .gnu.version_d section they all have the symbol version in last element of their output