Re: git: 4ca613c4414b - main - irc/eggdrop: Fix build, bump PORTREVISION

Reply: Ryan Steinmetz : "Re: git: 4ca613c4414b - main - irc/eggdrop: Fix build, bump PORTREVISION"
In reply to: Ryan Steinmetz : "git: 4ca613c4414b - main - irc/eggdrop: Fix build, bump PORTREVISION"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Thu, 30 Jan 2025 05:57:44 UTC

On Wed, Jan 29, 2025 at 06:14:30PM +0000, Ryan Steinmetz wrote:
> commit 4ca613c4414b2dfaa9de5336b6da5a74aa73f5d4
> 
>   irc/eggdrop: Fix build, bump PORTREVISION
> 
>   PR:             283584
> ...
>  post-patch:
> -	@${REINPLACE_CMD} -e 's|tcl.h|tcl${TCL_VER}/tcl.h|g' ${WRKSRC}/src/mod/python.mod/pycmds.c
> +	@${SED} -i '' -e '25d' ${WRKSRC}/src/mod/python.mod/pycmds.c

There are several issues with this commit.  It doesn't explain what
was the problem and how removing 25th line fixes it.  Wasn't there
a better anchor than the line number?  Also, why use ${SED} -i ''
instead of canonical ${REINPLACE_CMD}?  Last, if it's a *build* fix,
why bump port revision?

./danfe