Re: git: 0654456e0611 - main - sysutils/lsof: fix breakage after 3a0cdb2675e6
- In reply to: Larry Rosenman : "Re: git: 0654456e0611 - main - sysutils/lsof: fix breakage after 3a0cdb2675e6"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 13 Jan 2025 14:15:33 UTC
In message <fcfa27036f55433500f8111894bf98f5@FreeBSD.org>, Larry Rosenman
write
s:
> On 01/13/2025 1:30 am, Rainer Hurling wrote:
> > Am 13.01.25 um 05:56 schrieb Cy Schubert:
> >> In message <202501112057.50BKvD38009217@gitrepo.freebsd.org>, Larry
> >> Rosenman wr
> >> ites:
> >>> The branch main has been updated by ler:
> >>>
> >>> URL:
> >>> https://cgit.FreeBSD.org/ports/commit/?id=0654456e061181e74fd0eb06f9b966
> >>> a4e759769d
> >>>
> >>> commit 0654456e061181e74fd0eb06f9b966a4e759769d
> >>> Author: Larry Rosenman <ler@FreeBSD.org>
> >>> AuthorDate: 2025-01-11 20:51:00 +0000
> >>> Commit: Larry Rosenman <ler@FreeBSD.org>
> >>> CommitDate: 2025-01-11 20:51:00 +0000
> >>>
> >>> sysutils/lsof: fix breakage after 3a0cdb2675e6
> >>> - put /usr/src first.
> >>> ---
> >>> sysutils/lsof/Makefile | 3 ++-
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/sysutils/lsof/Makefile b/sysutils/lsof/Makefile
> >>> index f65273c5c932..a10d7db4320a 100644
> >>> --- a/sysutils/lsof/Makefile
> >>> +++ b/sysutils/lsof/Makefile
> >>> @@ -3,6 +3,7 @@
> >>> PORTNAME= lsof
> >>> DISTVERSION= 4.99.4
> >>> +PORTREVISION= 1
> >>> PORTEPOCH= 8
> >>> CATEGORIES= sysutils
> >>> @@ -40,7 +41,7 @@ BOOKE_CFLAGS= -DBOOKE
> >>> CONFIGURE_SCRIPT= Configure
> >>> CONFIGURE_ARGS= -n freebsd
> >>> CONFIGURE_ENV= FREEBSD_SYS="${SRC_BASE}/sys" \
> >>> - LSOF_CC="${CC}"
> >>> + LSOF_CC="${CC} -idirafter /usr/src"
> >>
> >> This is wrong. If /usr/src is updated, i.e. git pull, but not
> >> installed,
> >> i.e. installworld, header files and libraries may be mismatched.
> >>
> >> Note: The follow-on 1ec769ae9a64 perpetuates this wrong-ness.
> >>
> >
> > Now it builds fine on 14.x and 13.x, but continues to fail on
> > 15.0-CURRENT:
> >
> > ===> Building for lsof-4.99.4_1,8
> > (cd lib; /usr/bin/make DEBUG="-O2" CFGF="-pipe -fstack-protector-strong
> > -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_DUP2
> > -DHAS_CLOSEFROM -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT
> > -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2
> > -DHAS_VM_MEMATTR_T -DNEEDS_DEVICE_T -DHAS_CDEV2PRIV -DHAS_SYS_SX_H
> > -DHASMSDOSFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT
> > -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DFREEBSDV=15000
> > -DHASFDESCFS=2 -DHASPROCFS -DHASPSEUDOFS -DHASNULLFS -DHAS9660FS
> > -DHASIPv6 -DHASUTMPX -DHAS_XTCPCB_TMAXSEG -DHAS_KF_SOCK_SENDQ
> > -DHAS_KF_FILE_NLINK -DHAS_STRFTIME -DLSOF_VSTR=\"15.0-CURRENT\"")
> > cc -pipe -fstack-protector-strong -fno-strict-aliasing
> > -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_DUP2 -DHAS_CLOSEFROM
> > -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS
> > -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2
> > -DHAS_VM_MEMATTR_T -DNEEDS_DEVICE_T -DHAS_CDEV2PRIV -DHAS_SYS_SX_H
> > -DHASMSDOSFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT
> > -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DFREEBSDV=15000
> > -DHASFDESCFS=2 -DHASPROCFS -DHASPSEUDOFS -DHASNULLFS -DHAS9660FS
> > -DHASIPv6 -DHASUTMPX -DHAS_XTCPCB_TMAXSEG -DHAS_KF_SOCK_SENDQ
> > -DHAS_KF_FILE_NLINK -DHAS_STRFTIME -DLSOF_VSTR="15.0-CURRENT"
> > -I/usr/src/sys -I.. -I../include -Idialects/freebsd -O2 -c ckkv.c -o
> > ckkv.o
> > In file included from ckkv.c:31:
> > In file included from ./common.h:253:
> > In file included from ../dlsof.h:171:
> > In file included from /usr/src/sys/rpc/rpc.h:68:
> > /usr/src/sys/rpc/svc.h:341:25: error: field has incomplete type 'struct
> > sysctl_ctx_list'
> > 341 | struct sysctl_ctx_list sp_sysctl;
> > | ^
> > /usr/src/sys/rpc/svc.h:341:9: note: forward declaration of 'struct
> > sysctl_ctx_list'
> > 341 | struct sysctl_ctx_list sp_sysctl;
> > | ^
> > /usr/src/sys/rpc/svc.h:568:12: warning: declaration of 'struct
> > sysctl_oid_list' will not be visible outside of this function
> > [-Wvisibility]
> > 568 | struct sysctl_oid_list *sysctl_base);
> > | ^
> > 1 warning and 1 error generated.
> > *** Error code 1
> >
> >
> > This is in Poudiere with FreeBSD 15.0-CURRENT 1500030 amd64.
> >
> >
> >>> BUILD_DEPENDS= ${LOCALBASE}/bin/bash:shells/bash
> >>> # GCC needs -lzfs -lzpool for reasons unknown. If someone can
> >>>
> >>
> >>
> We know. Need to figure out how to fix it :(
> see pr's
First, I will pull back my initial comment. svc.h and clnt.h are
"sanitized" before they're installed into /usr/include/rpc.
Secondly, the breakage is likely not due to 3a0cdb2675e6 but some other
commit. See below, it is not the same as the posted error.
-- dmnt.o ---
In file included from dmnt.c:36:
In file included from lib/common.h:253:
In file included from ./dlsof.h:171:
In file included from /usr/src/sys/rpc/rpc.h:68:
/usr/src/sys/rpc/svc.h:341:25: error: field has incomplete type 'struct
sysctl_ctx_list'
341 | struct sysctl_ctx_list sp_sysctl;
| ^
--- dnode.o ---
In file included from dnode.c:36:
In file included from lib/common.h:253:
In file included from ./dlsof.h:171:
In file included from /usr/src/sys/rpc/rpc.h:68:
/usr/src/sys/rpc/svc.h:341:25: error: field has incomplete type 'struct
sysctl_ctx_list'
341 | struct sysctl_ctx_list sp_sysctl;
| ^
--- lib/liblsof.a ---
In file included from ckkv.c:31:
In file included from ./common.h:253:
In file included from ../dlsof.h:171:
In file included from /usr/src/sys/rpc/rpc.h:68:
--- dproc.o ---
In file included from dproc.c:36:
In file included from lib/common.h:253:
In file included from ./dlsof.h:171:
In file included from /usr/src/sys/rpc/rpc.h:68:
/usr/src/sys/rpc/svc.h:341:25: error: field has incomplete type 'struct
sysctl_ctx_list'
341 | struct sysctl_ctx_list sp_sysctl;
| ^
--- lib/liblsof.a ---
/usr/src/sys/rpc/svc.h:341:25: error: field has incomplete type 'struct
sysctl_ctx_list'
--- dnode.o ---
/usr/src/sys/rpc/svc.h:341:9: note: forward declaration of 'struct
sysctl_ctx_list'
--- dproc.o ---
/usr/src/sys/rpc/svc.h:341:9: note: forward declaration of 'struct
sysctl_ctx_list'
341 | struct sysctl_ctx_list sp_sysctl;
| ^
--- dnode.o ---
341 | struct sysctl_ctx_list sp_sysctl;
| ^
--- dmnt.o ---
/usr/src/sys/rpc/svc.h:341:9: note: forward declaration of 'struct
sysctl_ctx_list'
--- lib/liblsof.a ---
341 | struct sysctl_ctx_list sp_sysctl;
--- dmnt.o ---
341 | struct sysctl_ctx_list sp_sysctl;
| ^
--- lib/liblsof.a ---
| ^
/usr/src/sys/rpc/svc.h:341:9: note: forward declaration of 'struct
sysctl_ctx_list'
341 | struct sysctl_ctx_list sp_sysctl;
| ^
--- dnode.o ---
/usr/src/sys/rpc/svc.h:568:12: warning: declaration of 'struct
sysctl_oid_list' will not be visible outside of this function [-Wvisibility]
568 | struct sysctl_oid_list *sysctl_base);
| ^
--- lib/liblsof.a ---
/usr/src/sys/rpc/svc.h:568:12: warning: declaration of 'struct
sysctl_oid_list' will not be visible outside of this function [-Wvisibility]
568 | struct sysctl_oid_list *sysctl_base);
| ^
--- dmnt.o ---
/usr/src/sys/rpc/svc.h:568:12: warning: declaration of 'struct
sysctl_oid_list' will not be visible outside of this function [-Wvisibility]
568 | struct sysctl_oid_list *sysctl_base);
| ^
--- dproc.o ---
/usr/src/sys/rpc/svc.h:568:12: warning: declaration of 'struct
sysctl_oid_list' will not be visible outside of this function [-Wvisibility]
568 | struct sysctl_oid_list *sysctl_base);
| ^
--- dmnt.o ---
1 warning and 1 error generated.
*** [dmnt.o] Error code 1
make: stopped making "all" in /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.9
9.4
--- lib/liblsof.a ---
*** [lib/liblsof.a] Error code 6
make: stopped making "all" in /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.9
9.4
--- dproc.o ---
1 warning and 1 error generated.
--- dnode.o ---
1 warning and 1 error generated.
--- dproc.o ---
*** [dproc.o] Error code 1
make: stopped making "all" in /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.9
9.4
--- dnode.o ---
*** [dnode.o] Error code 1
make: stopped making "all" in /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.9
9.4
make: 4 errors
make: stopped making "all" in /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.9
9.4
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1
Stop.
make: stopped making "build" in /usr/ports/sysutils/lsof
=>> Cleaning up wrkdir
===> Cleaning for lsof-4.99.4_1,8
My first patch fixes the above. The second patch to address this email
thread is being worked on. The second problem, the one in this email
thread, is due to 3a0cdb2675e6.
> --
> Larry Rosenman http://people.freebsd.org/~ler
> Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org
> US Mail: 13425 Ranch Road 620 N, Apt 718, Austin, TX 78717-1010
--
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org
NTP: <cy@nwtime.org> Web: https://nwtime.org
e^(i*pi)+1=0