Re: git: 34b444edf631 - main - devel/icu: Revert unrelated changes in previous commit

On Fri, Feb 21, 2025 at 8:27 AM Daniel Engberg <diizzy@freebsd.org> wrote:

> The branch main has been updated by diizzy:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=34b444edf6319efbf1ee2c8b75e3e4db1f72378c
>
> commit 34b444edf6319efbf1ee2c8b75e3e4db1f72378c
> Author:     Daniel Engberg <diizzy@FreeBSD.org>
> AuthorDate: 2025-02-20 23:40:38 +0000
> Commit:     Daniel Engberg <diizzy@FreeBSD.org>
> CommitDate: 2025-02-20 23:40:42 +0000
>
>     devel/icu: Revert unrelated changes in previous commit
>
>     Remove unrelated and undocumented changes made in commit
>     312c3df64b879c24fafa08ddfcef40b3069be399
>

ARE YOU A COMMIT LOG POLICE?

I consider this to be hostile behavior. I am quite certain this is directed
at me. Please STOP this behavior.


>     Approved by:    portmgr (blanket)
>

To portmgr:

Could you please clarify if it is covered by the blanket?
Thanks.


> ---
>  devel/icu/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/devel/icu/Makefile b/devel/icu/Makefile
> index e3b4960e7d7a..911f9bce54cf 100644
> --- a/devel/icu/Makefile
> +++ b/devel/icu/Makefile
> @@ -35,7 +35,7 @@ WRKSRC=               ${WRKDIR}/icu/source
>  ICUMAJOR=      ${PORTVERSION:C/\..*//}
>  PLIST_SUB+=    ICUMAJOR=${ICUMAJOR} ICUVER=${PORTVERSION:C/r.?/1/}
>
> -.if !defined(PKGNAMESUFFIX)
> +.ifndef PKGNAMESUFFIX
>  post-install:
>         @${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/g* \
>                 ${STAGEDIR}${PREFIX}/bin/*conv \
> @@ -47,6 +47,6 @@ post-install:
>  # Filename varies by endianness: icudt<major>b.dat vs. icudt<major>l.dat
>         @(cd ${STAGEDIR}${PREFIX} && ${ECHO_CMD} \
>                 ${DATADIR_REL}/${PORTVERSION:C/r.?/1/}/icudt*.dat
> >>${TMPPLIST})
> -.endif # !defined(PKGNAMESUFFIX)
> +.endif # PKGNAMESUFFIX
>
>  .include <bsd.port.mk>
>
>