From nobody Fri Feb 21 06:07:21 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YzfmV3mpzz5p9fj; Fri, 21 Feb 2025 06:07:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YzfmV0GHdz3tHg; Fri, 21 Feb 2025 06:07:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740118042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4thT0cNT36bKg8bE8i+f/aBFZU26xUksC397aWlkQn0=; b=pUBCvuoaK4wy8EwJCjfAO7LJzo6Ikw4CwFbTwgoB98ZQn6ohN/yiw8c64vk25rAgqbjvo2 JmHpbnKroec+UetDDAQXUWrY2ofMEp1DsgJcf6AG+HdoveJPs2VEuSGqM8LXpivR3v0cQT afGtPINtAVlhc3XX750KUIJ7kAG2HgxdlN4ED4IG5ESqUlTy8K9mdbF+oXgMrBXb/CVQk/ pBLww5KHL81AQ+gchskGbcNL/aorsjmpkUGbQQBDNh88QeicQsuoZ/cFfG0YTfyRL9F1oT KDh16C2qfIR85MvuGesNrfVPP0VGLWu6pN2nQQjBE0LbLGg7QZT+aZltmRLfpA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740118042; a=rsa-sha256; cv=none; b=DpWJ5rriH5HA69sPJhsmKHWUJ3JuwOC28jnkcnU2FGRhMaigTVChXyO8P4P2c/Pt1YQO1Y mUcQykojDGcpElaEhF7h/FhPjqAOPDN5ujc6GAR5GaGobobJK9TfP8uYqzEvSDBZhZIycY dwGpOyAEbXN4ql9lJ4a4y26vcnesm5RGucsBNXcxrsCqKAprtuXZ03sP68kl3pSbqqAa3z cBzGHgJ/ysfD6YfyvQZZ6T0E4vyqT9/6LpfSPff+Yc8D1JouW8W3Z2cvXMVNRuTJBKuy8s yws5T6mxQVdhgCE+qjVonT4dkgNu/vV7oTC2xfD287Bvfn+OgMk6RG9kDeKbgQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740118042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4thT0cNT36bKg8bE8i+f/aBFZU26xUksC397aWlkQn0=; b=IVBt8KKk9oN3qCRIryLsBj0G8MKvYALtHeTHl4R8GhK+aPZScj+cLya5s0fbAZDBQ3J5o3 9XWyOL0I1rtvAo6BQVlFxWjh5HDOCESMWrI7nVy3PEePDEjnHHstTlokjP0D+bQpaJ8+rf qERRyQt2kGz8gQ5Hif94vWUOKIMXMoY/b6vwvw4ZNYTFRwv/NjccCsb9vL5m9V9Ye2xydB OGbiwkYjsD0doFfQxVTxSWgD531y+3XZ7rkmVD5AFQQ0uDvlRqEsGQ/6kpKyl0GiAlLzkJ bcFAOeRBCjb1tiShFasAnDkxNCWbQ0ZjyTDMgXtZIynyZoyN7hy07b8rX/AHAw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YzfmT6yxVz1NvN; Fri, 21 Feb 2025 06:07:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51L67LWg036757; Fri, 21 Feb 2025 06:07:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51L67LSZ036754; Fri, 21 Feb 2025 06:07:21 GMT (envelope-from git) Date: Fri, 21 Feb 2025 06:07:21 GMT Message-Id: <202502210607.51L67LSZ036754@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Andriy Gapon Subject: git: d0cf6f344404 - main - science/pulseview: fix crash on startup when libcxx has asserts enabled List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d0cf6f3444047de16dae99d6b05264014ab7813c Auto-Submitted: auto-generated The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/ports/commit/?id=d0cf6f3444047de16dae99d6b05264014ab7813c commit d0cf6f3444047de16dae99d6b05264014ab7813c Author: Andriy Gapon AuthorDate: 2025-02-17 09:48:37 +0000 Commit: Andriy Gapon CommitDate: 2025-02-21 06:06:49 +0000 science/pulseview: fix crash on startup when libcxx has asserts enabled The program's code unlocks a mutex that it never locked. When libcxx is built with debug (e.g., on stable branches) there is a crash on an assert that pthread_mutex_unlock succeeds. This change adds a patch for the problem. PR: 282727 Approved by: uzsolt --- science/pulseview/files/patch-pv_data_decodesignal.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/science/pulseview/files/patch-pv_data_decodesignal.cpp b/science/pulseview/files/patch-pv_data_decodesignal.cpp new file mode 100644 index 000000000000..b4020899840e --- /dev/null +++ b/science/pulseview/files/patch-pv_data_decodesignal.cpp @@ -0,0 +1,15 @@ +--- pv/data/decodesignal.cpp.orig 2020-03-31 23:41:18.000000000 +0300 ++++ pv/data/decodesignal.cpp 2024-11-08 15:04:00.844432000 +0200 +@@ -251,11 +251,8 @@ + + void DecodeSignal::resume_decode() + { +- // Manual unlocking is done before notifying, to avoid waking up the +- // waiting thread only to block again (see notify_one for details) +- decode_pause_mutex_.unlock(); +- decode_pause_cond_.notify_one(); + decode_paused_ = false; ++ decode_pause_cond_.notify_one(); + } + + bool DecodeSignal::is_paused() const