Re: git: 9c1d7dcbc162 - main - www/dillo2: Add GIF option

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Tue, 18 Feb 2025 19:42:54 UTC
On Tue, Feb 18, 2025 at 06:31:47PM +0000, Cy Schubert wrote:
> commit 9c1d7dcbc16262b2c2f10cb92be102de6a97638d
> 
>   www/dillo2: Add GIF option
> 
>   This option was enabled by default by the dillo2 ./configure. Add
>   a knob to control this option.
> 
>  PORTNAME=	dillo
>  DISTVERSION=	3.1.1
> +PORTREVISION=	1

If it's enabled by default, you don't need to bump.

> +OPTIONS_DEFAULT=	COOKIES GIF IPV6 JPEG PNG THREADS
>  
>  COOKIES_DESC=		Cookie support
>  HYPHENATION_DESC=	Hyphenation file(s) for HYPHENATION_LANGS
> @@ -46,6 +47,8 @@ DEBUG_CONFIGURE_ENABLE=	gprof rtfl
>  
>  COOKIES_CONFIGURE_ENABLE=	cookies
>  
> +GIF_CONFIGURE_ENABLE=	gif
> +

Since there's no accompanying LIB_DEPENDS, what's the reason to
add an option?  If GIF support comes from the bundled library it
should have been mentioned in the commit log, otherwise I see no
reason to disable it.

./danfe