From nobody Mon Feb 17 13:43:44 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YxP5857BLz5nfg8; Mon, 17 Feb 2025 13:43:56 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YxP584YJ6z3h8h; Mon, 17 Feb 2025 13:43:56 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739799836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eYBQFuzvgZZdimo09eHivvP5yJwEgOvUoo370O9f6g8=; b=jtCm1glsfpzDrjSJoSnNzeH2HnPOLmji76mcAArfhGkSU5KYNdAhzQoqPiQ1MIWwf+a4+w aF+enn5F1c/BFQv6nBd81BPPuyueZ6bMX6COOa/7muoLxsgvwSxrGEo+OiXBH2IaYRKY1a 5nLGHZPjpmIvXdIAERqS70TTBMzpf9SR7Kcgm2CFsS7+8nSaz7f8eUcHBLW4+BzI/epmXj 3t4Z6Regddf955kjVwVvVz17+M6YWY0fkLoYl1Xfv2nqk5XZ+qpqDW+zIzDwZm1YdWFKQK jzzxwgR6VsfcqDSLjR3mJXHqdmb9Ju5gzcoXPYttqfLqlPjFAlJDh9qXUhXzsQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739799836; a=rsa-sha256; cv=none; b=WjffbHFvQMlNc2sF67N7u8pps9zJYzkbGAbcsFhwaH5lQs0gEE2MaNKPU1I9eYo0Cx7NQr cTim5DfHRSKvQzuyL6j0VKUVqLsnPcA4F8fGlrfpddZ72pEUVpqlkFlpbWtgRP9cglnVov 4iY8JN4bh0HCjOXy4ekOAbbzFEtKzA9ptH1K4XLFwv7xGmVrXryEt1Nq0qZw3Ddti4Dmrb 1lRHO4qwAFUs82/zmbUedDT22Idgwe75McAqCSUlz6rTILLgYx3WNNW+d5ekX1O4xySQu8 E3yPWYLTsq1DXTX5wQsMO2OKZYeXXm/3+Eq45LLMoOq5YXkyWnhn/abtviGnLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739799836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eYBQFuzvgZZdimo09eHivvP5yJwEgOvUoo370O9f6g8=; b=gEAabVY8ubGurrzxLI90wiPHRBgS/2OaIaXiad+JTyHnlkxoIbwxFvkIVcJH/MxYL/ZvD1 jt+hS9QiOuhkp/w5ivaBxDmIw69bDPXn0w6fx8z7YJBVR3rlhptvy3sQaVmOsLg+c5Ph+p uQ8i7wHdv3EG1Z4t2El3iMSoQmLOJIpFUaAk0qImrD35bduHBnwmZ0Dws25UrSWBiZFsuU rh2ewMxGrEMn9fqweORqarkXwZ7Er2iPA2abIBrY0MZJIpAQgOGtSh9WU7V/9OIxJwCrF0 IeGDRZKNbBBGVqnF4O1TuxqUmqsEfottC66biavZ17RODlH0o7YA8d0H0LT+oA== Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YxP5842k6z2qc; Mon, 17 Feb 2025 13:43:56 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7c07d915ae9so60354085a.3; Mon, 17 Feb 2025 05:43:56 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWBXilnuiJbAsZr5y/YCtpPe1m3YRBvu+c4DVegG48M6/ivrzKvOQPv2q8d2cxbaeEl5xYepoNl8Q==@freebsd.org, AJvYcCWTXxFy4KPmw8jzowks7UEwrUadNI3yfD9uJ+R5+9S7rCAJQhrZ6QPgTtiu9vChJ+biARwBmIz9eBEeaeZjjB77L6JbFiCpyw==@freebsd.org, AJvYcCWWrKcS7CWgYh0yLVp9Py9Zsr79wF5dosEoUm4/dxD4c03/KQ1g05LEhep8vDuRtg/qVZvGVOa8QArTjFSlyVrPqQ==@freebsd.org, AJvYcCXBkFF/kfT9sA2Y9hMI1gkOlALKrKyhgkcv0ZUW1iar6FRnNcbfiU+t2M69PDxlghyqIP4HXqzgun+vfGJuUsZgJ/2Ce5w=@freebsd.org X-Gm-Message-State: AOJu0Yw4YRzFp6sCmqux8BkxOvb5EEkjsMWN5ueF78cvm0MyEzIzKVHn m/dpeA7lnNzG0CVtP29GfuwBFM1mOo0y7TzGB5alC/Z+JVoPA4pwATEVpj0iUoTUIB8Rn+umhLz XSg+8aFwFiDxIqZ7iEAYehS+HuF0= X-Google-Smtp-Source: AGHT+IG/nJmSV8eRyxSUOshIv0rK+eylNz0BFkX5IIavoTB6OnhhxeGuYaVJmf0txxz2wxuybpvl/3k/u/CatRBhM5I= X-Received: by 2002:ac8:5ac5:0:b0:471:915c:1e93 with SMTP id d75a77b69052e-471dbec101fmr57166371cf.15.1739799836038; Mon, 17 Feb 2025 05:43:56 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 References: <202502160003.51G03e8A076660@gitrepo.freebsd.org> <34f65a4f-2ab9-4f39-9631-842c47077d5d@freebsd.org> In-Reply-To: From: Nuno Teixeira Date: Mon, 17 Feb 2025 13:43:44 +0000 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZmdyhzFhgK0hXTWBM7MgbNzaUppIoPGYZhh3mC532_R3AKmkEULnRfQ88g Message-ID: Subject: Re: git: a4c87a5576a9 - main - devel/py-libevdev: add new port To: Jan Beich Cc: "Jason E. Hale" , Charlie Li , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, awoonyaa@gmail.com Content-Type: multipart/alternative; boundary="0000000000003524de062e56b75a" --0000000000003524de062e56b75a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable pep517 can deal with setup.py: =3D=3D=3D> Building for py311-libevdev-0.11_1 * Getting build dependencies for wheel... /usr/local/lib/python3.11/site-packages/setuptools/dist.py:771: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead warnings.warn( running egg_info writing libevdev.egg-info/PKG-INFO writing dependency_links to libevdev.egg-info/dependency_links.txt writing top-level names to libevdev.egg-info/top_level.txt reading manifest file 'libevdev.egg-info/SOURCES.txt' adding license file 'COPYING' writing manifest file 'libevdev.egg-info/SOURCES.txt' * Building wheel... Jan Beich escreveu (segunda, 17/02/2025 =C3=A0(s) 13:1= 8): > "Jason E. Hale" writes: > > > On Mon, Feb 17, 2025 at 6:04=E2=80=AFAM Jan Beich = wrote: > > > >> > >> Charlie Li writes: > >> > >> > Needs LIB_DEPENDS on devel/libevdev. > >> > >> Done in bc369d345016. > >> > >> > Also the project includes a pytest testing framework so > >> > USE_PYTHON=3Dpytest should be added. > >> > >> Leaving up to the maintainer: > >> - devel/libevdev has -Dtests=3Ddisabled, so why enable here? > >> - /dev/uinput fails inside jail to create synthetic /dev/input/* > >> - Some tests fail for other reasons e.g., missing linsysfs(4) node > >> - USES=3Dpytest doesn't work for me WITH_TESTING=3Dyes (d7700ff7fde6) > > > > The python tests are separate. USES=3Dpytest is not valid, it should be > > USE_PYTHON=3Dpytest. > > Sorry, I forgot USES=3Dpytest exists and meant USE_PYTHON=3Dpytest. > Even devel/py-pytest itself fails WITH_TESTING=3Dyes for me. > I don't maintain this port to trust my own manual testing. > > > The tests work fine for me. > > Did you run tests as root user? Otherwise, /dev/uinput tests are skipped. > Did you run tests via poudriere? Otherwise, tests run fine (with failures= ). > > > This port should also be built with USE_PYTHON=3Dpep517, not distutils. > > To make this happen, the port also needs: > > BUILD_DEPENDS=3D ${PY_SETUPTOOLS} \ > > > > ${PYTHON_PKGNAMEPREFIX}wheel>0:devel/py-wheel@${PY_FLAVOR} > > I disagree. Upstream doesn't ship pyproject.toml. > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --0000000000003524de062e56b75a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
pep517 can deal with setup.py:

=3D=3D=3D> =C2=A0Building for py311-libevdev-0.11_1
* Getting buil= d dependencies for wheel...
/usr/local/lib/python3.11/site-packages/setu= ptools/dist.py:771: UserWarning: Usage of dash-separated 'description-f= ile' will not be supported in future versions. Please use the underscor= e name 'description_file'
instead
=C2=A0 warnings.warn(
ru= nning egg_info
writing libevdev.egg-info/PKG-INFO
writing dependency_= links to libevdev.egg-info/dependency_links.txt
writing top-level names = to libevdev.egg-info/top_level.txt
reading manifest file 'libevdev.e= gg-info/SOURCES.txt'
adding license file 'COPYING'
writin= g manifest file 'libevdev.egg-info/SOURCES.txt'
* Building wheel= ...

Jan Beich <jbeich@freebsd.org> escreveu (segunda, 17/02/2025 =C3=A0(s) = 13:18):
"Ja= son E. Hale" <jhale@freebsd.org> writes:

> On Mon, Feb 17, 2025 at 6:04=E2=80=AFAM Jan Beich <jbeich@freebsd.org> wrote: >
>>
>> Charlie Li <vishwin@freebsd.org> writes:
>>
>> > Needs LIB_DEPENDS on devel/libevdev.
>>
>> Done in bc369d345016.
>>
>> > Also the project includes a pytest testing framework so
>> > USE_PYTHON=3Dpytest should be added.
>>
>> Leaving up to the maintainer:
>> - devel/libevdev has -Dtests=3Ddisabled, so why enable here?
>> - /dev/uinput fails inside jail to create synthetic /dev/input/* >> - Some tests fail for other reasons e.g., missing linsysfs(4) node=
>> - USES=3Dpytest doesn't work for me WITH_TESTING=3Dyes (d7700f= f7fde6)
>
> The python tests are separate. USES=3Dpytest is not valid, it should b= e
> USE_PYTHON=3Dpytest.

Sorry, I forgot USES=3Dpytest exists and meant USE_PYTHON=3Dpytest.
Even devel/py-pytest itself fails WITH_TESTING=3Dyes for me.
I don't maintain this port to trust my own manual testing.

> The tests work fine for me.

Did you run tests as root user? Otherwise, /dev/uinput tests are skipped. Did you run tests via poudriere? Otherwise, tests run fine (with failures).=

> This port should also be built with USE_PYTHON=3Dpep517, not distutils= .
> To make this happen, the port also needs:
> BUILD_DEPENDS=3D ${PY_SETUPTOOLS} \
>
> ${PYTHON_PKGNAMEPREFIX}wheel>0:devel/py-wheel@${PY_FLAVOR}

I disagree. Upstream doesn't ship pyproject.toml.


--
Nuno Teixeira
=
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--0000000000003524de062e56b75a--