Re: git: a4c87a5576a9 - main - devel/py-libevdev: add new port

"Jason E. Hale" <jhale@freebsd.org> writes:

> On Mon, Feb 17, 2025 at 6:04 AM Jan Beich <jbeich@freebsd.org> wrote:
>
>>
>> Charlie Li <vishwin@freebsd.org> writes:
>>
>> > Needs LIB_DEPENDS on devel/libevdev.
>>
>> Done in bc369d345016.
>>
>> > Also the project includes a pytest testing framework so
>> > USE_PYTHON=pytest should be added.
>>
>> Leaving up to the maintainer:
>> - devel/libevdev has -Dtests=disabled, so why enable here?
>> - /dev/uinput fails inside jail to create synthetic /dev/input/*
>> - Some tests fail for other reasons e.g., missing linsysfs(4) node
>> - USES=pytest doesn't work for me WITH_TESTING=yes (d7700ff7fde6)
>
> The python tests are separate. USES=pytest is not valid, it should be
> USE_PYTHON=pytest.

Sorry, I forgot USES=pytest exists and meant USE_PYTHON=pytest.
Even devel/py-pytest itself fails WITH_TESTING=yes for me.
I don't maintain this port to trust my own manual testing.

> The tests work fine for me.

Did you run tests as root user? Otherwise, /dev/uinput tests are skipped.
Did you run tests via poudriere? Otherwise, tests run fine (with failures).

> This port should also be built with USE_PYTHON=pep517, not distutils.
> To make this happen, the port also needs:
> BUILD_DEPENDS= ${PY_SETUPTOOLS} \
>
> ${PYTHON_PKGNAMEPREFIX}wheel>0:devel/py-wheel@${PY_FLAVOR}

I disagree. Upstream doesn't ship pyproject.toml.