git: d75d8df216d8 - main - net/samba422: Do not set WRKSRC needlessly and explain PLIST assignment
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 10 Dec 2025 22:31:00 UTC
The branch main has been updated by 0mp:
URL: https://cgit.FreeBSD.org/ports/commit/?id=d75d8df216d89413bab4a9eeebb299a75ab31907
commit d75d8df216d89413bab4a9eeebb299a75ab31907
Author: Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2025-12-10 22:26:48 +0000
Commit: Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2025-12-10 22:29:22 +0000
net/samba422: Do not set WRKSRC needlessly and explain PLIST assignment
We need to set PLIST explicitly here because we use
<OPTION>_VARS=PLIST+=pkg-plist.<option>
to append more files to PLIST. Everything works as expected.
---
net/samba422/Makefile | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/samba422/Makefile b/net/samba422/Makefile
index 73f8deae4faa..589b28e18d07 100644
--- a/net/samba422/Makefile
+++ b/net/samba422/Makefile
@@ -45,9 +45,6 @@ SAMBA4_PORTNAME= ${SAMBA4_BASENAME}4
SAMBA4_VERSION= 4.22.6
SAMBA4_DISTNAME= ${SAMBA4_BASENAME}-${SAMBA4_VERSION:S|.p|pre|:S|.r|rc|:S|.t|tp|:S|.a|alpha|}
-WRKSRC?= ${WRKDIR}/${DISTNAME}
-PLIST?= ${PKGDIR}/pkg-plist
-
CPE_VENDOR= samba
CPE_PRODUCT= samba
# Directories
@@ -110,6 +107,10 @@ SUB_LIST= PKGCONFIGDIR=${PKGCONFIGDIR_REL}
##############################################################################
OPTIONS_SUB= yes
+# PLIST must be defined here explicitly as we append to PLIST later on to
+# handle extra pkg-plist files like pkg-plist.python.
+PLIST?= ${PKGDIR}/pkg-plist
+##############################################################################
OPTIONS_DEFINE= AD_DC ADS CLUSTER CUPS DOCS FAM LDAP GPGME \
MANPAGES PROFILE PYTHON3 QUOTAS \
SYSLOG UTMP