Re: git: 4717c9513cac - main - devel/lua-posix: Use lua51+

On Tue, Apr 8, 2025 at 6:06 AM Christos Margiolis <christos@freebsd.org>
wrote:

> The branch main has been updated by christos:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=4717c9513cac82ea33d9939f218fd9b16e042883
>
> commit 4717c9513cac82ea33d9939f218fd9b16e042883
> Author:     Christos Margiolis <christos@FreeBSD.org>
> AuthorDate: 2025-04-07 22:06:16 +0000
> Commit:     Christos Margiolis <christos@FreeBSD.org>
> CommitDate: 2025-04-07 22:06:16 +0000
>
>     devel/lua-posix: Use lua51+
>
>     editors/neovim has Lua 5.1 built into it, so plugins that require
>     lua-posix don't work without lua51-posix.
>
>     Sponsored by:   The FreeBSD Foundation
>     Reviewed by:    diizzy
>     Differential Revision:  https://reviews.freebsd.org/D49490


Please revert this commit for the following reasons.

1.
It is incorrect, at least incomplete.
Please check the git log before submitting the change.

Here is the reason it is set to lua:52+.
posix uses Lua built-in bit32 which is available since Lua 5.2.
See
https://github.com/freebsd/freebsd-ports/commit/5102d79f7137a81c593dd48505b8d3176b09c0aa

2.
It is not approved.
Please note that Bugzilla is the only bug reporting system.


> ---
>  devel/lua-posix/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devel/lua-posix/Makefile b/devel/lua-posix/Makefile
> index 7bb1e5563682..5bf924aa2930 100644
> --- a/devel/lua-posix/Makefile
> +++ b/devel/lua-posix/Makefile
> @@ -13,7 +13,7 @@ LICENSE_FILE= ${WRKSRC}/LICENSE
>
>  RUN_DEPENDS=
>  ${LUA_PKGNAMEPREFIX}stdlib-normalize>=0:devel/lua-stdlib-normalize@
> ${LUA_FLAVOR}
>
> -USES=          lua:52+,module shebangfix
> +USES=          lua:51+,module shebangfix
>
>  USE_GITHUB=    yes
>  GH_ACCOUNT=    luaposix
>
>