From nobody Tue Apr 01 18:20:54 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZRxBv1wynz5rvl9; Tue, 01 Apr 2025 18:20:55 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZRxBt6Qrjz3hTG; Tue, 01 Apr 2025 18:20:54 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743531654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u+OfjXV2+gXPNR8TufiP9BzbbQtV9l9cC9UQjcfR7oA=; b=Y7hm7m6pOBHbnwnkl1QzCcsCi0WPgl0YF+C9xzJZ7JQ0HE3UQ2xaE2J04Z8AY6niLn/X03 6/jADC/0NQiE/vFUz2zCMK4o3UgfHQxCYmxRyeWxDopjnaQn5ME1G81ZLpwXvB89dbYtIY 8wwfp24ArR1h7gFgSEaw0PL5qUn3KTa2ZExGDRC+djxt5o/mLev1Fe9Crze3IxwK0+g0EZ /pb3LU1xUXHurmRLGhcAklGysVlgwWbFWkkY1QqlnS9fTCf7Ceb0oBLym5AuV6FyPdhEUJ clqkL63B0GMcd2ClBpjxRHIElSfMZnYR2J/XjsSGljfD9BD45Jtt70ApVB2R4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743531654; a=rsa-sha256; cv=none; b=Do7SORJtbzZlTJH5JwuLaqvYR49HF639qRyxMClInn+FRaVlJCvETf/3hTxl2bNt9M1hXh YLWamYWhVhvtkE8+ZoqYcGTLLeWRws5hsgSfgUkw4hZ/JFiqKDDbxllZfcuTiREpnSqpV6 ghJSF/s38ZVn4zMNJmV8eDWnUPzZPBX70K1Oy9OTUQjPC7o1O4Ez8G4340GHosj3ZSOZt3 UIyLkqXYAgP3Jw7+i9wFmHQTYrpLIPfPBKpX9pKB1P/rH4I6VPTV2vNdjwpyxphDy73Pug ORNT6AoV/8E8sIVsXeh2ZycJd53ziUlxjv29KVNFtgB8IJk+oU+K5KIcd6ZUAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743531654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u+OfjXV2+gXPNR8TufiP9BzbbQtV9l9cC9UQjcfR7oA=; b=P69v24NpM8hYh5b+sI+lTBP9Cbbt/3/ygTUp+Qd5m8y7a9ndDz5Mi4qqDQ8/KiCcduYXFD v6sdZRtCSjytHiCgHi4B6G+NBB4DPrZHvUtTzaX2a+mqytVsk+DAQn89FUWNG5Vcd4GrD7 hfCOEYGdOvkFqjlW5hEfonRLnias+bHEG9gRyKWE38rCqhPKeESdj92j6LzSW5wluAYCAU SmLvCbozxmT00xfrpnXDjFRKt9Pbq4UkV5xzKrcPDXAVHWRns5zqmNJpuCYjvb4aAd6l3P TYqTiL9jr1P1L5qo8hy/5QWMHJVmwPQ9n6OFG5FELodwmLlgW6SJuci9wax9jg== Received: from [192.168.1.16] (217-209-194-237-no600.tbcn.telia.com [217.209.194.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: diizzy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZRxBt2Bc6zJ9W; Tue, 01 Apr 2025 18:20:54 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Content-Type: multipart/alternative; boundary="------------K0Wn5BtNO0F2YAKj5hHSJBCw" Message-ID: Date: Tue, 1 Apr 2025 20:20:54 +0200 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: git: 65f14e18b685 - main - graphics/agg26: new port for 2.6 To: Dirk Meyer , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202504011725.531HPpAL013008@gitrepo.freebsd.org> Content-Language: en-US From: Daniel Engberg In-Reply-To: <202504011725.531HPpAL013008@gitrepo.freebsd.org> This is a multi-part message in MIME format. --------------K0Wn5BtNO0F2YAKj5hHSJBCw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-04-01 19:25, Dirk Meyer wrote: > The branch main has been updated by dinoex: > > URL:https://cgit.FreeBSD.org/ports/commit/?id=65f14e18b68589889353a671be33b2aabf2f0c4d > > commit 65f14e18b68589889353a671be33b2aabf2f0c4d > Author: Dirk Meyer > AuthorDate: 2025-04-01 17:23:23 +0000 > Commit: Dirk Meyer > CommitDate: 2025-04-01 17:23:23 +0000 > > graphics/agg26: new port for 2.6 > > PR: 285652 > update MASTER_SITES > --- > graphics/Makefile | 1 + > graphics/agg26/Makefile | 36 +++++ > graphics/agg26/distinfo | 3 + > .../patch-font_freetype__agg_font_freetype.cpp | 11 ++ > .../files/patch-include__agg_renderer_outline_aa.h | 11 ++ > graphics/agg26/pkg-descr | 14 ++ > graphics/agg26/pkg-plist | 160 +++++++++++++++++++++ > 7 files changed, 236 insertions(+) > > diff --git a/graphics/Makefile b/graphics/Makefile > index 2632e2783791..97f4cfac7650 100644 > --- a/graphics/Makefile > +++ b/graphics/Makefile > @@ -46,6 +46,7 @@ > SUBDIR += acidwarp-sdl > SUBDIR += aeskulap > SUBDIR += agg > + SUBDIR += agg26 > SUBDIR += airsaned > SUBDIR += akira > SUBDIR += alembic > diff --git a/graphics/agg26/Makefile b/graphics/agg26/Makefile > new file mode 100644 > index 000000000000..1279a51d344f > --- /dev/null > +++ b/graphics/agg26/Makefile > @@ -0,0 +1,36 @@ > +PORTNAME= agg > +PORTVERSION= 2.6 > +PORTREVISION= 0 > +CATEGORIES= graphics > + > +MAINTAINER= dinoex@FreeBSD.org > +COMMENT= High Quality Rendering Engine for C++ > +WWW= https://github.com/ghaerr/agg-2.6 > + > +LICENSE= GPLv2+ > +LICENSE_FILE= ${WRKSRC}/copying > + > +LIB_DEPENDS= libfreetype.so:print/freetype2 > ... Hi, Defined version is misleading, it's been at 2.6 since this commit https://github.com/ghaerr/agg-2.6/commit/3dc16133aa64465040c4bdbf3562824a12214744 in 2018. Please review "Example 15. More Complete Use of |USE_GITHUB" |in Porters Handbook regarding version policies and also usage of variables. PKGNAMESUFFIX2 resolves to nothing The framework also warns you that you're using incorrect VARIABLES (WRKSRC). Is there any purpose adding this to the tree given that it depends on SDL1? Best regards, Daniel --------------K0Wn5BtNO0F2YAKj5hHSJBCw Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 2025-04-01 19:25, Dirk Meyer wrote:
The branch main has been updated by dinoex:

URL: https://cgit.FreeBSD.org/ports/commit/?id=65f14e18b68589889353a671be33b2aabf2f0c4d

commit 65f14e18b68589889353a671be33b2aabf2f0c4d
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2025-04-01 17:23:23 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2025-04-01 17:23:23 +0000

    graphics/agg26: new port for 2.6
    
    PR: 285652
    update MASTER_SITES
---
 graphics/Makefile                                  |   1 +
 graphics/agg26/Makefile                            |  36 +++++
 graphics/agg26/distinfo                            |   3 +
 .../patch-font_freetype__agg_font_freetype.cpp     |  11 ++
 .../files/patch-include__agg_renderer_outline_aa.h |  11 ++
 graphics/agg26/pkg-descr                           |  14 ++
 graphics/agg26/pkg-plist                           | 160 +++++++++++++++++++++
 7 files changed, 236 insertions(+)

diff --git a/graphics/Makefile b/graphics/Makefile
index 2632e2783791..97f4cfac7650 100644
--- a/graphics/Makefile
+++ b/graphics/Makefile
@@ -46,6 +46,7 @@
     SUBDIR += acidwarp-sdl
     SUBDIR += aeskulap
     SUBDIR += agg
+    SUBDIR += agg26
     SUBDIR += airsaned
     SUBDIR += akira
     SUBDIR += alembic
diff --git a/graphics/agg26/Makefile b/graphics/agg26/Makefile
new file mode 100644
index 000000000000..1279a51d344f
--- /dev/null
+++ b/graphics/agg26/Makefile
@@ -0,0 +1,36 @@
+PORTNAME=	agg
+PORTVERSION=	2.6
+PORTREVISION=	0
+CATEGORIES=	graphics
+
+MAINTAINER=	dinoex@FreeBSD.org
+COMMENT=	High Quality Rendering Engine for C++
+WWW=		https://github.com/ghaerr/agg-2.6
+
+LICENSE=	GPLv2+
+LICENSE_FILE=	${WRKSRC}/copying
+
+LIB_DEPENDS=	libfreetype.so:print/freetype2
...

Hi,

Defined version is misleading, it's been at 2.6 since this commit https://github.com/ghaerr/agg-2.6/commit/3dc16133aa64465040c4bdbf3562824a12214744 in 2018.

Please review "Example 15. More Complete Use of USE_GITHUB" in Porters Handbook regarding version policies and also usage of variables.

PKGNAMESUFFIX2 resolves to nothing

The framework also warns you that you're using incorrect VARIABLES (WRKSRC).

Is there any purpose adding this to the tree given that it depends on SDL1?

Best regards,

Daniel

--------------K0Wn5BtNO0F2YAKj5hHSJBCw--