Re: git: 65f14e18b685 - main - graphics/agg26: new port for 2.6

On 2025-04-01 19:25, Dirk Meyer wrote:
> The branch main has been updated by dinoex:
>
> URL:https://cgit.FreeBSD.org/ports/commit/?id=65f14e18b68589889353a671be33b2aabf2f0c4d
>
> commit 65f14e18b68589889353a671be33b2aabf2f0c4d
> Author:     Dirk Meyer<dinoex@FreeBSD.org>
> AuthorDate: 2025-04-01 17:23:23 +0000
> Commit:     Dirk Meyer<dinoex@FreeBSD.org>
> CommitDate: 2025-04-01 17:23:23 +0000
>
>      graphics/agg26: new port for 2.6
>      
>      PR: 285652
>      update MASTER_SITES
> ---
>   graphics/Makefile                                  |   1 +
>   graphics/agg26/Makefile                            |  36 +++++
>   graphics/agg26/distinfo                            |   3 +
>   .../patch-font_freetype__agg_font_freetype.cpp     |  11 ++
>   .../files/patch-include__agg_renderer_outline_aa.h |  11 ++
>   graphics/agg26/pkg-descr                           |  14 ++
>   graphics/agg26/pkg-plist                           | 160 +++++++++++++++++++++
>   7 files changed, 236 insertions(+)
>
> diff --git a/graphics/Makefile b/graphics/Makefile
> index 2632e2783791..97f4cfac7650 100644
> --- a/graphics/Makefile
> +++ b/graphics/Makefile
> @@ -46,6 +46,7 @@
>       SUBDIR += acidwarp-sdl
>       SUBDIR += aeskulap
>       SUBDIR += agg
> +    SUBDIR += agg26
>       SUBDIR += airsaned
>       SUBDIR += akira
>       SUBDIR += alembic
> diff --git a/graphics/agg26/Makefile b/graphics/agg26/Makefile
> new file mode 100644
> index 000000000000..1279a51d344f
> --- /dev/null
> +++ b/graphics/agg26/Makefile
> @@ -0,0 +1,36 @@
> +PORTNAME=	agg
> +PORTVERSION=	2.6
> +PORTREVISION=	0
> +CATEGORIES=	graphics
> +
> +MAINTAINER=	dinoex@FreeBSD.org
> +COMMENT=	High Quality Rendering Engine for C++
> +WWW=		https://github.com/ghaerr/agg-2.6
> +
> +LICENSE=	GPLv2+
> +LICENSE_FILE=	${WRKSRC}/copying
> +
> +LIB_DEPENDS=	libfreetype.so:print/freetype2
> ...

Hi,

Defined version is misleading, it's been at 2.6 since this commit 
https://github.com/ghaerr/agg-2.6/commit/3dc16133aa64465040c4bdbf3562824a12214744 
in 2018.

Please review "Example 15. More Complete Use of |USE_GITHUB" |in Porters 
Handbook regarding version policies and also usage of variables.

PKGNAMESUFFIX2 resolves to nothing

The framework also warns you that you're using incorrect VARIABLES (WRKSRC).

Is there any purpose adding this to the tree given that it depends on SDL1?

Best regards,

Daniel