Re: git: 0df6c8368918 - main - devel/libcjson: Update to 1.7.18

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Sun, 19 May 2024 18:40:39 UTC 
On 2024-05-19T19:23:46.000+02:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote:
>  The branch main has been updated by sunpoet:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=0df6c8368918d6d1905b141e93cf0c55cf9803f8
> 
> commit 0df6c8368918d6d1905b141e93cf0c55cf9803f8
> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> AuthorDate: 2024-05-19 16:15:08 +0000
> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> CommitDate: 2024-05-19 17:15:06 +0000
> 
>     devel/libcjson: Update to 1.7.18
>     
>     - Use USES=pathfix to fix .pc installation
>     
>     Changes:        https://github.com/DaveGamble/cJSON/releases
>     Security:       CVE-2024-31755
> ---
>  devel/libcjson/Makefile | 6 +++---
>  devel/libcjson/distinfo | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/devel/libcjson/Makefile b/devel/libcjson/Makefile
> index 5a0e276ca30d..2f5f4624cb1b 100644
> --- a/devel/libcjson/Makefile
> +++ b/devel/libcjson/Makefile
> @@ -1,5 +1,5 @@
>  PORTNAME=	libcjson
> -PORTVERSION=	1.7.17
> +PORTVERSION=	1.7.18
>  DISTVERSIONPREFIX=	v
>  CATEGORIES=	devel
>  
> @@ -10,10 +10,10 @@ WWW=		https://github.com/DaveGamble/cJSON
>  LICENSE=	MIT
>  LICENSE_FILE=	${WRKSRC}/LICENSE
>  
> -USES=		cmake:testing compiler:c11
> +USES=		cmake:testing compiler:c11 pathfix
>  
>  CMAKE_OFF=	CJSON_OVERRIDE_BUILD_SHARED_LIBS ENABLE_CJSON_TEST ENABLE_CUSTOM_COMPILER_FLAGS ENABLE_HIDDEN_SYMBOLS ENABLE_SAFE_STACK ENABLE_SANITIZERS
> -CMAKE_ON=	BUILD_SHARED_AND_STATIC_LIBS BUILD_SHARED_LIBS CJSON_BUILD_SHARED_LIBS ENABLE_CJSON_UTILS ENABLE_LOCALES ENABLE_PUBLIC_SYMBOLS ENABLE_TARGET_EXPORT
> +CMAKE_ON=	BUILD_SHARED_AND_STATIC_LIBS BUILD_SHARED_LIBS CJSON_BUILD_SHARED_LIBS ENABLE_CJSON_UNINSTALL ENABLE_CJSON_UTILS ENABLE_CJSON_VERSION_SO ENABLE_LOCALES ENABLE_PUBLIC_SYMBOLS ENABLE_TARGET_EXPORT
>  CMAKE_TESTING_ON=	ENABLE_CJSON_TEST ENABLE_SAFE_STACK
>  USE_CSTD=	c11
>  
> diff --git a/devel/libcjson/distinfo b/devel/libcjson/distinfo
> index 27dc7e7d7dd1..0842dd750e7a 100644
> --- a/devel/libcjson/distinfo
> +++ b/devel/libcjson/distinfo
> @@ -1,3 +1,3 @@
> -TIMESTAMP = 1708448902
> -SHA256 (DaveGamble-cJSON-v1.7.17_GH0.tar.gz) = c91d1eeb7175c50d49f6ba2a25e69b46bd05cffb798382c19bfb202e467ec51c
> -SIZE (DaveGamble-cJSON-v1.7.17_GH0.tar.gz) = 353748
> +TIMESTAMP = 1715842516
> +SHA256 (DaveGamble-cJSON-v1.7.18_GH0.tar.gz) = 3aa806844a03442c00769b83e99970be70fbef03735ff898f4811dd03b9f5ee5
+SIZE (DaveGamble-cJSON-v1.7.18_GH0.tar.gz) = 354726

Hi,

Any specific reason as to why we're hardcoding c11 when upstream targets c89?
https://github.com/DaveGamble/cJSON/blob/v1.7.18/CMakeLists.txt#L22
See also https://github.com/DaveGamble/cJSON/pull/836

Best regards,
Daniel