Re: git: 4251c2a2ddb5 - main - net/torsocks: Fix USE_LDCONFIG

From: Baptiste Daroussin <bapt_at_nours.eu>
Date: Sun, 05 May 2024 10:26:49 UTC
Le 5 mai 2024 10:30:52 GMT+02:00, Yuri Victorovich <yuri@FreeBSD.org> a écrit :
>The branch main has been updated by yuri:
>
>URL: https://cgit.FreeBSD.org/ports/commit/?id=4251c2a2ddb5156ca44de4836cfa08100df2c33d
>
>commit 4251c2a2ddb5156ca44de4836cfa08100df2c33d
>Author:     Yuri Victorovich <yuri@FreeBSD.org>
>AuthorDate: 2024-05-05 08:29:45 +0000
>Commit:     Yuri Victorovich <yuri@FreeBSD.org>
>CommitDate: 2024-05-05 08:29:45 +0000
>
>    net/torsocks: Fix USE_LDCONFIG
>---
> net/torsocks/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/torsocks/Makefile b/net/torsocks/Makefile
>index 377e1dc5a811..4e878fc2ead1 100644
>--- a/net/torsocks/Makefile
>+++ b/net/torsocks/Makefile
>@@ -1,6 +1,6 @@
> PORTNAME=	torsocks
> DISTVERSION=	2.3.0
>-PORTREVISION=	2
>+PORTREVISION=	3
> CATEGORIES=	net security
> MASTER_SITES=	https://people.torproject.org/~dgoulet/${PORTNAME}/
> 
>@@ -15,7 +15,7 @@ USES=		alias gmake libtool tar:xz
> GNU_CONFIGURE=	yes
> GNU_CONFIGURE_MANPREFIX=	${PREFIX}/share
> INSTALL_TARGET=	install-strip
>-USE_LDCONFIG=	yes
>+USE_LDCONFIG=	${PREFIX}/lib/torsocks
> 
> SUB_FILES=	pkg-message
> 

Why this is wrong and USE_LDCONFIG should not be used at all, it is meant to be used via LD_PRELOAD

Bapt