Re: git: 1a2f57d29bcc - main - multimedia/libzen: Adjust package version

On 2024-03-31T21:31:09.000+02:00, Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
>  On Fri, Mar 29, 2024 at 6:26 AM Daniel Engberg <diizzy@freebsd.org> wrote:
> 
> 
> >    The branch main has been updated by diizzy:
> > 
> >  URL:
> >  https://cgit.FreeBSD.org/ports/commit/?id=1a2f57d29bcc8c5cd27973998909c5e519f90457
> > 
> >  commit 1a2f57d29bcc8c5cd27973998909c5e519f90457
> >  Author:     Daniel Engberg <diizzy@FreeBSD.org>
> >  AuthorDate: 2024-03-28 22:06:52 +0000
> >  Commit:     Daniel Engberg <diizzy@FreeBSD.org>
> >  CommitDate: 2024-03-28 22:25:58 +0000
> > 
> >      multimedia/libzen: Adjust package version
> > 
> >      Upstream bundles libzen (named ZenLib upstream) both separately and
> >      as a all-in-one bundle with mediainfo (multimedia/mediainfo) releases.
> >      Libzen do not share the same versioning schema as mediainfo and hence
> >      shouldn't use it. Upstream bundles snapshots of libzen however only
> >      release versions are tracked (current version is defined as 0.4.41).
> >      Current release bundle archive ships the latest commit of libzen
> >      available and following Porters Handbook append commit date to
> >      release version. Worth noting is that separate version provided
> >      on upstream's download page corresponds to the tagged version on
> >      GitHub.
> > 
> >      Sources:
> >      https://github.com/MediaArea/ZenLib
> >      https://mediaarea.net/en/MediaInfo/Download/Source
> > 
> >      PR:             276754
> >      Approved by:    portmgr (maintainer timeout, 1+ month)
> > 
>  
> I don't see any patch files for this commit on Bugzilla. The only one is
> incorrect and outdated.

I replied to you the same day and as explained and linked to in the PR upstream doesn't use your claimed versioning and it's neither a "private" library (which doesn't matter) which you didn't take any action on for over a month.

> 
> ---
> 
> >     multimedia/libzen/Makefile | 10 ++++++----
> >   1 file changed, 6 insertions(+), 4 deletions(-)
> > 
> >  diff --git a/multimedia/libzen/Makefile b/multimedia/libzen/Makefile
> >  index 365fa2ba5d98..60cb49bdc993 100644
> >  --- a/multimedia/libzen/Makefile
> >  +++ b/multimedia/libzen/Makefile
> >  @@ -1,10 +1,11 @@
> >   PORTNAME=      libzen
> >  -PORTVERSION=   24.01.1
> >  -PORTEPOCH=     1
> >  +DISTVERSION=   0.4.41.20240118
> >  +PORTREVISION=  1
> > 
>  
> FYI, since you bumped PORTEPOCH, you don't need to bump PORTREVISION.
Noted, thanks
> 
> 
> 
> >    +PORTEPOCH=     2
> >   CATEGORIES=    multimedia
> >  -MASTER_SITES=
> >  https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/ \
> >  +MASTER_SITES=
> >  https://mediaarea.net/download/binary/mediainfo/${UPSTREAM_BUNDLE_VERSION}/
> >  \
> >                  LOCAL/sunpoet
> >  -DISTNAME=      MediaInfo_CLI_${PORTVERSION}_GNU_FromSource
> >  +DISTNAME=      MediaInfo_CLI_${UPSTREAM_BUNDLE_VERSION}_GNU_FromSource
> > 
> >   MAINTAINER=    sunpoet@FreeBSD.org
> >   COMMENT=       ZenLib used by MediaInfo and its library
> >  @@ -19,6 +20,7 @@ USES=         compiler:c++11-lang dos2unix libtool
> >  pathfix tar:xz
> >   CONFIGURE_ARGS=        --enable-shared --enable-static
> >   GNU_CONFIGURE= yes
> >   INSTALL_TARGET=        install-strip
> >  +UPSTREAM_BUNDLE_VERSION=       24.01.1
> >   USE_LDCONFIG=  yes
> > 
> >   WRKSRC=
> >  ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/ZenLib/Project/GNU/Library
> > 
> 
 
Best regards,
Daniel