From nobody Sat Mar 23 16:12:07 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V243f4GdBz5FKnv for ; Sat, 23 Mar 2024 16:12:46 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V243f2BClz4mhX for ; Sat, 23 Mar 2024 16:12:46 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711210366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lJxxelk+Jrvkw6VXE9gYtvb0kUY084PwE/2AUGrntPE=; b=S8VFmmybiOpdGkhi1/UfjCRVsKdbogBr+t1jY5ns3fj6/hiTEGXBNAdIoEF0k3wje+jwYe SxNblIKLqymAGgAmxKggwx7S4UzxYGHeqEwXvJsHtBVPekiYIqmHAyLFbyxTwhLd1yH0l9 X09+znmnCIu5yqdu+3ffHTDEOjNfftFjVe3ZsDgmxWufsuojuxPwAH8uMr/mjcQjMDAv1B Ltp4dD3ckpN7pzrDVkxtvR+3sM5ea2s86bhhHSZ6+NsislUjB8RFfScrkdvhH3GBnvUAmR RdKLuDSFqpwN932uZc+8p0Dr9DBf0wldMyHx/utgOJ41hduCkww8UpkzUqlZdg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711210366; a=rsa-sha256; cv=none; b=DOWP3LxaC+pKrkbEhdvIx0oDMmyuiD0J3/JgnjVAQ+K6tul0G34ogdI0htZjQ9lTvG0MHm ViA1Qy5+sbeWeL5uK21tWj3Ub+XhOlRdFhb4Uz1c3cyjCtvbaBu7y+xlHNA3SgrPxMGiHL LkXYns9PtGicOkjQX2LHqzsNUZPEnp61CYU+j32PfmMOVCZctxn+8EyIcqK7ojDqGLYvr1 6KRWc79V/nWZjn7plySbr/cH9YEsHkKNPBHBHtuTqxAGHmOmt1TV9sK2SiEbKK0ikdr6o6 QyG2J02dtIcqZ/hlYIGMyqSZKUZ/coW2c3LB/w0UCkzsIjjj1rMl1Xk7ZcKJfg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711210366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lJxxelk+Jrvkw6VXE9gYtvb0kUY084PwE/2AUGrntPE=; b=wmgaW5ZDbirrZzC44HnxqEYcWW0HWBGB6kb9dH5dmSX9/VSDGuI7GQpuFeLFQzixq1rh6o 0L5Rx/gpcfF1yu5BkZZnBwl/xq041HZUbtLhWRw2MjHz7psuEwQSdCrYtuQyrXKJp3UDYE IwiNBDEn4pyQ/lPF2GNvWQSKyQtpqvgQkIYWyhvCSzSzYqx0JrwjQd4sn7dTBesK3JoPC6 XyACQLkan1Gh2/ZgkXuHWaR6w2Lz6OaTmcs/A81suEIsFFBp0KCmH2PsO4SZIzdLeJt/d/ 1Lfc7yv1V5zm6v0F285xcZgmGjnVEXmeWZTEwWzPIJ0XjlumTsW8vsgWiw3t3w== Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V243f12ZrzYbZ for ; Sat, 23 Mar 2024 16:12:46 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a468004667aso426169766b.2 for ; Sat, 23 Mar 2024 09:12:46 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXMJH6iDTsoHpL2MMQG0/LXylkF/YMYpsARJCu0ehwyejydzksx9c0nXAaVQ03zo8zBjuu9oDULafpUWXR06MYI6amyzzvuLuB+lNprIoomHIw= X-Gm-Message-State: AOJu0Yw2EDw9Q0KglB5WwRVohihQpjP/k7lmBfHd0Zup5uacnNQwDQEm bkicLSczbI4rNJ8s5hraPfVXMMEiYFFNMnlJPkLFYxMLPBEO1MSp2SxwPPCuB7UYeqWSqRdttB1 ow00ZvOpuYEJQXSHxGsuxO1kCWySVCVYX9QD04w== X-Google-Smtp-Source: AGHT+IFTcXqoLYL1VjXtFRPi9wWJ2sEdGIi07oS+mRD5yzuHN+6Fa0vn+i3GvnaDJQPqixIHiRujJ0mVWjkYZj6moGE= X-Received: by 2002:a17:906:c106:b0:a47:4836:6609 with SMTP id do6-20020a170906c10600b00a4748366609mr1023340ejc.60.1711210364757; Sat, 23 Mar 2024 09:12:44 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <2567403.0dHE6SNnxz@angua.firefly> In-Reply-To: <2567403.0dHE6SNnxz@angua.firefly> From: Po-Chuan Hsieh Date: Sun, 24 Mar 2024 00:12:07 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" To: "Tobias C. Berner" , Gleb Popov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000ed8b2306145635c9" --000000000000ed8b2306145635c9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 23, 2024 at 11:38=E2=80=AFPM Tobias C. Berner wrote: > Am Samstag, 23. M=C3=A4rz 2024, 15:14:01 CET schrieb Gleb Popov: > > On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh > wrote: > > > The branch main has been updated by sunpoet: > > > > > > URL: > > > > https://cgit.FreeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d803= a2 > > > b1b8f5f98 > > > > > > commit 28472e9722d808739a4d690f6d803a2b1b8f5f98 > > > Author: Po-Chuan Hsieh > > > AuthorDate: 2024-03-23 14:01:07 +0000 > > > Commit: Po-Chuan Hsieh > > > CommitDate: 2024-03-23 14:01:07 +0000 > > > > > > Revert "x11-fonts/noto*: Restructure and update" > > > > > > This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8. > > > > It is good manners to explain the reason for reverting when doing it. > > Even better to first talk to the original committer and ask him to the > > revert. > > Moin moin > > I completely agree. Given that there has been a phabricator review open > for > two months, with you, sunpoet@ as reviewer, this is looking like poor > judgement on your side. > > As arrowd@ points out, you should have commented on the reverted commit > first, > and elaborate your reasoning for a revert. > > Simply reverting the work of others may lead to fewer contributions. > Please > take this into consideration in the future. > > > mfg Tobias Hello, I'm sorry that I did not put enough information in this reverting commit because I need it to be done ASAP so that less users are affected. There are several reasons I reverted it by myself instead of requesting tijl@ to do so. First, I do not use phab review therefore I did not really review the patch which means it is committed without maintainer approval. Second, I already have my own work for noto updates which is totally in different direction with tijl@'s work. I cannot simply rebase my work onto it. Third, The problem mentioned in the PR is also handled in my own work. Regards, sunpoet --000000000000ed8b2306145635c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Mar 23, 2024 at 11:38=E2=80=AFPM = Tobias C. Berner <tcberner@gmail.com> wrote:
Am Samstag, 23. M=C3=A4rz 20= 24, 15:14:01 CET schrieb Gleb Popov:
> On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh <sunpoet@freebsd.org> w= rote:
> > The branch main has been updated by sunpoet:
> >
> > URL:
> > https://cgit.Fr= eeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d803a2
> > b1b8f5f98
> >
> > commit 28472e9722d808739a4d690f6d803a2b1b8f5f98
> > Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org= >
> > AuthorDate: 2024-03-23 14:01:07 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org= >
> > CommitDate: 2024-03-23 14:01:07 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0Revert "x11-fonts/noto*: Restructure and = update"
> >=C2=A0 =C2=A0 =C2=A0
> >=C2=A0 =C2=A0 =C2=A0This reverts commit 3b128ff9f74b28ada2f475f0b8= 16480b1550e5b8.
>
> It is good manners to explain the reason for reverting when doing it.<= br> > Even better to first talk to the original committer and ask him to the=
> revert.

Moin moin

I completely agree. Given that there has been a phabricator review open for=
two months, with you, sunpoet@ as reviewer, this is looking like poor
judgement on your side.

As arrowd@ points out, you should have commented on the reverted commit fir= st,
and elaborate your reasoning for a revert.

Simply reverting the work of others may lead to fewer contributions. Please=
take this into consideration in the future.


mfg Tobias

Hello,

= I'm sorry that I did not put enough information in this reverting commi= t because I need=C2=A0it to be done ASAP so that less users are affected.
There are several reasons I reverted it by=C2=A0myself instead of = requesting=C2=A0tijl@ to do=C2=A0so.
First, I do not use phab rev= iew therefore I did not really review the patch which means it is committed= without maintainer approval.
Second, I already have my own work = for noto updates which is totally in different=C2=A0direction with tijl@= 9;s work. I cannot simply rebase my work onto it.
Third, The prob= lem mentioned in the PR is also handled in my own work.

Regards,
sunpoet
--000000000000ed8b2306145635c9--