Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG

From: Mathieu Arnold <mat_at_freebsd.org>
Date: Sun, 03 Mar 2024 08:56:38 UTC 
On Sun, Mar 03, 2024 at 09:55:12AM +0300, Gleb Popov wrote:
> On Sat, Mar 2, 2024 at 9:36 PM Thomas Zander <riggs@freebsd.org> wrote:
> >
> > The branch main has been updated by riggs:
> >
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=a995b8b0ab54b250167531dafc38fc1342558446
> >
> > commit a995b8b0ab54b250167531dafc38fc1342558446
> > Author:     Thomas Zander <riggs@FreeBSD.org>
> > AuthorDate: 2024-03-02 10:26:32 +0000
> > Commit:     Thomas Zander <riggs@FreeBSD.org>
> > CommitDate: 2024-03-02 18:36:02 +0000
> >
> >     multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG
> >
> >     Details:
> >     This is a revert of c1e0f931e3ddecb86d83ffc14cb8b05a38922cdd plus
> >     removing the DEBUG OPTION from mencoder as well, following the trend to
> >     phase out DEBUG as an option.
> 
> I wouldn't say that there is a trend to remove the DEBUG option, but
> this specific change you made does make sense.

There is no trend, it's a rule, debug must be handled with WITH_DEBUG
knob, and not via an option.
If there is an option that enable some sort of debugging or verbose
thing but that is not supposed to add debugging symbols, then it should
not be called DEBUG.

-- 
Mathieu Arnold