Re: git: 4a72fdf13706 - main - misc/pytorch: fix build on arm64

Reply: Piotr Kubaj : "Re: git: 4a72fdf13706 - main - misc/pytorch: fix build on arm64"
In reply to: Piotr Kubaj : "git: 4a72fdf13706 - main - misc/pytorch: fix build on arm64"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Tue, 09 Jul 2024 10:35:23 UTC

On Tue, Jul 09, 2024 at 10:04:52AM +0000, Piotr Kubaj wrote:
> commit 4a72fdf137062c477b25bf1602d57745b569a352
> 
>     misc/pytorch: fix build on arm64
> ...
> + # Enable conditional FP16 arithmetic intrinsics
> +-if(CPU_AARCH64 AND LINUX)
> ++if(CPU_AARCH64 AND CMAKE_SYSTEM_NAME MATCHES "FreeBSD")

Looks like in its current form the patch isn't quite upstreamable.
Did you try to raise this issue with developers to come up with
more generic solution?  Ad-hoc patches might fix some problem in
the moment but often become extra burden for ports' maintainers
with future updates.

./danfe