Re: git: 9f0ce98efea9 - main - irc/rbot: Moved man to share/man

On 1/31/2024 7:23 AM, Bryan Drewery wrote:
> On 1/31/2024 7:09 AM, Moin Rahman wrote:
>>
>>
>>> On Jan 31, 2024, at 3:51 PM, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>>>
>>> On 2024-01-29 11:54, Muhammad Moinur Rahman wrote:
>>>> The branch main has been updated by bofh:
>>>> URL: 
>>>> https://cgit.FreeBSD.org/ports/commit/?id=9f0ce98efea9ca39d4930569c7a072a9431793b2
>>>> commit 9f0ce98efea9ca39d4930569c7a072a9431793b2
>>>> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>>>> AuthorDate: 2024-01-29 18:03:32 +0000
>>>> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>>>> CommitDate: 2024-01-29 19:54:13 +0000
>>>>     irc/rbot: Moved man to share/man
>>>
>>> I think you should be testing these before committing. This one 
>>> doesn't use GNU configure.
>> What makes you think that my commits are not well tested?
>> This was when I committed:
>> https://pkg.bofh.network/data/132-default/2024-01-29_19h19m37s/logs/rbot-20160325_2,1.log
>>
>> This is now:
>> https://pkg.bofh.network/data/132-default/2024-01-31_16h01m20s/logs/rbot-20160325_2,1.log
>>
>> GNU_CONFIGURE_MANPREFIX has nothing to do with GNU_CONFIGURE itself 
>> and it is mainly passed
>> as a var to CONFIGURE_ARGS.
> 
> GNU_CONFIGURE_MANPREFIX absolutely only has to do with GNU_CONFIGURE. 
> Check bsd.port.mk.
> 
> ~/git/ports/main/irc/rbot # make -V CONFIGURE_ARGS
> --prefix=/usr/local
> ~/git/ports/main/irc/rbot # make -V __LATE_CONFIGURE_ARGS
> 
> 
> __LATE_CONFIGURE_ARGS only includes GNU_CONFIGURE_MANPREFIX if 
> `./configure --help` shows a mandir.
> 
> 
> Do you have output in either of those?

or CONFIGURE_CMD?
~/git/ports/main/irc/rbot # make -V CONFIGURE_CMD
./configure

The only way it could work for you is if that says "ruby setup.rb" which 
doesn't make sense since ruby.mk does not set that, it uses 
ruby-setup-configure target.

This is required to build for me:

diff --git irc/rbot/Makefile irc/rbot/Makefile
index 06984ff5bcfc..0d9304566079 100644
--- irc/rbot/Makefile
+++ irc/rbot/Makefile
@@ -25,8 +25,7 @@ LIB_DEPENDS=  libtokyocabinet.so:databases/tokyocabinet

  USES=          cpe ruby:setup

-GNU_CONFIGURE_MANPREFIX=       ${PREFIX}/share
-CONFIGURE_ARGS=        --prefix=${PREFIX}
+CONFIGURE_ARGS=        --prefix=${PREFIX} --mandir=${PREFIX}/share/man
  NO_ARCH=       yes

  USE_GITHUB=    yes

> 
> 
>>
>>> ===>   Building rbot-20160325_2,1
>>> pkg-static: Unable to access file 
>>> /wrkdirs/usr/ports/irc/rbot/work/stage/usr/local/share/man/rbot.xml.gz:No such file or directory
>>> *** Error code 1
>> This is not reproducible in latest ports tree at least.
>>
>>>
>>>>     Approved by:    portmgr (blanket)
>>>> ---
>>>> irc/rbot/Makefile  | 3 ++-
>>>> irc/rbot/pkg-plist | 2 +-
>>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>> diff --git a/irc/rbot/Makefile b/irc/rbot/Makefile
>>>> index aca35f99db58..06984ff5bcfc 100644
>>>> --- a/irc/rbot/Makefile
>>>> +++ b/irc/rbot/Makefile
>>>> @@ -1,6 +1,6 @@
>>>> PORTNAME= rbot
>>>> PORTVERSION= 20160325
>>>> -PORTREVISION= 1
>>>> +PORTREVISION= 2
>>>> PORTEPOCH= 1
>>>> CATEGORIES= irc ruby
>>>> @@ -25,6 +25,7 @@ LIB_DEPENDS= 
>>>> libtokyocabinet.so:databases/tokyocabinet
>>>> USES= cpe ruby:setup
>>>> +GNU_CONFIGURE_MANPREFIX= ${PREFIX}/share
>>>> CONFIGURE_ARGS= --prefix=${PREFIX}
>>>> NO_ARCH= yes
>>>> diff --git a/irc/rbot/pkg-plist b/irc/rbot/pkg-plist
>>>> index e411686f8392..dfe970ca87da 100644
>>>> --- a/irc/rbot/pkg-plist
>>>> +++ b/irc/rbot/pkg-plist
>>>> @@ -42,7 +42,7 @@ bin/rbotdb
>>>> %%RUBY_SITELIBDIR%%/rbot/registry/tc.rb
>>>> %%RUBY_SITELIBDIR%%/rbot/rfc2812.rb
>>>> %%RUBY_SITELIBDIR%%/rbot/timer.rb
>>>> -man/rbot.xml.gz
>>>> +share/man/rbot.xml.gz
>>>> %%DATADIR%%/contrib/plugins/stats.rb
>>>> %%DATADIR%%/contrib/plugins/vandale.rb
>>>> %%DATADIR%%/filters/rss.rb
>>
> 

-- 
Bryan Drewery