Re: git: e83f0a9c84ea - main - */*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER

From: Vladimir Druzenko <vvd_at_freebsd.org>
Date: Thu, 29 Feb 2024 10:16:10 UTC
29.02.2024 00:45, Michael Osipov пишет:
> On 2024-02-28 17:42, Vladimir Druzenko wrote:
>> 28.02.2024 18:54, Michael Osipov пишет:
>>> The branch main has been updated by michaelo:
>>>
>>> URL:https://cgit.FreeBSD.org/ports/commit/? 
>>> id=e83f0a9c84eabcc1307440925cc8d2d6b3dc4566
>>>
>>> commit e83f0a9c84eabcc1307440925cc8d2d6b3dc4566
>>> Author:     Michael Osipov<michaelo@FreeBSD.org>
>>> AuthorDate: 2024-02-12 14:31:19 +0000
>>> Commit:     Michael Osipov<michaelo@FreeBSD.org>
>>> CommitDate: 2024-02-28 15:53:37 +0000
>>>
>>>      */*: Properly depend on Subversion LTS or latest with 
>>> WITH_SUBVERSION_VER
>>>           When LTS version of Subversion is set in make.conf 
>>> (WITH_SUBVERSION_VER)
>>>      depending ports will still depend on latest version 
>>> (devel/subversion)
>>>      instead of LTS one (devel/subversion-lts). This will cause 
>>> dependency
>>>      conflicts when packages are distributed with Poudriere, namely 
>>> pkg(8)
>>>      will report them and fail to install.
>>>      Make all affected ports properly depend on the right port based 
>>> on the
>>>      value set in WITH_SUBVERSION_VER.
>>>           Approved by:    jrm (mentor), otis (mentor), lev 
>>> (maintainer timeout)
>>>      Differential Revision:https://reviews.freebsd.org/D43864
>>>
>>> … cut …
>>>
>>> -RUN_DEPENDS=    subversion>=0:devel/subversion
>>> +.if ${WITH_SUBVERSION_VER:U} == LTS
>>> +RUN_DEPENDS=    subversion-lts>0:devel/subversion-lts
>>> +.else
>>> +RUN_DEPENDS=    subversion>0:devel/subversion
>>> +.endif
>>
>> There is a similar issue with "git:devel/git@lite" vs "git:devel/git" 
>> for java/eclipse - if git installed, then build of java/eclipse fails.
>
> Please raise a PR for this. It should be at least tracked.

I created review:
https://reviews.freebsd.org/D44153

-- 
Best regards,
Vladimir Druzenko