Re: git: 36c21f98ff44 - main - benchmarks/ttcp: Update to 1.13

From: Mathieu Arnold <mat_at_freebsd.org>
Date: Wed, 28 Feb 2024 05:25:28 UTC
On Tue, Feb 27, 2024 at 10:57:36PM -0500, Jason E. Hale wrote:
> On Tue, Feb 27, 2024 at 5:14 PM Chris <i.h8.git@bsdforge.com> wrote:
> >
> > On 2024-02-27 00:44, Mathieu Arnold wrote:
> > > On Tue, Feb 27, 2024 at 12:25:35AM -0800, Chris wrote:
> > >> On 2024-02-26 22:28, Mathieu Arnold wrote:
> > >> > On Mon, Feb 26, 2024 at 08:48:02AM -0800, Chris wrote:
> > >> > > On 2024-02-25 04:37, Gleb Popov wrote:
> > >> > > > On Sun, Feb 25, 2024 at 3:34 PM Daniel Engberg
> > >> > > > <daniel.engberg.lists@pyret.net> wrote:
> > >> > > > > Hi,
> > >> > > > >
> > >> > > > > URL(s) for how we fetch releases/archives from Codeberg
> > >> > > >
> > >> > > > Ah, sorry, I just wasn't aware we're standardizing on this. Out of
> > >> > > > curiosity, what's the rationale behind the
> > >> > > > "${ACCOUNTNAME}/${PROJECTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/"
> > >> > > As I indicated in the pr(1) (276759) when you brought this up. The above
> > >> > > does not work:
> > >> > >
> > >> > > # make -DBATCH fetch
> > >> > > => ttcp-1.13.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
> > >> > > => Attempting to fetch
> > >> > > https://codeberg.org///archive/1.13.tar.gz?dummy=/ttcp-1.13.tar.gz
> > >> > > fetch: https://codeberg.org///archive/1.13.tar.gz?dummy=/ttcp-1.13.tar.gz:
> > >> > > Not Found
> > >> > >
> > >> > > Using *any* form of DIST(VERSION)PREFIX/SUFFIX/NAME is no closer to
> > >> > > returning anything
> > >> >
> > >> > Well, this is because the port is missing DISTVERSIONPREFIX=ttcp- as the
> > >> > tag is ttcp-1.13, and not 1.13.
> > >> Thanks for the reply, Mathieu.
> > >> That causes it to attempt to fetch ttcp-ttcp-1.13.tar.gz
> > >>
> > >> PORTNAME=    ttcp
> > >> PORTVERSION= 1.13
> > >> DISTVERSIONPREFIX=ttcp-
> > >> CATEGORIES=  benchmarks net
> > >> MASTER_SITES=        https://codeberg.org/BSDforge/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/
> > >
> > > MASTER_SITES= https://codeberg.org/BSDforge/ttcp/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/
> > ...
> > => ttcp-ttcp-1.13.tar.gz is spelled incorrectly.
> > thanks for trying. :)
> 
> Please disregard my previous message.
> 
> Simply setting:
> 
> MASTER_SITES=
> https://codeberg.org/BSDforge/ttcp/archive/${PORTNAME}-${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/
> 
> fixes the issue for me. I was taken a bit off-guard with ${PORTNAME}
> being a part of the tagname, which is rather unusual, but it fetches
> nicely from codeberg with this string.

Please, no, set DISTVERSIONPREFIX=${PORTNAME}-, don't change the url
template.

-- 
Mathieu Arnold