Re: git: 02bf6f32a982 - main - net-mgmt/icingaweb2-module-director: Update to 1.11.1

From: Florian Smeets <flo_at_smeets.xyz>
Date: Wed, 21 Feb 2024 22:37:58 UTC 
On 17.02.24 14:31, Jochen Neumeister wrote:
> The branch main has been updated by joneum:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=02bf6f32a982faf9dc2554ce1c284ac30ed856f4
> 
> commit 02bf6f32a982faf9dc2554ce1c284ac30ed856f4
> Author:     Jochen Neumeister <joneum@FreeBSD.org>
> AuthorDate: 2024-02-17 13:29:41 +0000
> Commit:     Jochen Neumeister <joneum@FreeBSD.org>
> CommitDate: 2024-02-17 13:31:12 +0000
> 
>      net-mgmt/icingaweb2-module-director: Update to 1.11.1
>      
> diff --git a/net-mgmt/icingaweb2-module-director/pkg-plist b/net-mgmt/icingaweb2-module-director/pkg-plist
> index d3de611aaabd..c870274103a7 100644
> --- a/net-mgmt/icingaweb2-module-director/pkg-plist
> +++ b/net-mgmt/icingaweb2-module-director/pkg-plist
> @@ -181,7 +181,7 @@
>   %%WWWDIR%%/configuration.php
>   %%WWWDIR%%/contrib/docker-test.sh
>   %%WWWDIR%%/contrib/linux-agent-installer/Icinga2Agent.bash
> -%%WWWDIR%%/contrib/systemd/icinga-director.service
> +%%WWWDIR%%/contrib/systemd/%%DIRECTOR_GROUP%%-director.service

This looks wrong.
> @@ -1151,4 +1156,4 @@
>   %%WWWDIR%%/test/php/library/Director/Resolver/TemplateTreeTest.php
>   %%WWWDIR%%/test/php/library/Director/Restriction/MatchingFilterTest.php
>   %%WWWDIR%%/test/phpunit-compat.php
> -@dir(%%DIRECTOR_USER%%,DIRECTOR_GROUP%%,0775) /var/run/icinga-director
> +@dir /var/run/%%DIRECTOR_GROUP%%-director

You lost the directory ownership.

Starting icinga_director.
daemon: ppidfile ``/var/run/icinga-director/icinga_director.pid'': 
Permission denied
/usr/local/etc/rc.d/icinga-director: WARNING: failed to start 
icinga_director

There is also PR 277212 about an unmet dependency for icinga-director 
1.11.1.

Additionally this is a security update and should have been labeled as 
such + vuxml entry.

Florian