From nobody Sun Feb 18 12:01:29 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Td45T6Fyrz541CF; Sun, 18 Feb 2024 12:01:33 +0000 (UTC) (envelope-from makc.freebsd@gmail.com) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Td45T3GfBz4ZM7; Sun, 18 Feb 2024 12:01:33 +0000 (UTC) (envelope-from makc.freebsd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of makc.freebsd@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=makc.freebsd@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-51197ca63f5so2995969e87.1; Sun, 18 Feb 2024 04:01:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708257691; x=1708862491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ST5i4tutxK17ZTUB/frLHaotuYAuCJAR24h3VMTX9mU=; b=Tv6IBiiY9BFBrZ6ZSZRRIKbP7bjficbFxFdzVMtpeQnHmtd7b9YgqC7y5baAeAHWLo kQhFxcEYsWQmOgQOGFoil3mI2vf17mAFsPWmyiqaqdv8dJD7wLCUrOi813nYTtVCjdVI c93+jTDxO97+t1twrw5W/aoW0vUIDDG1VKmrdrQMfmoJ160XfAvvW6dBJgROAb9n5mPF V+dScpIQP7WCTuwXj/i6GC9WbJIXHhjkcitnJb+DCIC1zf/HdT8r2gYKRELzf8+OF5vp 3whKOomx3a44HvBimWCOMgjeg7OhZwb6Dw4uTC3TgL1RfUgE4q/N8qC4G17q7Z+PtWEO lphA== X-Forwarded-Encrypted: i=1; AJvYcCV9WVcmcGpOPf1IrsRZUf/phBd3iOY4R3N6NH7k9mHmZ7jDF04IjszuhuItjRYW/3yUd7c1isDGte+7Q4tcDMERgUc3sooAJ3ZVfKw76oU9pSdIBlpQbeSnFiKhPbPQ2obY5sYVzrtKr/iqa2/5reuSzQ74cB+cDvDGqSlHLKgiovX3J88naPdHtMU= X-Gm-Message-State: AOJu0YyE1babwAjkg/PNKzbOl2OmFI3vo8+93YIpdvazu2SYn3GjO+fm XlScT1sdFk8wb2YGKa6H4aLxPFPVjK+viLXBETJQQAeeM4XLrkXQekBCCGe2Mljr4w== X-Google-Smtp-Source: AGHT+IEGzcTiLhWCkYWAwFJy3BqnYkONKUaxAY25lsTFDksHL/QIBWt+E9e6ORrMdp7CggGarpGGMA== X-Received: by 2002:a05:6512:3091:b0:512:af50:c599 with SMTP id z17-20020a056512309100b00512af50c599mr852215lfd.9.1708257690420; Sun, 18 Feb 2024 04:01:30 -0800 (PST) Received: from mercury.localnet (217-117-125-85.proc.ru. [217.117.125.85]) by smtp.gmail.com with ESMTPSA id m12-20020ac2424c000000b00512a370b3e2sm492047lfl.24.2024.02.18.04.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 04:01:30 -0800 (PST) From: Max Brazhnikov To: Neel Chauhan , Nuno Teixeira Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ca21dddc0e31 - main - graphics/libnsgif: Update to 1.0.0 Date: Sun, 18 Feb 2024 15:01:29 +0300 Message-ID: <2911916.SSXfckUlLJ@mercury> In-Reply-To: References: <202402161824.41GIOgvd075302@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Td45T3GfBz4ZM7 X-Spamd-Bar: - X-Spamd-Result: default: False [-1.86 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_SHORT(-0.46)[-0.456]; FORGED_SENDER(0.30)[makc@freebsd.org,makcfreebsd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.52:from]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[makc@freebsd.org,makcfreebsd@gmail.com]; TAGGED_FROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.52:from]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCPT_COUNT_FIVE(0.00)[5] Hi all, On Sat, 17 Feb 2024 07:26:22 +0000 Nuno Teixeira wrote: > Did you do a consumers test? >=20 > -include/libnsgif.h > +include/nsgif.h >=20 > graphics/imv: > ../src/backend_libnsgif.c:9:10: fatal error: 'libnsgif.h' file not found > 9 | #include >=20 > Any clues on recomended way to fix? >=20 > Neel Chauhan escreveu (sexta, 16/02/2024 =C3=A0(s) 18:24= ): > > > > The branch main has been updated by nc: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dca21dddc0e31a6be1db1f5= 966a283f52d89cddf5 > > > > commit ca21dddc0e31a6be1db1f5966a283f52d89cddf5 > > Author: Neel Chauhan > > AuthorDate: 2024-02-16 17:42:44 +0000 > > Commit: Neel Chauhan > > CommitDate: 2024-02-16 18:24:27 +0000 > > > > graphics/libnsgif: Update to 1.0.0 > > --- > > graphics/libnsgif/Makefile | 2 +- > > graphics/libnsgif/distinfo | 6 +++--- > > graphics/libnsgif/files/patch-Makefile | 10 ---------- > > graphics/libnsgif/pkg-plist | 4 ++-- > > 4 files changed, 6 insertions(+), 16 deletions(-) > > > > diff --git a/graphics/libnsgif/Makefile b/graphics/libnsgif/Makefile > > index 09c07dda9f9a..7e0697f3b78c 100644 > > --- a/graphics/libnsgif/Makefile > > +++ b/graphics/libnsgif/Makefile > > @@ -1,5 +1,5 @@ > > PORTNAME=3D libnsgif > > -PORTVERSION=3D 0.2.1 > > +PORTVERSION=3D 1.0.0 > > CATEGORIES=3D graphics > > MASTER_SITES=3D http://download.netsurf-browser.org/libs/releases/ > > EXTRACT_SUFX=3D -src.tar.gz skip > > diff --git a/graphics/libnsgif/pkg-plist b/graphics/libnsgif/pkg-plist > > index 38365be87a3a..927929719b65 100644 > > --- a/graphics/libnsgif/pkg-plist > > +++ b/graphics/libnsgif/pkg-plist > > @@ -1,5 +1,5 @@ > > -include/libnsgif.h > > +include/nsgif.h > > lib/libnsgif.so > > -lib/libnsgif.so.0 > > +lib/libnsgif.so.1 > > lib/libnsgif.so.%%VERSION%% > > libdata/pkgconfig/libnsgif.pc What was the reason for this commit? Changes like this require from the maintainer to test consumer ports. Reque= st exp-run if you can't test all consumers locally, notify other maintainer= s about the change (exp-run won't catch all cases), ask for help if you nee= d it. To me committing untested stuff that breaks other ports is disrespect= ful to fellow maintainers and users. Cheers, Max