From nobody Fri Feb 09 02:22:40 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TWHgr4YJVz58g9n; Fri, 9 Feb 2024 02:22:48 +0000 (UTC) (envelope-from i.h8.git@BSDforge.com) Received: from udns.ultimatedns.net (udns.ultimatedns.net [24.113.41.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "ultimatedns.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TWHgr1lxzz4D8R; Fri, 9 Feb 2024 02:22:48 +0000 (UTC) (envelope-from i.h8.git@BSDforge.com) Authentication-Results: mx1.freebsd.org; none Received: from ultimatedns.net (localhost [127.0.0.1]) by udns.ultimatedns.net (8.16.1/8.16.1) with ESMTP id 4192Meqw006055; Thu, 8 Feb 2024 18:22:46 -0800 (PST) (envelope-from i.h8.git@BSDforge.com) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Date: Thu, 08 Feb 2024 18:22:40 -0800 From: Chris To: Moin Rahman Cc: Daniel Engberg , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e2b4eb57621f - main - graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29 In-Reply-To: References: <202402082211.418MBK2t091444@gitrepo.freebsd.org> <9b6a0d96cb2fe54d6702727c9b1d882e@BSDforge.com> User-Agent: UDNSMS/17.0 Message-ID: <3f345b530da18a497a7d25a2a9e202ed@BSDforge.com> X-Sender: i.h8.git@BSDforge.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4TWHgr1lxzz4D8R X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:11404, ipnet:24.113.0.0/16, country:US] On 2024-02-08 17:31, Moin Rahman wrote: >> On Feb 9, 2024, at 2:25 AM, Chris wrote: >> >> On 2024-02-08 14:11, Daniel Engberg wrote: >>> The branch main has been updated by diizzy: >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=e2b4eb57621f1c96f678c210fe7d2474c904e295 >>> commit e2b4eb57621f1c96f678c210fe7d2474c904e295 >>> Author: Daniel Engberg >>> AuthorDate: 2024-02-08 22:08:52 +0000 >>> Commit: Daniel Engberg >>> CommitDate: 2024-02-08 22:09:19 +0000 >>> graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29 >>> Fails to build with libpng 1.6.41 due to usage of undocumented feature >>> to >>> disable Adler32 checksums. >>> Last release in 2017 and dead upstream, redirect users to >>> graphics/oxipng >>> or graphics/pngquant >> This port is not broken. Please reverse this. >> If you, or anyone has an issue with the port. Use the bug reporting >> channel. >> That's what it is designed for. >> >>> Reference: >>> >>> https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5 >>> PR: 276649 >>> Reviewed by: Anton Saietskii (maintainer) >>> --- >>> graphics/pngcrush/Makefile | 3 +++ >>> 1 file changed, 3 insertions(+) >>> diff --git a/graphics/pngcrush/Makefile b/graphics/pngcrush/Makefile >>> index 63e8ab2869d4..b38e9e664acc 100644 >>> --- a/graphics/pngcrush/Makefile >>> +++ b/graphics/pngcrush/Makefile >>> @@ -14,6 +14,9 @@ LICENSE_NAME= Pngcrush License >>> LICENSE_FILE= ${WRKSRC}/LICENSE >>> LICENSE_PERMS= dist-mirror pkg-mirror auto-accept >>> +BROKEN= Depends on undocumented feature to disable Adler32 checksums, >>> consider >>> graphics/oxipng or graphics/pngquant >>> +EXPIRATION_DATE=2024-02-29 >>> + >>> LIB_DEPENDS= libpng.so:graphics/png >>> USES= cpe localbase:ldflags tar:xz > > Do you have a log that it builds with the newest libpng? I'm on current, my ports tree is 5 days old. I built it before submitting this reply: fbsd15# make -DBATCH check-plist ===> License Pngcrush accepted by the user ===> pngcrush-1.8.13 depends on file: /usr/local/sbin/pkg - found => pngcrush-1.8.13-nolib.tar.xz doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch https://downloads.sourceforge.net/project/pmt/pngcrush/1.8.13/pngcrush-1.8.13-nolib.tar.xz pngcrush-1.8.13-nolib.tar.xz 64 kB 1076 kBps 00s ===> Fetching all distfiles required by pngcrush-1.8.13 for building ===> Extracting for pngcrush-1.8.13 => SHA256 Checksum OK for pngcrush-1.8.13-nolib.tar.xz. ===> Patching for pngcrush-1.8.13 ===> pngcrush-1.8.13 depends on shared library: libpng.so - found (/usr/local/lib/libpng.so) ===> Configuring for pngcrush-1.8.13 ===> Building for pngcrush-1.8.13 --- pngcrush.o --- touch png.h mv png.h png.h_embedded cc -c -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing pngcrush.c mv png.h_embedded png.h --- pngcrush --- cc -fstack-protector-strong -L/usr/local/lib -o pngcrush pngcrush.o -lpng -lz -lm ===> Staging for pngcrush-1.8.13 ===> Generating temporary packing list install -s -m 555 /usr/ports/graphics/pngcrush/work/pngcrush-1.8.13-nolib/pngcrush /usr/ports/graphics/pngcrush/work/stage/usr/local/bin/pngcrush ====> Compressing man pages (compress-man) ====> Running Q/A tests (stage-qa) Warning: you might not need LIB_DEPENDS on libpng.so ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) /usr/ports/graphics/pngcrush 5:05pm Thu, 08 fbsd15# Thanks. :)