Re: git: 41870b7b7d04 - main - lang/gcc{12,13}: Switch back to standard bootstrap

On Wednesday, February 7th, 2024 at 21:44, Lorenzo Salvadore <developer@lorenzosalvadore.it> wrote:

> 
> 
> On Wednesday, February 7th, 2024 at 16:42, Cy Schubert Cy.Schubert@cschubert.com wrote:
> 
> > Cy Schubert writes:
> > 
> > > In message 202402030957.4139vE0G052950@gitrepo.freebsd.org, Lorenzo Salvado
> > > re
> > > writes:
> > > 
> > > > The branch main has been updated by salvadore:
> > > > 
> > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=41870b7b7d042523cff7d8fe3abd
> > > > e2
> > > > 4f5a394804
> > > > 
> > > > commit 41870b7b7d042523cff7d8fe3abde24f5a394804
> > > > Author: Lorenzo Salvadore salvadore@FreeBSD.org
> > > > AuthorDate: 2023-11-07 10:59:49 +0000
> > > > Commit: Lorenzo Salvadore salvadore@FreeBSD.org
> > > > CommitDate: 2024-02-03 09:57:04 +0000
> > > > 
> > > > lang/gcc{12,13}: Switch back to standard bootstrap
> > > > 
> > > > Switch back to STANDARD_BOOTSTRAP on i386, amd64 and aarch64 as default
> > > > option instead of LTO_BOOTSTRAP, forwarding the changes already commite
> > > > d
> > > > in the devel ports (commits daf12c76bd531335f58e7602afd3bc8da8fc5c33,
> > > > 872d61f8ead10a6d935117876cf60057a46770ff, and
> > > > da4cb11216a7ed594d5dc453deb4693b48c3c7e9) and in lang/gcc11 (commit
> > > > 3e0fc5e7607d30400bfb3d5a7b3d1b77e1a6699a)
> > > > 
> > > > Users wanting to use LTO_BOOTSTRAP can still enable the option manually
> > > > .
> > > > 
> > > > PR: 273397
> > > > Tested by: exp-run (antoine)
> > > > ---
> > > > lang/gcc12/Makefile | 8 ++++----
> > > > lang/gcc13/Makefile | 8 ++++----
> > > > 2 files changed, 8 insertions(+), 8 deletions(-)
> > > > 
> > > > diff --git a/lang/gcc12/Makefile b/lang/gcc12/Makefile
> > > > index f7a1f1c239ca..6b84bc733f67 100644
> > > > --- a/lang/gcc12/Makefile
> > > > +++ b/lang/gcc12/Makefile
> > > > @@ -1,6 +1,6 @@
> > > > PORTNAME= gcc
> > > > PORTVERSION= 12.2.0
> > > > -PORTREVISION= 8
> > > > +PORTREVISION= 9
> > > > CATEGORIES= lang
> > > > MASTER_SITES= GCC
> > > > PKGNAMESUFFIX= ${SUFFIX}
> > > > @@ -37,9 +37,9 @@ CFLAGS:= ${CFLAGS:N-mretpoline}
> > > > CXXFLAGS:= ${CXXFLAGS:N-mretpoline}
> > > > 
> > > > OPTIONS_DEFINE= GRAPHITE
> > > > -OPTIONS_DEFAULT_aarch64=LTO_BOOTSTRAP
> > > > -OPTIONS_DEFAULT_amd64= LTO_BOOTSTRAP
> > > > -OPTIONS_DEFAULT_i386= LTO_BOOTSTRAP
> > > > +OPTIONS_DEFAULT_aarch64=STANDARD_BOOTSTRAP
> > > > +OPTIONS_DEFAULT_amd64= STANDARD_BOOTSTRAP
> > > > +OPTIONS_DEFAULT_i386= STANDARD_BOOTSTRAP
> > > > OPTIONS_DEFAULT_powerpc=LTO_BOOTSTRAP
> > > > OPTIONS_DEFAULT_powerpc64= LTO_BOOTSTRAP
> > > > OPTIONS_DEFAULT_powerpc64le= LTO_BOOTSTRAP
> > > > diff --git a/lang/gcc13/Makefile b/lang/gcc13/Makefile
> > > > index bdefea649447..4edd71bb7c29 100644
> > > > --- a/lang/gcc13/Makefile
> > > > +++ b/lang/gcc13/Makefile
> > > > @@ -1,6 +1,6 @@
> > > > PORTNAME= gcc
> > > > PORTVERSION= 13.2.0
> > > > -PORTREVISION= 3
> > > > +PORTREVISION= 4
> > > > CATEGORIES= lang
> > > > MASTER_SITES= GCC
> > > > PKGNAMESUFFIX= ${SUFFIX}
> > > > @@ -38,9 +38,9 @@ CFLAGS:= ${CFLAGS:N-mretpoline}
> > > > CXXFLAGS:= ${CXXFLAGS:N-mretpoline}
> > > > 
> > > > OPTIONS_DEFINE= GRAPHITE
> > > > -OPTIONS_DEFAULT_aarch64=LTO_BOOTSTRAP
> > > > -OPTIONS_DEFAULT_amd64= LTO_BOOTSTRAP
> > > > -OPTIONS_DEFAULT_i386= LTO_BOOTSTRAP
> > > > +OPTIONS_DEFAULT_aarch64=STANDARD_BOOTSTRAP
> > > > +OPTIONS_DEFAULT_amd64= STANDARD_BOOTSTRAP
> > > > +OPTIONS_DEFAULT_i386= STANDARD_BOOTSTRAP
> > > > OPTIONS_DEFAULT_powerpc64=LTO_BOOTSTRAP
> > > > OPTIONS_DEFAULT_powerpc64le=LTO_BOOTSTRAP
> > > > OPTIONS_RADIO= BOOTSTRAP
> > > 
> > > This has caused ./configure to fail on 15-CURRENT. Switching back to LTO circ
> > > umvents
> > > the regression.
> > > 
> > > checking for x86_64-portbld-freebsd15.0-gcc... /wrkdirs/usr/ports/lang/gcc12/
> > > work/.build/./gcc/xgcc -B/wrkdirs/usr/ports/lang/gcc12/work/.build/./gcc/ -B/
> > > usr/local/x86_64-portbld-freebsd15.0/bin/ -B/usr/local/x86_64-portbld-freebsd
> > > 15.0/lib/ -isystem /usr/local/x86_64-portbld-freebsd15.0/include -isystem /us
> > > r/local/x86_64-portbld-freebsd15.0/sys-include -fno-checking -m32
> > > checking whether the C compiler works... no
> > > configure: error: in `/wrkdirs/usr/ports/lang/gcc12/work/.build/x86_64-portbl d-freebsd15.0/32/libgomp': configure: error: C compiler cannot create executables See` config.log' for more details
> > > gmake[3]: *** [Makefile:23238: configure-stage1-target-libgomp] Error 1
> > > gmake[3]: Leaving directory '/wrkdirs/usr/ports/lang/gcc12/work/.build'
> > > gmake[2]: *** [Makefile:25580: stage1-bubble] Error 2
> > > gmake[2]: Leaving directory '/wrkdirs/usr/ports/lang/gcc12/work/.build'
> > > gmake[1]: *** [Makefile:25928: bootstrap-lean] Error 2
> > > gmake[1]: Leaving directory '/wrkdirs/usr/ports/lang/gcc12/work/.build'
> > > ===> Compilation failed unexpectedly.
> > > Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
> > > the maintainer.
> > > *** Error code 1
> > > 
> > > Stop.
> > > make: stopped in /usr/ports/lang/gcc12
> > > =>> Cleaning up wrkdir
> > > ===> Cleaning for gcc12-12.3.0
> > > 
> > > Unfortunately there is no config.log file in wrkdir to inspect.
> > 
> > I misdiagnosed the issue. It's -m32. Probably specific to 15-CURRENT. Will
> > test on a 14-REL VM if it behaves the same there.
> > 
> > Sorry for the spam.
> 
> 
> Thanks.
> 
> I confirm that, as far as I know, the issue is CURRENT-specific: I have received
> pkg-fallout only about CURRENT and many exp-runs confirmed that the patch works
> on RELEASEs.
> 
> I will work on it as soon as possibile, but unfortunately I have even higher
> priorities (finishing the GCC_DEFAULT update which is taking forever and
> fixing lang/gcc14-devel port).
> 
> Cheers,
> 
> Lorenzo Salvadore

Please mind however that
https://cgit.freebsd.org/src/commit/?id=49d684369c6682eebca325c55a6c96b7c03f5aeb
probably has already fixed the issue.

Thanks Brooks,

Lorenzo Salvadore