From nobody Sat Feb 03 11:32:21 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TRr8y1mmKz59Chy; Sat, 3 Feb 2024 11:32:34 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TRr8x74xhz4lJr; Sat, 3 Feb 2024 11:32:33 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-f182.google.com with SMTP id e9e14a558f8ab-363b37b6799so3505515ab.1; Sat, 03 Feb 2024 03:32:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706959952; x=1707564752; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e6rXRYbJRBN1heU0hYOHCEd8UwCHpKQyDRVx3+t/e5E=; b=XNnjow7F+wla0PS2GnxB0y4m5uz7ZVnfyp8fv+laBObUmhC9vtnXlnSEXV15nzHOV4 lANmyrUKFGB5anODHkZf5EsHpt0w/35f2hftGZMo6Ac3hDGW2yMFFOEanc4HiXI0omf4 FstwwoFykSyJtvE3DxI6iBPh2s6/yByTj+VVjVO9zh/16UtYkY+4XIQDIl3xhoHlkFYW CdVQh6wIz0Sut/BgdBy6xGrz72aFrp5TDEyATKmE2NgMCYdleT9zM2v+b+l3LCF3h4i4 kx59vdzY3oaM+t97XbOnMCR0GXUueq3hYReT65doalc5RMpr+GVTmf1nisD2QgOo001N Q8CQ== X-Gm-Message-State: AOJu0Yywoj/CpK4QYY+ZLU/uX5J7uI5xdSo4xXyYtMTv3RYtwBIk6kiM QMw+Gl+Bw4BBm78lWqAPvgYCECOLS9Sd3QMmlzAyqh8z5UnzkvilAAwL0RUcNo8oKQ== X-Google-Smtp-Source: AGHT+IFzBfVvzQr5EmUvIbop5RkdbGggclzUBNSFh3EcBugXp+UyR8grPmNA2nCuYBHrwdf7XyPW8w== X-Received: by 2002:a92:c108:0:b0:363:830e:8dea with SMTP id p8-20020a92c108000000b00363830e8deamr857784ile.3.1706959951530; Sat, 03 Feb 2024 03:32:31 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUkfoD2Zh/cG+cNT5IxYpg1MtQDrdtjaWjFmWcvnQxwez+0rPcsvSB2K2Ji40CtD9S3MQeaFA2BKikFsVnDILnfbpuXQkp6AtIzwq8hRhpTY77ElElraUh6DnJOAEsXbGmM1pdGFIMAeoRkib3MEMUhIEmHauV80hkjHEWLjhwy/XGkxn+oif9oJbbFAhDF7my9Prqa+WmGyzzFvq/o2nmcaJxMnL9pe7q/dYZ+DVn/iD/4WRiHPqfeUGSXlSQ= Received: from mail-il1-f174.google.com (mail-il1-f174.google.com. [209.85.166.174]) by smtp.gmail.com with ESMTPSA id l5-20020a922805000000b003627c2f5377sm1163634ilf.16.2024.02.03.03.32.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Feb 2024 03:32:31 -0800 (PST) Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-363b37b6799so3505485ab.1; Sat, 03 Feb 2024 03:32:31 -0800 (PST) X-Received: by 2002:a92:cc0d:0:b0:363:ba1b:66c2 with SMTP id s13-20020a92cc0d000000b00363ba1b66c2mr904380ilp.15.1706959950732; Sat, 03 Feb 2024 03:32:30 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202402021346.412DkSeX016477@gitrepo.freebsd.org> <23b873e3-051e-4d3e-8f66-21bbc57783bc@freebsd.org> <4018119.BRNeRiNLvY@mercury> <8r41-95wd-wny@FreeBSD.org> In-Reply-To: <8r41-95wd-wny@FreeBSD.org> From: Luca Pizzamiglio Date: Sat, 3 Feb 2024 12:32:21 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 06dbf1df62a4 - main - audio/alsa-plugins: convert options to subpackages To: Jan Beich Cc: Max Brazhnikov , Charlie Li , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, portmgr@freebsd.org Content-Type: multipart/alternative; boundary="0000000000008262e706107895c3" X-Rspamd-Queue-Id: 4TRr8x74xhz4lJr X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] --0000000000008262e706107895c3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I would stop adding more subpackages, until we have fixed those small annoying bugs. Dogfooding has already surfaced a few issues, so it's time to fix those issues before adding more stuff. On Sat, Feb 3, 2024 at 11:52=E2=80=AFAM Jan Beich wrot= e: > Max Brazhnikov writes: > > > On Sat, 03 Feb 2024 07:06:28 +0100 Jan Beich wrote: > > > >> Charlie Li writes: > >> > >> > Jan Beich wrote: > >> > > >> >> The branch main has been updated by jbeich: > >> >> URL: > >> >> > https://cgit.FreeBSD.org/ports/commit/?id=3D06dbf1df62a4f54da4cadecbbc0be= 5f33902eb1c > >> >> commit 06dbf1df62a4f54da4cadecbbc0be5f33902eb1c > >> >> Author: Jan Beich > >> >> AuthorDate: 2024-01-30 16:18:28 +0000 > >> >> Commit: Jan Beich > >> >> CommitDate: 2024-02-02 13:44:56 +0000 > >> >> audio/alsa-plugins: convert options to subpackages > >> >> Reduce heavy dependencies for consumers e.g., > >> >> - chromium -> pipewire -> alsa-plugins -> pulseaudio > >> >> - wine -> alsa-plugins -> pulseaudio > >> >> > >> > At least my poudriere wants to delete and rebuild every run because = it > >> > thinks a new dependency is always missing. > >> > >> See https://github.com/freebsd/poudriere/issues/1113 > > > > Can we please stop adding new subpackages until this issue is fixed? > > - this change has high ROI: disable PULSEAUDIO by default vs. "batteries > included" > - not much of an issue for the package cluster due to high churn on > /latest set > - shouldn't impact unsupervised or portmsater builds (options are still > there) > - SUBPACKAGES require dogfooding[1] to test tools and avoid regressions > > [1] https://reviews.freebsd.org/D43079 was far too simple > https://reviews.freebsd.org/D43445 was actually incorrect > --0000000000008262e706107895c3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I would stop adding more subpackages, until we have f= ixed those small annoying bugs.
Dogfooding has already surfaced a= few issues, so it's time to fix those issues before adding more stuff.=

On Sat, Feb 3, 2024 at 11:52=E2=80=AFAM Jan Beich <jbeich@freebsd.org> wrote:
Max Brazhnikov <makc@freebsd.org> writes:=

> On Sat, 03 Feb 2024 07:06:28 +0100 Jan Beich wrote:
>
>> Charlie Li <vishwin@freebsd.org> writes:
>>
>> > Jan Beich wrote:
>> >
>> >> The branch main has been updated by jbeich:
>> >> URL:
>> >> https://cgit.FreeBSD.org/ports/commit/?id=3D06dbf1df62a4f54da4cadecbbc0be= 5f33902eb1c
>> >> commit 06dbf1df62a4f54da4cadecbbc0be5f33902eb1c
>> >> Author:=C2=A0 =C2=A0 =C2=A0Jan Beich <jbeich@FreeBSD.o= rg>
>> >> AuthorDate: 2024-01-30 16:18:28 +0000
>> >> Commit:=C2=A0 =C2=A0 =C2=A0Jan Beich <jbeich@FreeBSD.o= rg>
>> >> CommitDate: 2024-02-02 13:44:56 +0000
>> >>=C2=A0 =C2=A0 =C2=A0 audio/alsa-plugins: convert options t= o subpackages
>> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Reduce heavy depe= ndencies for consumers e.g.,
>> >>=C2=A0 =C2=A0 =C2=A0 - chromium -> pipewire -> alsa-= plugins -> pulseaudio
>> >>=C2=A0 =C2=A0 =C2=A0 - wine -> alsa-plugins -> pulse= audio
>> >>=C2=A0 =C2=A0 =C2=A0
>> > At least my poudriere wants to delete and rebuild every run b= ecause it
>> > thinks a new dependency is always missing.
>>
>> See https://github.com/freebsd/poudriere/is= sues/1113
>
> Can we please stop adding new subpackages until this issue is fixed?
- this change has high ROI: disable PULSEAUDIO by default vs. "batteri= es included"
- not much of an issue for the package cluster due to high churn on /latest= set
- shouldn't impact unsupervised or portmsater builds (options are still= there)
- SUBPACKAGES require dogfooding[1] to test tools and avoid regressions

[1] https://reviews.freebsd.org/D43079 was far too simple
=C2=A0 =C2=A0 https://reviews.freebsd.org/D43445 was actually = incorrect
--0000000000008262e706107895c3--