git: 147aeb1ee48f - main - lang/ratfor: fix build on platforms where char is unsigned
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 26 Dec 2024 10:47:09 UTC
The branch main has been updated by fuz:
URL: https://cgit.FreeBSD.org/ports/commit/?id=147aeb1ee48f8aeb8e4892e3271a3231388a412c
commit 147aeb1ee48f8aeb8e4892e3271a3231388a412c
Author: Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2024-12-25 00:07:07 +0000
Commit: Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-26 10:46:28 +0000
lang/ratfor: fix build on platforms where char is unsigned
Turns out the code anticipates this problem and has support for using
"signed char" over "char" where "char" is unsigned by default.
Use "signed char" unconditionally to fix the port on all platforms.
While we are at it, pet portclippy.
PR: 258628, 283509
Approved by: bofh
MFH: 2024Q4
---
lang/ratfor/Makefile | 17 ++++++-----------
lang/ratfor/files/patch-Makefile | 2 +-
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/lang/ratfor/Makefile b/lang/ratfor/Makefile
index 3c13978b5f1f..0b4dee9b243f 100644
--- a/lang/ratfor/Makefile
+++ b/lang/ratfor/Makefile
@@ -1,6 +1,6 @@
PORTNAME= ratfor
PORTVERSION= 1985.06
-PORTREVISION= 16
+PORTREVISION= 17
CATEGORIES= lang
MASTER_SITES= LOCAL/obrien \
http://sepwww.stanford.edu/sep/prof/
@@ -12,20 +12,15 @@ COMMENT= Rational FORTRAN compiler
LICENSE= PD
LICENSE_FILE= ${WRKSRC}/README
-BROKEN_aarch64= ./ratfor -o test.f test.r keeps creating huge output file
-BROKEN_armv6= ./ratfor -o test.f test.r keeps creating huge output file
-BROKEN_armv7= ./ratfor -o test.f test.r keeps creating huge output file
-BROKEN_powerpc= ./ratfor -o test.f test.r keeps creating huge output file
-BROKEN_powerpc64= ./ratfor -o test.f test.r keeps creating huge output file
-BROKEN_powerpc64le= ./ratfor -o test.f test.r keeps creating huge output file
-BROKEN_powerpcspe= ./ratfor -o test.f test.r keeps creating huge output file
+USES= fortran
+
+ALL_TARGET= all tests
-NO_WRKSUBDIR= yes
EXTRACT_CMD= ${CAT}
EXTRACT_BEFORE_ARGS=
EXTRACT_AFTER_ARGS= | ${SH}
-ALL_TARGET= all tests
-USES= fortran
+
+NO_WRKSUBDIR= yes
PLIST_FILES= bin/ratfor bin/ratfor77 share/man/man1/ratfor.1.gz
diff --git a/lang/ratfor/files/patch-Makefile b/lang/ratfor/files/patch-Makefile
index 4ce15b7de3a4..b686e9ab66b8 100644
--- a/lang/ratfor/files/patch-Makefile
+++ b/lang/ratfor/files/patch-Makefile
@@ -5,7 +5,7 @@
#
-CFLAGS+= -DF77 -DS_CHAR="char"
-+CFLAGS+= -DF77 -DS_CHAR="char" -Wno-error=return-type
++CFLAGS+= -DF77 -DS_CHAR="signed char" -Wno-error=return-type
#CFLAGS+= -DS_CHAR="char"
OBJS= rat4.o lookup.o getopt.o