Re: git: 92b0c9cdbef5 - main - sysutils/screen*: Fix stack overflow detected on aarch64

On Sun, Aug 18, 2024 at 01:11:53PM +0000, Cy Schubert wrote:
> The branch main has been updated by cy:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=92b0c9cdbef548739d6209165c3e1731761d010d
> 
> commit 92b0c9cdbef548739d6209165c3e1731761d010d
> Author:     Cy Schubert <cy@FreeBSD.org>
> AuthorDate: 2024-08-18 13:08:04 +0000
> Commit:     Cy Schubert <cy@FreeBSD.org>
> CommitDate: 2024-08-18 13:11:28 +0000
> 
>     sysutils/screen*: Fix stack overflow detected on aarch64
>     
>     Fix,
>     
>     SCREEN[1304]: stack overflow detected; terminated
>     kernel: pid 1304 (screen-4.9.1), jid 0, uid 0: exited on signal 6 (core dumped)
>     
This looks to me that you are sweeping the actual problem under the carpet.

>     PR:             280868
>     Tested by:      Andreas Schwarz <bugs.freebsd.asc@schwarzes.net>
>     MFH:            2024Q3
> ---
>  sysutils/screen-devel/Makefile | 4 ++--
>  sysutils/screen/Makefile       | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sysutils/screen-devel/Makefile b/sysutils/screen-devel/Makefile
> index 6fd8da0df5e8..fef590ffacc8 100644
> --- a/sysutils/screen-devel/Makefile
> +++ b/sysutils/screen-devel/Makefile
> @@ -50,8 +50,8 @@ CPE_VENDOR=	gnu
>  
>  .include <bsd.port.options.mk>
>  
> -.if ${ARCH} == armv6 || ${ARCH} == armv7 || ${ARCH} == i386 || \
> -    ${ARCH:Mpowerpc*}
> +.if ${ARCH} == aarch64 || ${ARCH} == armv6 || ${ARCH} == armv7 || \
> +    ${ARCH} == i386 || ${ARCH:Mpowerpc*}
>  SSP_CFLAGS?=	-fno-stack-protector

So something in screen is broken, or needs to do "interesting" stuff to work.
>  .endif
>  
> diff --git a/sysutils/screen/Makefile b/sysutils/screen/Makefile
> index d16f1ea3e05f..52dfb4145ab1 100644
> --- a/sysutils/screen/Makefile
> +++ b/sysutils/screen/Makefile
> @@ -52,8 +52,8 @@ CPE_VENDOR=	gnu
>  
>  .include <bsd.port.options.mk>
>  
> -.if ${ARCH} == armv6 || ${ARCH} == armv7 || ${ARCH} == i386 || \
> -    ${ARCH:Mpowerpc*}
> +.if ${ARCH} == aarch64 || ${ARCH} == armv6 || ${ARCH} == armv7 || \
> +    ${ARCH} == i386 || ${ARCH:Mpowerpc*}
>  SSP_CFLAGS?=	-fno-stack-protector
>  .endif
>  

Regards,
René