Re: git: 7bb64b89d0e5 - main - framework: add Mk/Uses/pycryptography

Hello,

On Tue, Aug 1, 2023 at 2:31 AM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:

> Hello,
>
> How about USE_PYTHON={cryptography_build,cryptography,cryptography_test}?
> USE_PYTHON=cryptography is the runtime dependency because it is mostly
> used in RUN_DEPENDS.
>
> For the current ports tree, I get the following result via "git grep
> pycryptography":
> 89 USES=pycryptography:run
>  5 USES=pycryptography:test
>  2 USES=pycryptography:run,test
>  1 USES=pycryptography:build,run
>  0 USES=pycryptography
>
>
I've submitted PR 273727 for this.
Thanks.

Regards,
sunpoet



> Regards,
> sunpoet
>
> On Mon, Jul 24, 2023 at 10:54 PM Tobias C. Berner <tcberner@freebsd.org>
> wrote:
>
>> Moin moin
>>
>> It seemed an easier way to stop-gap fix this issue separately. But
>> you're probably right, that python.mk would be the preferred location
>> to do so.
>>
>> I can move it there.
>>
>>
>> mfg Tobias
>>
>> On Sat, 22 Jul 2023 at 14:51, Antoine Brodin <antoine@freebsd.org> wrote:
>> >
>> > On Sat, Jul 22, 2023 at 7:48 AM Tobias C. Berner <tcberner@freebsd.org>
>> wrote:
>> > >
>> > > The branch main has been updated by tcberner:
>> > >
>> > > URL:
>> https://cgit.FreeBSD.org/ports/commit/?id=7bb64b89d0e5ec8d77b28f8341269ffbad279ebf
>> > >
>> > > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf
>> > > Author:     Tobias C. Berner <tcberner@FreeBSD.org>
>> > > AuthorDate: 2023-07-22 06:16:46 +0000
>> > > Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
>> > > CommitDate: 2023-07-22 07:46:38 +0000
>> > >
>> > >     framework: add Mk/Uses/pycryptography
>> > >
>> > >     With the added new DEFAULT_VERSION
>> "PYCRYPTOGRAHY_DEFAULT=rust|legacy"
>> > >     it is important to transparently depend on the right one.
>> > >
>> > >     This is the job of this new uses.
>> > >
>> > >     So instead of manually adding dependency lines like
>> > >
>> > >
>>  RUN_DEPENDS=${PYTHON_PKGNAMEPREFIX}cryptography>0:security/py-cryptography@
>> ${PY_FLAVOR}
>> > >
>> > >     this should now be
>> > >
>> > >             USES=pycryptography:run
>> > >
>> > >     Supported arguments: <none>,build,run,test
>> > >     If no argument is given, it defaults to 'build,run'.
>> > >
>> > >     A future commit will update to security/py-cryptography will
>> introduce a
>> > >     rust dependency.
>> > >
>> > >     PR:             254853
>> >
>> > Hi,
>> >
>> > Why isn't it a USE_PYTHON= pycryptography?
>> >
>> > Antoine
>>
>