From nobody Wed Oct 11 04:11:31 2023
X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S4zq75l9Bz4wpqZ;
	Wed, 11 Oct 2023 04:11:31 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4S4zq75JMWz3Ldt;
	Wed, 11 Oct 2023 04:11:31 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1696997491;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=R8mybglMkSdhcdJwjP0ncUWGMBM5ZaAmxlfuHPdu1ec=;
	b=SLUIaudM7pJo3cORGcGuw4f0ch1utPxRt5f6E9IE5V4udD0lMRwCNLdulK4XeePAsrRX3d
	m+g4Xhc8YXME2sw6aA4nuWkdq7kkBQLRRrwSY8ysG1XwMe8jCQNF6naVsEjQgRWqK+6NWl
	wrgy4gTtEpDFoBt71qBuN/5KCIaoaGV9ORmTbc27b97jT1L9VPofqAVaYp5UvtIT6s1BCo
	THLDdiBpH62Ca9Bh0V37AjxuCTAEv7g95TSJ7G894nxGHOQonwxKs3Cf1UrpATTcsgoN7+
	7uWnmH3gHM0Ft7lpZpTuvri307hOmuOjghcXBGVGzHvwrDdWCOqQi8fYmjkT8w==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696997491; a=rsa-sha256; cv=none;
	b=cogiijLJ3+M2+nHNQz6MfK3HzhH5o/05JKJDmFg/GbRYPmkVm6qHoATN9H36Jb0I9/XWEJ
	QsaExjD3fPk1rpxR3RHhgPrU9wPHCV86vrZKkqtmed/qupi23nZuX/jj21Ik/IPYo8M9sO
	e7A7B8x5aqlMQDdVH6Gmp9WeTSN2TLEappL8heyd6yTtC10x4E41jiyqOB5C7xJNkXManF
	N5zkHCIZwgKrKn9sBR/N+0lDUVr2oYHu2sPcfvC7wnOsoXSwTAL6ZPms/leqAO9t1uKB/F
	ZKtNiBFVz1dWi1fafFFL8yrddxVC9ywcFV0XDBDZHTeQuZ/PiGu9EsgZlEgazQ==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1696997491;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=R8mybglMkSdhcdJwjP0ncUWGMBM5ZaAmxlfuHPdu1ec=;
	b=o2tU4U5dxJ7LhCB2uktQIOK8PeX/nSk1X8IhqqhMXybKBOBujwOoBSysDN2fcH1ENtM2PH
	keDkQ/yqc6RsDreOQV41hsfNGQQsYpAMgb1TBQ6f/PVwarJ6y46mdct/gxyy2fsaSkOY+8
	w5O6csYG/X6yh7yrRACxUPm0P2nf2XQoGVeDnkp1/oc6R/gnPo+Y2YvsercJLMWTF/m1Xe
	tidtVdPwUHTQKMVyPxxCgNiaIJU1u+HyHc1yaYFH3NPi6VoVLK0StObVs0bRoJDxGQl6/b
	k0+d6ILEE+NbDQJuvyEuImK/GlFzovvADbh6+R1Aa4oyo6ZARmH7kR9R/5qyWA==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id 9921C6E81; Wed, 11 Oct 2023 04:11:31 +0000 (UTC)
Date: Wed, 11 Oct 2023 04:11:31 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Cy Schubert <cy@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: 4da0d4b17cba - main - sysutils/nut*: Optionally install
 developer files
Message-ID: <ZSYgc64IdRN-_PLJ@FreeBSD.org>
References: <202310110252.39B2qIw1032317@gitrepo.freebsd.org>
List-Id: Commit messages for all branches of the ports repository <dev-commits-ports-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all
List-Help: <mailto:dev-commits-ports-all+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-all@freebsd.org
X-BeenThere: dev-commits-ports-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202310110252.39B2qIw1032317@gitrepo.freebsd.org>

On Wed, Oct 11, 2023 at 02:52:18AM +0000, Cy Schubert wrote:
> commit 4da0d4b17cba94ae605f3541234a7436d723c170
> 
>   sysutils/nut*: Optionally install developer files
>   
>   Most users do not need files needed for nut development. Make them
>   optional.
...
>  OPTIONS_SUB=	yes

So there's OPTIONS_SUB, right?

> @@ -56,6 +57,7 @@ CGI_DESC=	Web CGI interface
>  FREEIPMI_DESC=	freeipmi support
>  IPMIPSU_DESC=	Use nut-ipmipsu support (experimental)
>  SSL_OFF_DESC=	No SSL support
> +DEV_DESC=	Install developer tools
>  
>  USE_RC_SUBR=	nut nut_upsmon nut_upslog
>  SUB_LIST+=	STATEDIR=${STATEDIR} NUT_USER=${NUT_USER} NUT_GROUP=${NUT_GROUP}
> @@ -134,6 +135,10 @@ OPENSSL_CONFIGURE_WITH=	openssl
>  NSS_LIB_DEPENDS=	libnss3.so:security/nss
>  NSS_CONFIGURE_WITH=	nss
>  
> +DEV_CONFIGURE_WITH=	dev
> +DEV_PLIST_SUB=		DEV=""
> +DEV_PLIST_SUB_OFF=	DEV="@comment "

Then manual PLIST_SUB dances are not needed.  In fact, they'd clash with
existing ones:

$ make -V PLIST_SUB | xargs -n1 | grep DEV=
DEV=@comment
NO_DEV=
DEV=@comment

./danfe