From nobody Fri Oct 06 17:50:59 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2GF02Khtz4w0kw; Fri, 6 Oct 2023 17:51:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2GF01NVjz4d2m; Fri, 6 Oct 2023 17:51:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696614660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=14+VPVgVNwgUjInH/63mEAHAAIMeNHo0eISiO2La3yQ=; b=EggLNv0VCT28FU+HnCU7hyQsb1G+K2Zmti6dg/JnImapzW9zze2r3aQuga39Pwohmgtg9B 1+LTcYpI+9RW5RwWYWq+ZbElYcdFwiFanv0/xsPBeRQji2miOYauXf+hkAULvqqVi9bTdm +EaLYiZ4Q4O0bT6LgqoAK4DZaieNyNNSc4A3nnjB/UgxAFNgwODzLlgVQqthTNg9zNyW/q q3qSE4ArLWHndWmhvY0qtEwhNyzpnJrWj14s0EpN6kTH5RKhdTc/a3UuLOn5HNk+vdYCLR GQeSuUt1VWAsI+KmhGwSTPhGnqUMN2NGx6xFQSClnfZGgBtCr80vAUBYy9A4vA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696614660; a=rsa-sha256; cv=none; b=rna09cRlFxqtLqZ9XoPgzH3qo8KTXnO4VQ/UN+bCOsm0P1Ht0uQyWvBtZ/O3DB7RLeUtkO WErTQ0GdEp5dZrbHFbekIuOIwT3C1jChePn6vtvXxf33yBNc9iACsFBRnl9QOkRaEaUrN7 AedPt1We/WoND22ICOYm/EBDYLFOKf8Cdu5bFzpt9HkiYMwTLgVA6wQ2aOhOk6E+N1VOQz qQTpDKfx+Gka6AK8yZ5UaVklzYzvrPj+RpRGp001wnNqrtNmQtFZMz54qmVDjYhKrl7bgs vaS06k0pARjXGUiqhde2qc7FzwvQStR7SDSpP6TcjNPw+6xLiXwV18wzmLh8ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696614660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=14+VPVgVNwgUjInH/63mEAHAAIMeNHo0eISiO2La3yQ=; b=uQfNBi1WuqIoi3Br4U5YOTae3ExhyhGSGdr14olca6LiFwhgA13OS6+3W4EizPmXu0jVYf Caqh+jtO5CTuLcgb/B57YtivCgVP9+JIt7In1FOlXtOfx1GB2eSMKr01rcv9eFWld6rqn3 ooOnlTQtDeqr0K9qI+QT1/fRHnYIlPebqeKGQfO1R08drTfx/y48v/SuE9+7E9odc6J2Df x5AiTiR/9TQXzfCTxHdvO7pmIMsWm6ojRVKGKvo76rb6SronqdwoQImbBixT56TKkojgfB WMJXVZuHPsuA8/Twy9xqv6PxkIICLFHWu567Uaf6CPM8LusLnBY8WlsE1kaZBA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S2GF00MTszxlF; Fri, 6 Oct 2023 17:51:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 396HoxFb039380; Fri, 6 Oct 2023 17:50:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 396HoxAP039377; Fri, 6 Oct 2023 17:50:59 GMT (envelope-from git) Date: Fri, 6 Oct 2023 17:50:59 GMT Message-Id: <202310061750.396HoxAP039377@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: 2bd641cc196e - main - java/openjdk17: fix build with lld 17 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2bd641cc196eebc4dcb3df64df89fe30934106c0 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=2bd641cc196eebc4dcb3df64df89fe30934106c0 commit 2bd641cc196eebc4dcb3df64df89fe30934106c0 Author: Dimitry Andric AuthorDate: 2023-09-26 15:26:06 +0000 Commit: Dimitry Andric CommitDate: 2023-10-06 17:48:54 +0000 java/openjdk17: fix build with lld 17 Building java/openjdk17 with lld 17 results in the following link errors: ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZ21WB_HandshakeWalkStackE16TraceSelfClosure' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZ26WB_AsyncHandshakeWalkStackE16TraceSelfClosure' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN12JvmtiEnvBase27check_for_periodic_clean_upEvE28ThreadInsideIterationClosure' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN15G1RemSetSummary6updateEvE11CollectData' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN16SATBMarkQueueSet22set_active_all_threadsEbbE22SetThreadActiveClosure' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN16SATBMarkQueueSet23abandon_partial_markingEvE25AbandonThreadQueueClosure' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN18G1ConcurrentRefine30get_and_reset_refinement_statsEvE12CollectStats' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN19G1DirtyCardQueueSet12abandon_logsEvE23AbandonThreadLogClosure' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN19G1DirtyCardQueueSet16concatenate_logsEvE27ConcatenateThreadLogClosure' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN19G1DirtyCardQueueSet30get_and_reset_refinement_statsEvE12CollectStats' failed: symbol not defined ld: error: version script assignment of 'SUNWprivate_1.1' to symbol '_ZTVZN7Threads25change_thread_claim_tokenEvE11ResetClaims' failed: symbol not defined c++: error: linker command failed with exit code 1 (use -v to see invocation) This is because lld 17 defaults to errors when undefined symbols are referenced in linker version scripts. The problem is due to the Makefile JvmMapfile.gmk, which generates a linker version script. It uses "nm --defined-only" to dump symbols in object files, but this also includes local (hidden) symbols. Add "--extern-only" to make it only dump global symbols. PR: 274109 Approved by: maintainer timeout (10 days) MFH: 2023Q4 --- .../files/patch-make_hotspot_lib_JvmMapfile.gmk | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/java/openjdk17/files/patch-make_hotspot_lib_JvmMapfile.gmk b/java/openjdk17/files/patch-make_hotspot_lib_JvmMapfile.gmk new file mode 100644 index 000000000000..f3dd87603e77 --- /dev/null +++ b/java/openjdk17/files/patch-make_hotspot_lib_JvmMapfile.gmk @@ -0,0 +1,20 @@ +--- make/hotspot/lib/JvmMapfile.gmk.orig 2023-07-19 03:18:33 UTC ++++ make/hotspot/lib/JvmMapfile.gmk +@@ -53,7 +53,7 @@ ifeq ($(call isTargetOs, linux), true) + # platform dependent. + + ifeq ($(call isTargetOs, linux), true) +- DUMP_SYMBOLS_CMD := $(NM) --defined-only *.o ++ DUMP_SYMBOLS_CMD := $(NM) --extern-only --defined-only *.o + ifneq ($(FILTER_SYMBOLS_PATTERN), ) + FILTER_SYMBOLS_PATTERN := $(FILTER_SYMBOLS_PATTERN)| + endif +@@ -117,7 +117,7 @@ else ifeq ($(call isTargetOs, bsd), true) + if ($$3 ~ /$(FILTER_SYMBOLS_PATTERN)/) print $$3; \ + }' + else +- DUMP_SYMBOLS_CMD := $(NM) --defined-only *.o ++ DUMP_SYMBOLS_CMD := $(NM) --extern-only --defined-only *.o + FILTER_SYMBOLS_AWK_SCRIPT := \ + '{ \ + if ($$3 ~ /$(FILTER_SYMBOLS_PATTERN)/) print $$3; \