Re: git: cc581518912f - main - databases/sql-workbench: update to 138

From: Fernando_Apesteguía <fernape_at_freebsd.org>
Date: Tue, 28 Nov 2023 11:40:10 UTC
On Tue, Nov 28, 2023 at 12:34 PM Fernando Apesteguía <fernape@freebsd.org>
wrote:

>
>
> On Tue, Nov 28, 2023 at 11:30 AM Vladimir Druzenko <vvd@freebsd.org>
> wrote:
>
>> 28.11.2023 13:13, Fernando Apesteguía пишет:
>>
>>
>>
>> El mar, 28 nov 2023, 10:52, Vladimir Druzenko <vvd@freebsd.org> escribió:
>>
>>> 28.11.2023 11:24, Fernando Apesteguía пишет:
>>> > The branch main has been updated by fernape:
>>> >
>>> > URL:
>>> https://cgit.FreeBSD.org/ports/commit/?id=cc581518912fbcc010287985e864928d911b97af
>>> >
>>> > commit cc581518912fbcc010287985e864928d911b97af
>>> > Author:     Fernando Apesteguía <fernape@FreeBSD.org>
>>> <fernape@FreeBSD.org>
>>> > AuthorDate: 2023-11-20 08:05:27 +0000
>>> > Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
>>> <fernape@FreeBSD.org>
>>> > CommitDate: 2023-11-28 08:23:44 +0000
>>> >
>>> >      databases/sql-workbench: update to 138
>>> >
>>> >      ChangeLog: https://www.sql-workbench.eu/history.html
>>> >
>>> >      Reported by:    portscout
>>> > ---
>>> >   databases/sql-workbench/Makefile | 4 ++--
>>> >   databases/sql-workbench/distinfo | 6 +++---
>>> >   2 files changed, 5 insertions(+), 5 deletions(-)
>>> >
>>> > diff --git a/databases/sql-workbench/Makefile
>>> b/databases/sql-workbench/Makefile
>>> > index 1de24585f026..fc719ead8569 100644
>>> > --- a/databases/sql-workbench/Makefile
>>> > +++ b/databases/sql-workbench/Makefile
>>> > @@ -1,5 +1,5 @@
>>> >   PORTNAME=   sql-workbench
>>> > -PORTVERSION= 127
>>> > +PORTVERSION= 138
>>> >   PORTEPOCH=  1
>>> >   CATEGORIES= databases java
>>> >   MASTER_SITES=       http://www.sql-workbench.net/ \
>>> > @@ -14,7 +14,7 @@ LICENSE=    APACHE20
>>> >
>>> >   USES=               zip
>>> >   USE_JAVA=   yes
>>> > -JAVA_VERSION=        8+
>>> > +JAVA_VERSION=        11+
>>> >
>>> >   NO_BUILD=   yes
>>> >   NO_WRKSUBDIR=       yes
>>> > diff --git a/databases/sql-workbench/distinfo
>>> b/databases/sql-workbench/distinfo
>>> > index 9ec3c42b8a95..65e467767a3f 100644
>>> > --- a/databases/sql-workbench/distinfo
>>> > +++ b/databases/sql-workbench/distinfo
>>> > @@ -1,3 +1,3 @@
>>> > -TIMESTAMP = 1613164253
>>> > -SHA256 (Workbench-Build127.zip) =
>>> da017f92bb344b846027d52223be6d88ffd283368495a0b26b6e1334a42ac955
>>> > -SIZE (Workbench-Build127.zip) = 8275806
>>> > +TIMESTAMP = 1701157804
>>> > +SHA256 (Workbench-Build138.zip) =
>>> 2ac589b9f57e6d8fdcfca55e3e734e236f9b75d410aa76d0dd528ee079db59c7
>>> > +SIZE (Workbench-Build138.zip) = 9563223
>>>
>>> ===>   sql-workbench-138,1 depends on file:
>>> /usr/local/share/java/classes/mysql-connector-java.jar - not found
>>> Error a dependency refers to a non existing origin:
>>> /usr/ports/databases/mysql-connector-java in RUN_DEPENDS
>>>
>>> $ grep mysql-connector-java MOVED
>>> databases/mysql-connector-java|databases/mysql-connector-j|2023-08-27|Following
>>>
>>> rename with upstream
>>>
>>> Require update deps:
>>> -MYSQL_JDBC_RUN_DEPENDS=
>>> ${JAVALIBDIR}/mysql-connector-java.jar:databases/mysql-connector-java
>>> +MYSQL_JDBC_RUN_DEPENDS=
>>> ${JAVALIBDIR}/mysql-connector-j.jar:databases/mysql-connector-j
>>>
>>> P.S. I can commit fix self if mentors approve.
>>>
>>
>> Hi Vladimir,
>>
>> Let me have a look. I built this in poudriere this morning before the
>> update (I've been doing this for the last few days as new versions were
>> released) and didn't catch this which is strange.
>>
>> MYSQL_JDBC isn't default option.
>>
>
> That's it.
> Thanks for reporting.
>
> I need to open a PR for poudriere-devel, setting options seems broken.
>

For reference: https://github.com/freebsd/poudriere/issues/1090


> The change LGTM.
>

>
>> --
>> Best regards,
>> Vladimir Druzenko
>>
>>