From nobody Fri Mar 31 16:11:46 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pp4zm5l2lz42x5Y; Fri, 31 Mar 2023 16:11:48 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pp4zm5DK9z4L65; Fri, 31 Mar 2023 16:11:48 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680279108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2pZlv06BjbNgFzGtgsFD8bON6nTSag9wY/y+trEyPFE=; b=amk/tk1DN/+FaeQ5VwCJmW9dDbV3MtTPi0P289mybQlx89kKyS5ps5GXgIzl61UtXivH8a guDbgKLUyy00MmRT4TH8Z0PQSFUKsFZitmBwMazSrfZiJJzJuzuR7/nM3SmGXfFWB0sItt lkYpe1ur0b99WlsLurqxg/yCYxtFViKAuU98RsG9AEYUkLyUgur73hI5NHRMx7p2MazLMq FHQeiOjTV7npsJfYBV6pX91qVtdAGJGoNfs4NVV9BkM01qD7Sen8aXC//zTC11nX6HEwXp oyosmTh0KT8W8xk/dlmdHDPZkk4wliTc5gnTUEon9QJ+lnEX5Mcigob7Atuurw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680279108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2pZlv06BjbNgFzGtgsFD8bON6nTSag9wY/y+trEyPFE=; b=Mw7mmt06JFZWmVmWU2f5QfDzhw6KavXKSnLCFyPAjRajwWox3cECkB8TNIVzC9Ossb45T+ 83xUW1D1hqyaONxlQdkTKVNyQQ16q9i5VDNY3hkJQX3rGBDkSTF+UksEzspjoopTZB6JL/ tg5Xmr8w+UM1EyTyltQRPEiSnsbr8gLbTNNQO0QVwODjPOjKK3AlMCAfUjbDWiUHedcbJ8 zOcPgb7bnLuSeuAx58DjL1Mce35SnMU5qmARZdPxNXsmkLCHIKNMauMiu6a/L/3lvcURq1 XLhDOXzd8UBcJhwowJurD0HcSH3yJvhLs0a/cNJAm5k4wt8CNWX6MeqNtdtHKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680279108; a=rsa-sha256; cv=none; b=uwJ7BwH61s6uTZ+fADwOK16oZR/GOMJ8+2n5ZcdbBMxBCRCLREIsVo6LutFHEu+lLDWNya ktNEB+Vtvd5tBsi1k09M/z4pwh7RxPz9dsqo/OncOwTlcbDSQWRL4weC5DDe8uaoJBV7Ni xIqruyDibHTRHgMlj7X8dlyXrpjeNuzmJcJRntO5iiWIZhklEFSRIW8xDvv5Q1fJF7+C04 JXMpcFwrH5TVkRNNQk1MdM+trRv5/1OkOZON3/reAXkzowN8xw6KOAoMCP7PfzeLt3VQNy tQcI7ebDnf6dHurOhwEkfCuZeJhmBb3hBQN0DKWQdMzFoT+G6ViAdXKiu/xP7g== Received: from [172.24.42.13] (host-79-32-120-162.retail.telecomitalia.it [79.32.120.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Pp4zl68wzz16d0; Fri, 31 Mar 2023 16:11:47 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <5b37d773-661e-2a93-655b-a093d7d1d632@FreeBSD.org> Date: Fri, 31 Mar 2023 18:11:46 +0200 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: git: de841b40d24d - main - sysutils/xxd: New port Content-Language: en-US To: Lorenzo Salvadore Cc: Adam Weinberger , gmarco@giovannelli.it, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <03eb85e1-14fa-24f4-dcb3-84caeef82a24@FreeBSD.org> <440103A8-A773-4B4E-BEB1-28C49D1B9CB5@adamw.org> <55712a33-dd09-719f-c294-417facb103a0@FreeBSD.org> From: Guido Falsi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 31/03/23 17:27, Lorenzo Salvadore wrote: > ------- Original Message ------- > On Friday, March 31st, 2023 at 4:32 PM, Guido Falsi wrote: > > >> >> >> On 31/03/23 16:30, Adam Weinberger wrote: >> >>>> On Mar 31, 2023, at 10:28, Guido Falsi madpilot@freebsd.org wrote: >>>> >>>> On 31/03/23 15:49, Adam Weinberger wrote: >>>> >>>>> On Thu, Mar 30, 2023 at 4:45 PM Guido Falsi wrote: >>>>> The branch main has been updated by madpilot: >>>>> URL: >>>>> https://cgit.FreeBSD.org/ports/commit/?id=de841b40d24d22ab51ad05ed632e025903fbb41f https://cgit.FreeBSD.org/ports/commit/?id=de841b40d24d22ab51ad05ed632e025903fbb41f >>>>> commit de841b40d24d22ab51ad05ed632e025903fbb41f >>>>> Author: Guido Falsi madpilot@FreeBSD.org >>>>> AuthorDate: 2023-03-30 20:42:54 +0000 >>>>> Commit: Guido Falsi madpilot@FreeBSD.org >>>>> CommitDate: 2023-03-30 20:42:54 +0000 >>>>> sysutils/xxd: New port >>>>> This is the standalone version of the xxd tool provided by vim. >>>>> Submitted by: Gianmarco Giovannelli >>>> mailto:gmarco@giovannelli.it> >>>>> diff --git a/sysutils/xxd/Makefile b/sysutils/xxd/Makefile >>>>> new file mode 100644 >>>>> index 000000000000..378f364cf4bf >>>>> --- /dev/null >>>>> +++ b/sysutils/xxd/Makefile >>>>> @@ -0,0 +1,26 @@ >>>>> +PORTNAME= xxd >>>>> +DISTVERSIONPREFIX= v >>>>> +DISTVERSION= 9.0.1366 >>>>> +CATEGORIES= sysutils >>>>> + >>>>> +MAINTAINER= gmarco@giovannelli.it mailto:gmarco@giovannelli.it >>>>> +COMMENT= Hexdump and reverse hexdump utility >>>>> +WWW= https://github.com/mew-cx/xxd https://github.com/mew-cx/xxd >>>>> + >>>>> +CONFLICTS_INSTALL= vim-[0-9]* vim-gtk2 vim-gtk3 vim-motif vim-x11 >>>>> + >>>>> +ALL_TARGET= ${PORTNAME} >>>>> +PORTSCOUT= ignore:1 >>>>> +EXTRACT_AFTER_ARGS= --include='/src/xxd' >>>>> +WRKSRC_SUBDIR= src/xxd >>>>> + >>>>> +PLIST_FILES= bin/xxd >>>>> + >>>>> +USE_GITHUB= yes >>>>> +GH_ACCOUNT= vim >>>>> +GH_PROJECT= vim >>>>> + >>>>> +do-install: >>>>> + ${INSTALL_PROGRAM} ${WRKSRC}/xxd ${STAGEDIR}${PREFIX}/bin >>>>> + >>>>> +.include >>>>> The WWW is odd here. The source files are coming from github.com/vim/vim http://github.com/vim/vim, but the WWW is for a related but unused project. >>>> >>>> Oops, you're right. Submitter proposed to use a fork, but later I decided grabbing the original vim distribution was better, I must have forgotten updating the WWW line. >>>> >>>> Will fix it! >>>> >>>>> I update vim at the beginning of every month plus whenever new minors are released, and whenever there are patches that it's important for us to downstream. Rather than pinning xxd to a version that will be old literally tomorrow, why not pull the DISTVERSION and distinfo from editors/vim/Makefile? >>>> >>>> That would be a good idea, but while using vim distinfo is trivial, I'm not sure how to import DISTVERSION from another port. Including the Makefile would override a bunch of other variables. >>> >>> ${MAKE_CMD} -V DISTVERSION >>> >>> :-) >> >> >> Uhm I guess I need to pass it the vim makefile too so it would be: >> >> ${MAKE_CMD} -f ../editors/vim/Makefile -V DISTVERSION >> >> I guess. Does not look pretty, but could work. > > I am unsure that using a relative path will work in all contexts: > I am thinking to a compilation started with "make -C" for example. > > An absolute path would probably be cleaner: > > ${MAKE_CMD} -f ${PORTSDIR}/editors/vim/Makefile -V DISTVERSION I was actually going with VIM_PORT= ${.CURDIR}/../../editors/vim VIM_DISTVERSION!= ${BSDMAKE} -f ${VIM_PORT}/Makefile -V PORTVERSION (defining VIM_PORT since I'm using it in various places) but this could be moot if we go the flavor way, which I'm evaluating. -- Guido Falsi