From nobody Fri Mar 31 14:32:52 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pp2nd6NP8z42pZT; Fri, 31 Mar 2023 14:32:53 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pp2nd5wWsz46P6; Fri, 31 Mar 2023 14:32:53 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680273173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OZwKFuIMxH6DH208+erv8ec/UmR3RUZNl5CmSJgHd10=; b=Yt6JaG2EmQzJdc6VPCrHykrckrgExZRP6wKM7AsxF8rCmqg60YnsdM3F5h2vQ+STCgD79h h9G0KtXx3tEbR18mVaR6PAEV4s1p5YEgFSXD/9XkBVhzF0eKMPSw08wLvQM2WcWDkiSrg6 VgvyI647Lyf5GTl6Td/aedy7zVyEDzHBuA5obLeIvIRNl9Drj3WitMfedjfpCSy2+6zCnM 1GQcf5rQW6xBF2bs32ROH1lDEU/kowFVguwtRZ0YjlWFng7o3a2eSbdoR8s2DDC5dS7hkP 4hTi5OYkswe4T7Sx5oOxujAZQ8998nUH9bGCfLgQxKnOc2BlEgeY5o04qHxRvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680273173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OZwKFuIMxH6DH208+erv8ec/UmR3RUZNl5CmSJgHd10=; b=a9v0NL//eV6ubfZJpu18HGm3Q134/HFmwOvhdw6DE4CPof7AmTVNeL4l3SXfP3NWXhli0E W0NhWy5cdJEmRZT1ahiaMnB4FcoiqEcVsGoj1l9N5cAsTAdjUzcThfzVYIBBVrAv2lS4mJ XnHvD7RrbJjCetTiMMENbUinYzuj5QcvLW5NL/Ew81EWLgHtYNUHEheqCc5XP3DCu1PNP6 iqGmPvylkj9Rrjds8h3zb+Di9IhL29Ni+i5IIzjK9Tc0ksNHvZSlOFFNaNEztCut+CGk69 49gfxiOa+aj+3dz8L0fO7Y/0/Kr8CAPQFszsyPhXpS4g4+mzFhE08Fs3cLMkZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680273173; a=rsa-sha256; cv=none; b=CJmRV1+zu4EDgAXz8StQr+y6J3sXWrmoltYNiBeU+6bSy8v7w029NJTmzpZmmTsiZB1aPj sEQz7VSgtZb3mJdlfKY9eAyZEtMsUUBpeKVVpoAf3MdUvAYv+VI/ZFJExC1OXqcVGG7s7Q XORyNS/Q/3PS4YDyl2KY/UKxFgViamaNqeO9WvJrSQA09conOajYxCvh9RAkaWwJ/R7p5n 6cVSAPQOOuTqDTEY+O+5qfCkrcRgJSNscySpos5d0YoSfKtqBOw1wMMC+JDo4bmj19d/HU dUPXhTjc9OwY2rGSnSv9E7CAuCDArxSOJWhieoDWHvjuCl2MQ55+7aqwEdOXBQ== Received: from [172.24.42.13] (host-79-32-120-162.retail.telecomitalia.it [79.32.120.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Pp2nd05tsz156K; Fri, 31 Mar 2023 14:32:52 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <55712a33-dd09-719f-c294-417facb103a0@FreeBSD.org> Date: Fri, 31 Mar 2023 16:32:52 +0200 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: git: de841b40d24d - main - sysutils/xxd: New port Content-Language: en-US To: Adam Weinberger Cc: gmarco@giovannelli.it, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <03eb85e1-14fa-24f4-dcb3-84caeef82a24@FreeBSD.org> <440103A8-A773-4B4E-BEB1-28C49D1B9CB5@adamw.org> From: Guido Falsi In-Reply-To: <440103A8-A773-4B4E-BEB1-28C49D1B9CB5@adamw.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 31/03/23 16:30, Adam Weinberger wrote: > > >> On Mar 31, 2023, at 10:28, Guido Falsi wrote: >> >> On 31/03/23 15:49, Adam Weinberger wrote: >>> On Thu, Mar 30, 2023 at 4:45 PM Guido Falsi > wrote: >>> The branch main has been updated by madpilot: >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=de841b40d24d22ab51ad05ed632e025903fbb41f >>> commit de841b40d24d22ab51ad05ed632e025903fbb41f >>> Author: Guido Falsi >>> AuthorDate: 2023-03-30 20:42:54 +0000 >>> Commit: Guido Falsi >>> CommitDate: 2023-03-30 20:42:54 +0000 >>> sysutils/xxd: New port >>> This is the standalone version of the xxd tool provided by vim. >>> Submitted by: Gianmarco Giovannelli >> > >>> diff --git a/sysutils/xxd/Makefile b/sysutils/xxd/Makefile >>> new file mode 100644 >>> index 000000000000..378f364cf4bf >>> --- /dev/null >>> +++ b/sysutils/xxd/Makefile >>> @@ -0,0 +1,26 @@ >>> +PORTNAME= xxd >>> +DISTVERSIONPREFIX= v >>> +DISTVERSION= 9.0.1366 >>> +CATEGORIES= sysutils >>> + >>> +MAINTAINER= gmarco@giovannelli.it >>> +COMMENT= Hexdump and reverse hexdump utility >>> +WWW= https://github.com/mew-cx/xxd >>> + >>> +CONFLICTS_INSTALL= vim-[0-9]* vim-gtk2 vim-gtk3 vim-motif vim-x11 >>> + >>> +ALL_TARGET= ${PORTNAME} >>> +PORTSCOUT= ignore:1 >>> +EXTRACT_AFTER_ARGS= --include='*/src/xxd*' >>> +WRKSRC_SUBDIR= src/xxd >>> + >>> +PLIST_FILES= bin/xxd >>> + >>> +USE_GITHUB= yes >>> +GH_ACCOUNT= vim >>> +GH_PROJECT= vim >>> + >>> +do-install: >>> + ${INSTALL_PROGRAM} ${WRKSRC}/xxd ${STAGEDIR}${PREFIX}/bin >>> + >>> +.include > >>> The WWW is odd here. The source files are coming from github.com/vim/vim , but the WWW is for a related but unused project. >> >> Oops, you're right. Submitter proposed to use a fork, but later I decided grabbing the original vim distribution was better, I must have forgotten updating the WWW line. >> >> Will fix it! >> >>> I update vim at the beginning of every month plus whenever new minors are released, and whenever there are patches that it's important for us to downstream. Rather than pinning xxd to a version that will be old literally tomorrow, why not pull the DISTVERSION and distinfo from editors/vim/Makefile? >> >> That would be a good idea, but while using vim distinfo is trivial, I'm not sure how to import DISTVERSION from another port. Including the Makefile would override a bunch of other variables. > > ${MAKE_CMD} -V DISTVERSION > > :-) Uhm I guess I need to pass it the vim makefile too so it would be: ${MAKE_CMD} -f ../editors/vim/Makefile -V DISTVERSION I guess. Does not look pretty, but could work. -- Guido Falsi