From nobody Tue Mar 28 10:56:10 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pm67B3Dbqz41lg6; Tue, 28 Mar 2023 10:56:22 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pm67B2f6Wz4L8b; Tue, 28 Mar 2023 10:56:22 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680000982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hJganZ91W2GTk7qDa5ghN2qC+GfaBde6LzJsemqEMWo=; b=uFH0TXM4vkjwPAW3USRhvagZjFmyKG4ok6QAGdahexjLVTWqO4XMm2lnSgQD9CzHaUpOg0 ee0OGXFLh/a35NeDb/92CJlq+TPsS2ZtN/SNZXr+dQwYZ2IDJESW8ahavWfg70az6gAiKa H2u/paj0oOLwo7deF9I5kdW/pGVw/4JIWGT3EIZETpVOT8IVgG3vSHZnvtiBGmfzH3RzIu QEbzTmkSVKYaLc73nTnf/VLDP8VVSpKHEQjwnQRQyzKjQamrcACnYGQrc/fnpglNGseZ9p ozL9hkBCIx06Svpm4bEl9g0UmfqsD03XTTdltUz2d0cB3JYjrW9vEU+NDC2LCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680000982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hJganZ91W2GTk7qDa5ghN2qC+GfaBde6LzJsemqEMWo=; b=MvDdhf4NN0SamuA2p0+uXAISGxomoCO8J895oEtAzOvI9s5AqaBfCehYdQ9ySs8oVJ2YgJ stECAlB7Iu2yaEAn+KelwAebh7l84duxLLLgERDTu7hFSWL3ZlKa10r38KOeT7UWGHIl2m xZ5oRFkQHTAlc0gVvra5lVs/XfjmH0UoxOXuhzKD76Ky2+74E7unJqtPOXSpeDOYGtJEcc 547zkQFBzmtX2cbTE+S5+AX8JrtdqYK1bzsqtTHJAek7CnXxHAP2v6CEmdJN786NWBDUBA IAKqm9EFLMMhjMGno1MTGrjjbsuI0JmZcRFpBwXw6HmMWOH7iwIxZ4Tk/i2a6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680000982; a=rsa-sha256; cv=none; b=Qoc9zitJQpSKMy/jodjqXL8qus/5nQ7bNSfXy9K6vbQ92IVSx5rn07NR6vf8P2UX73fYJc ovEq8SIztG1HeO7XcR3FLPOgyJ2WxAle4f+M8p0ZXjz8SyvjmdcKPAtlmsRvMsQg48tzqp gfyYdhq4Du1SRsQcXpq+10KgHe6wk7L7pLkbXjT6ZNW97RFpCZumnQjONqHSlhhZI4UATd pSuOP4cyOxss7RBhLDOUSY42Qwr/sMtaqHPMGlKsarejzKZ6+O032UFwW2rKOoZxG3iKsY fMkhYKUt0TTtmx6rWica1UduOXXo7Dae8JCepXnrVitqotI1eibvbHSaad9Z0Q== Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Pm67B1RmhzbDD; Tue, 28 Mar 2023 10:56:22 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-ua1-f51.google.com with SMTP id g9so8499531uam.9; Tue, 28 Mar 2023 03:56:22 -0700 (PDT) X-Gm-Message-State: AAQBX9dN2zHUI0azKjfaEV9frVIIjWqSLKaF0HqNiPJp9+GQAQcvq71q gxJB3I/CnDWwmXXRI6/mEgFPDw/FOXaHTWdcNiQ= X-Google-Smtp-Source: AKy350aVJ6ZR4iC9DVccnrq3VCRIPimpk0YocCZ2vZd7kUqqYWSiogK3iFReWg6t6puzpKQB20byJg30650N7Lcj5uM= X-Received: by 2002:a1f:9e02:0:b0:43a:35e1:743c with SMTP id h2-20020a1f9e02000000b0043a35e1743cmr7956787vke.3.1680000981715; Tue, 28 Mar 2023 03:56:21 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202303130836.32D8a39n017978@gitrepo.freebsd.org> <6174ccaf-95ae-ae15-9ce2-a4c143154d06@pfeifer.com> In-Reply-To: From: Nuno Teixeira Date: Tue, 28 Mar 2023 11:56:10 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 3fd626858d82 - 2023Q1 - devel/rgbds: Fix build on 12.4 To: Alexey Dokuchaev Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Content-Type: multipart/alternative; boundary="000000000000bcd12e05f7f3b5eb" X-ThisMailContainsUnwantedMimeParts: N --000000000000bcd12e05f7f3b5eb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello danfe! Thank you so much! I did test it without _POSIX_C_SOURCE but it failed at first because I did a mistake on reinplace cmd. It builds fine now. Also, OpenBSD is doing same to fix build until upstream fixes it: https://github.com/gbdev/rgbds/issues/1111 https://cgit.freebsd.org/ports/commit/?id=3De4d330bbdc82f346bc31f109ebff0d7= 1154362d0 Cheers, Alexey Dokuchaev escreveu no dia ter=C3=A7a, 28/03/2023= =C3=A0(s) 09:06: > On Tue, Mar 28, 2023 at 08:25:06AM +0100, Nuno Teixeira wrote: > > Hello, > > > > Upstream can't solve problem with clang >10 > > https://github.com/gbdev/rgbds/issues/1091 > > It builds fine for me with default compiler (12.4/13.1) and this target: > > post-patch: > # yank _POSIX_C_SOURCE because it breaks the build > ${REINPLACE_CMD} 's,-D_POSIX_C_SOURCE=3D200809L,,' ${WRKSRC}/Make= file > > Good code should not pass custom _POSIX_C_SOURCE anyway. :) > > ./danfe > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000bcd12e05f7f3b5eb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello danfe!

Thank you so mu= ch! I did test it without _POSIX_C_SOURCE but it failed at first because I = did a mistake on reinplace cmd.
It builds fine now.

Also, OpenBSD is doing same to fix build until upstream fix= es it:

Ch= eers,

Alexey Dokuchaev <danfe@freebsd.org> escreveu no dia ter=C3=A7a, 28/0= 3/2023 =C3=A0(s) 09:06:
On Tue, Mar 28, 2023 at 08:25:06AM +0100, Nuno Teixeira wrote:
> Hello,
>
> Upstream can't solve problem with clang >10
> https://github.com/gbdev/rgbds/issues/1091

It builds fine for me with default compiler (12.4/13.1) and this target:
post-patch:
# yank _POSIX_C_SOURCE because it breaks the build
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${REINPLACE_CMD} 's,-D_POSIX_C_SOURCE=3D200= 809L,,' ${WRKSRC}/Makefile

Good code should not pass custom _POSIX_C_SOURCE anyway. :)

./danfe


--
Nuno TeixeiraFreeBSD Committer (ports)
--000000000000bcd12e05f7f3b5eb--