Re: git: fa5c1863d7d0 - main - print/a2ps: update to 4.15.3

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Tue, 28 Mar 2023 07:11:09 UTC 
On Mon, Mar 27, 2023 at 07:43:34PM +0000, Dirk Meyer wrote:
> commit fa5c1863d7d0efd004340358af2065da2ea1ae2f
> 
>   print/a2ps: update to 4.15.3

Hi Dirk,

That's a rather scarce commit log, given the amount of changes.

>  26 files changed, 135 insertions(+), 489 deletions(-)
> 
> -MAINTAINER=	dinoex@FreeBSD.org
> +MAINTAINER=	dirk.meyer@dinoex.sub.org

Oh, but why?

>  COMMENT=	Formats an ASCII file for printing on a postscript printer
> -WWW=		https://www.gnu.org/software/a2ps/
> +WWW=		http://www.inf.enst.fr/~demaille/a2ps/

Why?  This page does not even open for me.

> -CPE_VENDOR=	gnu
> +MAKE_JOBS_UNSAFE=yes

When marking port as make -jX unsafe, an excerpt from the failure log
should be included, so interested hackers could try to fix it, e.g.
particular error used as MAKE_JOBS_UNSAFE value instead of `yes'.

> +OPTIONS_DEFAULT=NLS

NLS is already on default options list, no need to put it there twice.

>  post-install:
> +.if ${PORT_OPTIONS:MEMACS}
> +	${MKDIR} ${STAGEDIR}${PREFIX}/lib/xemacs/site-lisp
> +	${LN} -sf ${PREFIX}/share/emacs/site-lisp/a2ps-print.el \
> +		  ${STAGEDIR}${PREFIX}/lib/xemacs/site-lisp/a2ps-print.el
> +	${LN} -sf ${PREFIX}/share/emacs/site-lisp/a2ps.el \
> +		  ${STAGEDIR}${PREFIX}/lib/xemacs/site-lisp/a2ps.el
> +.endif

Consider factoring this part in `post-install-EMACS-on' helpder target.

> -	${RM} ${STAGEDIR}${PREFIX}/lib/liba2ps.la
> +	${RM} -f ${STAGEDIR}${PREFIX}/lib/liba2ps.la

Why?  make -V RM
/bin/rm -f

./danfe