Re: git: 1dd6bda76a5c - main - Mk/Uses/kde.mk: set up UTF-8 locale as default on build environment (+)
Date: Fri, 17 Mar 2023 23:08:48 UTC
Moin-Moin!
On 17.03.2023 22:40, Emmanuel Vadot wrote:
>
> Hi Dima,
>
> On Fri, 17 Mar 2023 19:34:29 GMT
> Dima Panov <fluffy@FreeBSD.org> wrote:
>
>> The branch main has been updated by fluffy:
>>
>> URL: https://cgit.FreeBSD.org/ports/commit/?id=1dd6bda76a5cf1dddd2615b2d0ee48e4fcf738f2
>>
>> commit 1dd6bda76a5cf1dddd2615b2d0ee48e4fcf738f2
>> Author: Dima Panov <fluffy@FreeBSD.org>
>> AuthorDate: 2023-03-17 19:23:47 +0000
>> Commit: Dima Panov <fluffy@FreeBSD.org>
>> CommitDate: 2023-03-17 19:23:47 +0000
>>
>> Mk/Uses/kde.mk: set up UTF-8 locale as default on build environment (+)
>>
>> Recently we discovered a bug with plasma apps parsing non-latin strings when
>> pure C locale was used at compile stage which leads to save and display
>> broken strings full of "?" symbols.
>>
>> Fix it by set a full UTF-8 locale for the build process.
>>
>> Idea: arrowd
>> Tests: fluffy
>>
>> Sponsored by: Serenity Cybersecurity, LLC
>> ---
>> Mk/Uses/kde.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Mk/Uses/kde.mk b/Mk/Uses/kde.mk
>> index 716e0abef6ba..21a541dc5a66 100644
>> --- a/Mk/Uses/kde.mk
>> +++ b/Mk/Uses/kde.mk
>> @@ -189,6 +189,8 @@ IGNORE?= unknown CATEGORY value '${_KDE_CATEGORY}' #'
>> . endif #defined(_KDE_CATEGORY)
>>
>> # ==============================================================================
>> +# === SET UP LOCALE ENVIRONMENT =================================================
>> +USE_LOCALE?= en_US.UTF-8
>
> Does C.UTF-8 works for this ?
> Asking before on a pkgbase system C.UTF-8 is always present while any
> other is optional (installed from the FreeBSD-locales package which
> contain everything).
>
It should but I've worried about LC_COLLATE too, this can matters while parsing multilingual json structures with non-latin alphabets. Does C.UTF-8 have it as expected? I see only LC_CTYPE definitions in C.UTF-8 locale.
Moreover, other .mk's also have defined LOCALE exactly as en_US.UTF-8, not as C.UTF-8.
See gnome.mk, meson.mk, gem.mk and horde of port's Makefiles
--
Sincerely,
Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD)
(desktop, kde, x11, office, ports-secteam)@FreeBSD team