Re: git: d69b20995dec - main - security/softether5: add DEBUG option
Date: Mon, 06 Mar 2023 19:55:01 UTC
On Mon, Mar 06, 2023 at 08:52:54PM +0100, Mathieu Arnold wrote:
> On Mon, Mar 06, 2023 at 11:25:06PM +0900, Koichiro Iwao wrote:
> > On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote:
> > > On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote:
> > > > commit d69b20995dec38f96ef28522bc6156a7d5b80fff
> > > >
> > > > security/softether5: add DEBUG option
> > > >
> > > > [...]
> > > > +.include <bsd.port.options.mk>
> > > > +
> > > > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk
> > > > +# just set WITH_DEBUG=yes, CMAKE_ARGS+=-DCMAKE_BUILD_TYPE=Debug takes no effect.
> > > > +.if ${PORT_OPTIONS:MDEBUG}
> > > > +WITH_DEBUG= yes
> > >
> > > We do not expose this via options. To build debug package, just
> > > "make -DWITH_DEBUG", don't ask users to fiddle with options.
> > >
> > > ./danfe
> >
> > Really? What's the difference exposing ports vs not?
>
> WITH_DEBUG is a global user facing knob, it must never be activated via
> options.
Sorry, bad wording, it must never be set in any Makefile, wether
options, flavor, or whatever. It is not a port setting, that one sets
in a Makefile, it is a user setting that one sets in make.conf.
--
Mathieu Arnold