From nobody Mon Mar 06 19:52:54 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PVq4W2L6Lz3wJ0n; Mon, 6 Mar 2023 19:52:59 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PVq4W10zZz4PgB; Mon, 6 Mar 2023 19:52:59 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678132379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YP++S7TPBIx/zXbg/y9I4Hekmvj/E7YQfZ4da804IOQ=; b=BO5T7saeiHuysC44C+0EKvywn9iQ4o2TEePDq1b7IHaS7jzdaEsN1kV8qISqeJ5gU0fNZi p2RM+dQ+4K57ci9NcOI6lOX9Czro9YpdG5S5WM5egItu80x4W7YfU29EPQivG+JNHcAlfS 1oAj9svRknVlz1GpRlRs9T7LyZn7wzdvpBUY6CLIyA8Fz/VZR7il9Wrm7+d3xO0pFrA8Gs /LXn9+rGDACG9ihH6R7D1QC511asnSsVeG9rt0/dIrQROMxlTkGHt6FSyLTK08FGkMkQaQ 9ELVOAfV3/DSJ9/ZqMKEHnkKThBSw8jZjXGC3U+HO7Mh3EIqZFtigOOnfZKjUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678132379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YP++S7TPBIx/zXbg/y9I4Hekmvj/E7YQfZ4da804IOQ=; b=j0oYa1NNFPiiowBjhbAyh/mIzdnNsnsdtDhoNnRhXQtMvkG43/PWDLji9X0mhSymVYgM5P zjVA/KT0Pz/NQUx5/I4yx49YIcxnQ9odfH1pYjt8lpUjLPO5LSY4jGXSaNN4hsMloOoNkp mJAx2S2CXwF4LOf8b+PrvTPb1+lXF6jnhjq3HLFFyF1m95n7fsol1vrNNM756N1sR/vdmq fROBTMRg8pHgEjlIX6uxK5ecY9vRdd/pjQixTtW0VjaKsjSnLsB19m7Aeb7kldJ2ZX48Ne VNWaVlLTRX+Cmal5tSFdEY3l17lp9o0w07JPuTptZhRRtkZeORf7k2b8+8jBOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678132379; a=rsa-sha256; cv=none; b=uRX/V1HXklay3mfvfTdyRnulukP+LrvF2Gn7eRP/QIZPfS/CZ/6pa1S6GoUWxzZNqRiqtM WIYBZFzz41xFuij0KHhky2JsWih+ic4qNPhta0O7ZjkYCrv4EuZY3qTHIFwjngjXD0Om+t MPqo2IgX+Pi01cYldaU8oqx4muldKTlFUtPx4XCcQtCpzcj6PJRoqe6sMisFB813bPRKIw zaoEwq8EdfJhKlfhxopUuhEqnx3aWanzZDNhgeosQSV1bfeegP09updbTfpKIlm7QQ8+dD fVoDoxNr0cF9jPaSihLdlN5GW9uwBRZCFoIxZs86yifKSOf5jVTIPjqs1KWbVw== Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PVq4V6YvjzFfk; Mon, 6 Mar 2023 19:52:58 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:e4fe:745e:1d65:7cd6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 7357F942D80; Mon, 6 Mar 2023 19:52:56 +0000 (UTC) Date: Mon, 6 Mar 2023 20:52:54 +0100 From: Mathieu Arnold To: Koichiro Iwao Cc: Alexey Dokuchaev , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bfumt7havl2hhsus" Content-Disposition: inline In-Reply-To: <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> X-ThisMailContainsUnwantedMimeParts: N --bfumt7havl2hhsus Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 06, 2023 at 11:25:06PM +0900, Koichiro Iwao wrote: > On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote: > > On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote: > > > commit d69b20995dec38f96ef28522bc6156a7d5b80fff > > >=20 > > > security/softether5: add DEBUG option > > >=20 > > > [...] > > > +.include > > > + > > > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk > > > +# just set WITH_DEBUG=3Dyes, CMAKE_ARGS+=3D-DCMAKE_BUILD_TYPE=3DDebu= g takes no effect. > > > +.if ${PORT_OPTIONS:MDEBUG} > > > +WITH_DEBUG=3D yes > >=20 > > We do not expose this via options. To build debug package, just > > "make -DWITH_DEBUG", don't ask users to fiddle with options. > >=20 > > ./danfe >=20 > Really? What's the difference exposing ports vs not? WITH_DEBUG is a global user facing knob, it must never be activated via options. --=20 Mathieu Arnold --bfumt7havl2hhsus Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmQGRJZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6h8QwAsQ57WwBQMkdxwh2VgrXCTqKvW8iDnIHbBdYr9eZzWAZvmnvTt9VG6ZvJ xfztNoydkfcVOqma33s3ekT9g1Xqg1WCSndx9sH50Y7Dgo0A/lgz9pmzoV06tKuc N6LXaxy0GH7Y1DGLHq9izbUnGZ/RhnAB2gphpuBcbsWehTMzfYYasLQl1WNlsJDV EdvC3mjMGfCx6IX3Etg5DiGKwPf4Co5LCpYKeQ6+0iejkOpy94ELUVW+Z9XDPccQ 1A3GJGjci1dStJUThRg2S/f21sE37byFw0cOVCvGYwvVWvEAM3/A7iUgAXQv59/L 69F/9AlV/anId+QZDx5lITxUOyp3Q7EHcZQddBEWMc7++/dL7udHbu14UDt4+znw IDX6fhXXjsogkGR5thE+e58RfZ46AkbqSh7JHPJwtZhzA46FElE2ayNBUxrA59Da lhfgufbnWq/zPCE/8dp82QZJia5zdbEziLLLEK2WZA3XKyYPQabLdwphZoVMdl/H xElIZmiN =+Nqe -----END PGP SIGNATURE----- --bfumt7havl2hhsus--