Re: git: ae8e32b08e33 - main - devel/qjson: Improve clang 16 workaround for usage of the 'register' keyword

In reply to: Raphael Kubo da Costa : "git: ae8e32b08e33 - main - devel/qjson: Improve clang 16 workaround for usage of the 'register' keyword"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Sat, 08 Jul 2023 18:18:07 UTC

On Sat, Jul 08, 2023 at 09:50:51AM +0000, Raphael Kubo da Costa wrote:
> commit ae8e32b08e33bac7aec0f14f28e45d53dee6f565
> 
>   devel/qjson: Improve clang 16 workaround for usage of the 'register'
>   keyword
> 
>   Commit 3237ce1557467a3f89a3d1fa7a9308161665bf0c fixed the build on
>   CURRENT with a heavy hammer that made register a macro. This change
>   passes -Wno-register to the compiler instead, which is cleaner.

Correct fix is still like the following one-liner (untested):

    ${REINPLACE_CMD} -e 's,register ,,' ${WRKSRC}/src/json_scanner.cc

./danfe