From nobody Mon Jan 30 15:41:53 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P5C9F04NFz3bm49; Mon, 30 Jan 2023 15:42:09 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P5C9D5FHTz443S; Mon, 30 Jan 2023 15:42:08 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-f169.google.com with SMTP id b13so2990573ljf.8; Mon, 30 Jan 2023 07:42:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FuWVCJveUyf+jMxv1YkCg6z/Yb9WmcPqqs+u3vOdKIY=; b=pKdOKam/T0XXcGLhtMF2BZM8+Rf7KcKcqWnGGpFF9AVynHgoTGRti0TBVCXEGx6OIF HgOlFItGNSLMTV64YZPf+6bLVqIXi8TtK+wf/Go3phsiWJtL3qhJ6N+cvmPi2tusPtos kKaD5obj8rL+fLiRXDEDTOIjJ/8vq0mR9sReVdIGpxPdcT6TWVzpYr4KeXsMX/vMj/Nu mITwD4v3uKQhXJujr993RuZT+weGY/BaRrVqXyi3w8CrdxkNYHfQRkcstDptTeDJFRdx rZYfC74CZhR+irGd68sg9Ubqu77eVqe2fzNMKUPCvpqtQqxk7YRUG42E6meey5sljwfD UlLA== X-Gm-Message-State: AO0yUKUBIsYer4Y63LaVzhpkf9kNagUwnDQOS1CoDXF2ebfyfwOM6SdF 7jNbOKa646AjtmKBmdKjid9dEsgwTEownTtD135JGODGM1I= X-Google-Smtp-Source: AK7set+QDSM+cFwC9isrUWSReQDjjGsxZIUSks2nIYqX6QAvahp0X/wzRpSdIlBAnwwlDLpihOv1QuPux17sjXY3or8= X-Received: by 2002:a2e:86d7:0:b0:28e:9e65:36be with SMTP id n23-20020a2e86d7000000b0028e9e6536bemr1664794ljj.92.1675093325479; Mon, 30 Jan 2023 07:42:05 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202301301425.30UEPoQ9089521@gitrepo.freebsd.org> In-Reply-To: <202301301425.30UEPoQ9089521@gitrepo.freebsd.org> From: Antoine Brodin Date: Mon, 30 Jan 2023 15:41:53 +0000 Message-ID: Subject: Re: git: fa93fdc383c1 - main - Framework: Rewrite nodejs.mk and reorganize www/{node,npm,yarn} To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4P5C9D5FHTz443S X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Mon, Jan 30, 2023 at 2:25 PM Po-Chuan Hsieh wrote: > > The branch main has been updated by sunpoet: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=fa93fdc383c190569821ae224413c848c19d9a7c > > commit fa93fdc383c190569821ae224413c848c19d9a7c > Author: Po-Chuan Hsieh > AuthorDate: 2023-01-30 14:20:38 +0000 > Commit: Po-Chuan Hsieh > CommitDate: 2023-01-30 14:20:38 +0000 > > Framework: Rewrite nodejs.mk and reorganize www/{node,npm,yarn} > > The current USES=nodejs has the following issues: > - www/node is not the default version while www/node16 is. > - It also means inconsistent naming of node ports. > - www/npm duplicates with www/npm-node16. > - www/yarn duplicates with www/yarn-node16. > > The notable changes are introduced to fix the above issues: > - Rewrite Mk/Uses/nodejs.mk. > - Add new LTS version of nodejs (www/noe18). > - Add new current version of nodejs (www/node19). > - Change default nodejs version from 16 to 18 (latest LTS). > - Use consistent naming for all supported node versions. > - Convert www/node, www/npm and www/yarn to meta ports. > > After this commit: > - All supported node versions are named as node{14,16,18,19} > - www/node is a meta port which depends on the default version (e.g. www/node18) > - www/npm is a meta port which depends on the default version (e.g. www/npm-node18) > - www/yarn is a meta port which depends on the default version (e.g. www/yarn-node18) > - Bump PORTREVISION of dependent ports for dependency change (from www/node16 to www/node18) > > Discussed with: jrm, otis, pizzamig Hi, How was this tested? a lot of ports are not hooked to the build. Antoine