From nobody Fri Jan 27 16:43:18 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3NgF0w51z3bBpf; Fri, 27 Jan 2023 16:43:21 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3NgF0gppz3nMt; Fri, 27 Jan 2023 16:43:21 +0000 (UTC) (envelope-from bofh@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674837801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0QdbSv5aq2YJkzW9a27GKudrBa2oo2ityds66sCKmQ=; b=ng9IM9gIybGj5SbmGlZqb63QLvPEJQP37AtWswvtcocC0+6H50UnIm5wf12QNNdP8eKZoX M1ZoHus60O4B248EO7XOR2t66GRGWEWEOw8jc6whsypvnrToeW7LG4sGv8QBwC2i/e7krr 4kCblD1oUumNZi1v5Ag282XTFlXxGmVT8OedawJO6dNVScP8nvFci4rclxMfcfqYLXjBVy MWKAIvlG0yLzF6UvhOz70wfyBox2Gehqza36wOIzIUqnmYZiLETnYF3QM8wVa9ZmHxsBAT YgCTjw9NG0406gHGfye7w9UxXMqtg08fVpxFaw2pr5dd3DuqAvGaghdbwgg1sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674837801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0QdbSv5aq2YJkzW9a27GKudrBa2oo2ityds66sCKmQ=; b=IHYMdR3pGsQumcileP0j4SCJolSvh8EZa4zNRU9stkYzJEaDcS2kMb1v/aWfgXU/XIUjyP cEAJWoCuGovOP19J1qpY2fDfYyaBGTdAdL3+p/EYKt3BbcUON9Lm8XvjqvGwkC6mNPRSFi OAaAsGxo6TWom0VLKIeZH6yawiNJSTp5P2AN1aRY1ecHTwsa9oa2uAbAVgzDps/ISXY/Ky bmyppQC5s+zOjUhxeMF13VEQv/aAU+GoYcAuZ54ZQWS0NZNEGMS2LUPZxSDv3vqL0kjAcY bThP+Ke048tHrzO+KYiR8meopmlUxrE2y6eEF8MZaRiPpDClxttvhVIR0iPZYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674837801; a=rsa-sha256; cv=none; b=XB7xWUA3yZlIWocfJ/767u8TU/ohzjoHtCoVAeDT12wgf73Y1LMpROn/rrS2L/qrxcDdF3 YpmRmM096sGwPcOIuj99HeMiBxlpgGrAwF7LVqUfdtmLu9Uneb8Q5nvTIEn6OIPwC8h7jd UddK5rbcIWhbNiOi2ig/gWsmC3yNOJDGMlNPgoNIGHP3S94W8TtUK+WgoPuypF+EqFZH0m 7boye56YqAulKcF4oPrgPUmx7Gu8AAC+ZZnrjICtFf1ixSWQz97HDm4MWFoEgrXHqjGtMN E67JOMyc0NNlouYpq4gESwjQPrTwAUhXnFcN5hPSQpsPr47yJ6fTpMC+GxtAgA== Received: from mx.bofh.network (mx.bofh.network [IPv6:2a0d:2787:2::28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.bofh.network", Issuer "R3" (verified OK)) (Authenticated sender: bofh/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P3NgD2Gt0z182x; Fri, 27 Jan 2023 16:43:20 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtpclient.apple (gw.office.cyso.net [95.97.78.194]) by mx.bofh.network (OpenSMTPD) with ESMTPSA id 0ab554fe (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 27 Jan 2023 16:43:18 +0000 (UTC) From: Moin Rahman Message-Id: <80B00F6D-68E5-4DFA-B205-4C6CBDAB0419@freebsd.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_31772894-0B21-4EC9-B29A-C62988CFED22" List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 0983bbffe275 - main - devel/rubygem-oj: Fix build Date: Fri, 27 Jan 2023 17:43:18 +0100 In-Reply-To: <20230127.191713.2183382863074960001.yasu@FreeBSD.org> Cc: "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" To: Yasuhiro Kimura References: <202301181534.30IFYYOw066510@gitrepo.freebsd.org> <20230127.191713.2183382863074960001.yasu@FreeBSD.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_31772894-0B21-4EC9-B29A-C62988CFED22 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 27 Jan 2023, at 11:17, Yasuhiro Kimura wrote: >=20 > From: Muhammad Moinur Rahman > > Subject: git: 0983bbffe275 - main - devel/rubygem-oj: Fix build > Date: Wed, 18 Jan 2023 15:34:34 GMT >=20 >> The branch main has been updated by bofh: >>=20 >> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D0983bbffe275d18b7b7c576817f3eb= 57e2504bfe >>=20 >> commit 0983bbffe275d18b7b7c576817f3eb57e2504bfe >> Author: Muhammad Moinur Rahman >> AuthorDate: 2023-01-18 15:28:49 +0000 >> Commit: Muhammad Moinur Rahman >> CommitDate: 2023-01-18 15:32:49 +0000 >>=20 >> devel/rubygem-oj: Fix build >>=20 >> Currently the header files are not included although there is a >> post-install step. However there is a missing line where we need = to >> create the directories. >>=20 >> This fixes the builds of gitlab-ce. >=20 > Unfortunately build still fails after this commit. > "${INSTALL_DATA} -d" creates directory with 0644 and it result in > failing to copy header files with 'permission denied'. Attached patch > fixes it. It uses "${INSTALL} -d" instead. So directory is created > with 0755 and now header files are copied successfully. >=20 > =46rom 3a01bac7a4793cc191bc605fbb81b0380ab26959 Mon Sep 17 00:00:00 = 2001 > From: Yasuhiro Kimura > > Date: Fri, 27 Jan 2023 18:41:22 +0900 > Subject: [PATCH] devel/rubygem-oj: Create directoy with proper mode >=20 > "${INSTALL_DATA} -d" creates directory with 0644 and it result in > failing to copy header files with 'permission denied'. So use > "${INSTALL} -d" instead.It creates directory with 0755 and header > files are copied successfully. >=20 > Fixes: 0983bbffe275 > --- > devel/rubygem-oj/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/devel/rubygem-oj/Makefile b/devel/rubygem-oj/Makefile > index 374e6a43edc7..367164535c29 100644 > --- a/devel/rubygem-oj/Makefile > +++ b/devel/rubygem-oj/Makefile > @@ -1,6 +1,6 @@ > PORTNAME=3D oj > PORTVERSION=3D 3.13.23 > -PORTREVISION=3D 2 > +PORTREVISION=3D 3 > CATEGORIES=3D devel rubygems > MASTER_SITES=3D RG >=20 > @@ -16,7 +16,7 @@ USES=3D gem > # TODO: find a better way to do this > # Copy all header file, as it is required by rubygem-oj-introspect > post-install: > - ${INSTALL_DATA} -d = ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj > + ${INSTALL} -d = ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj > cd ${WRKSRC}/ext/oj && ${FIND} * -name "*.h" -type f -exec = ${INSTALL_DATA} {} = "${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj/{}" = \; >=20 > .include > --=20 > 2.39.1 >=20 > --- > Yasuhiro Kimura The answer is both yes and no. In the cluster we use = BUILD_AS_NON_ROOT=3Dno which is not the default case for poudriere. However if we have this in our poudriere.conf it builds perfectly. At = least for our case we have been using this and our gitlab was also = updated. But then again your case is also correct. Kind regards, Moin= --Apple-Mail=_31772894-0B21-4EC9-B29A-C62988CFED22 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On 27 Jan 2023, at 11:17, Yasuhiro Kimura <yasu@FreeBSD.org> = wrote:

From: Muhammad Moinur Rahman = <bofh@FreeBSD.org>
Subject: git: 0983bbffe275 - = main - devel/rubygem-oj: Fix build
Date: Wed, 18 Jan 2023 15:34:34 GMT

The branch main has been updated by = bofh:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3D0983bbffe275d18b7b7= c576817f3eb57e2504bfe

commit = 0983bbffe275d18b7b7c576817f3eb57e2504bfe
Author: =     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2023-01-18 15:28:49 +0000
Commit: =     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-01-18 15:32:49 +0000

   devel/rubygem-oj: Fix build
   Currently the header files are not = included although there is a
   post-install = step. However there is a missing line where we need to
   create the directories.

   This fixes the builds of gitlab-ce.

Unfortunately build still fails after this commit.
"${INSTALL_DATA} -d" creates = directory with 0644 and it result in
failing to copy header files with 'permission denied'. = Attached patch
fixes it. It uses "${INSTALL} -d" instead. So directory is = created
with 0755 and now header files = are copied successfully.

=46rom = 3a01bac7a4793cc191bc605fbb81b0380ab26959 Mon Sep 17 00:00:00 = 2001
From: Yasuhiro Kimura = <yasu@FreeBSD.org>
Date: Fri, 27 Jan 2023 18:41:22 = +0900
Subject: [PATCH] = devel/rubygem-oj: Create directoy with proper mode

"${INSTALL_DATA} -d" creates directory with 0644 and it = result in
failing to copy header files = with 'permission denied'. So use
"${INSTALL} -d" instead.It creates directory with 0755 and = header
files are copied = successfully.

Fixes: = 0983bbffe275
---
devel/rubygem-oj/Makefile | 4 ++--
1 file changed, 2 insertions(+), = 2 deletions(-)

diff --git = a/devel/rubygem-oj/Makefile b/devel/rubygem-oj/Makefile
index 374e6a43edc7..367164535c29 = 100644
--- = a/devel/rubygem-oj/Makefile
+++ b/devel/rubygem-oj/Makefile
@@ -1,6 +1,6 @@
PORTNAME=3D oj
PORTVERSION=3D = 3.13.23
-PORTREVISION=3D 2
+PORTREVISION=3D = 3
CATEGORIES=3D = devel rubygems
MASTER_SITES=3D RG

@@ -16,7 +16,7 @@ USES=3D = gem
# TODO: find a better way to do this
# Copy all header file, as it is = required by rubygem-oj-introspect
post-install:
- = ${INSTALL_DATA} -d = ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj<= br style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D"">+ = ${INSTALL} -d = ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj<= br style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""> cd ${WRKSRC}/ext/oj && ${FIND} * -name "*.h" -type f = -exec ${INSTALL_DATA} {} = "${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}-${PORTVERSION}/ext/oj/{}" = \;

.include <bsd.port.mk>
-- 2.39.1

---
Yasuhiro Kimura

The answer is both yes and no. In the cluster = we use BUILD_AS_NON_ROOT=3Dno which is not the default case for = poudriere.

However if we have this in our poudriere.conf it builds = perfectly. At least for our case we have been using this and our gitlab = was also updated.

But then again your case is also correct.

Kind regards,
Moin
= --Apple-Mail=_31772894-0B21-4EC9-B29A-C62988CFED22--