Re: git: 38e6e935efa6 - main - dns/unbound: add dynlib port option
Date: Mon, 16 Jan 2023 22:13:37 UTC
On Mon, Jan 16, 2023 at 2:12 PM Fernando Apesteguía <fernape@freebsd.org> wrote: > > > El lun., 16 ene. 2023 19:50, Adam Weinberger <adamw@adamw.org> escribió: > >> >> >> On Mon, Jan 16, 2023 at 5:48 AM Fernando Apesteguía <fernape@freebsd.org> >> wrote: >> >>> The branch main has been updated by fernape: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=38e6e935efa67110ba6d2d1e322555f0afbb8383 >>> >>> commit 38e6e935efa67110ba6d2d1e322555f0afbb8383 >>> Author: Fernando Apesteguía <fernape@FreeBSD.org> >>> AuthorDate: 2023-01-15 19:29:38 +0000 >>> Commit: Fernando Apesteguía <fernape@FreeBSD.org> >>> CommitDate: 2023-01-16 12:44:02 +0000 >>> >>> dns/unbound: add dynlib port option >>> >> >>> PR: 268942 >>> Reported by: me@rcm.sh >>> Approved by: jaap@NLnetLabs.nl (maintainer) >>> --- >>> dns/unbound/Makefile | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> >> Does this need a pkg-plist change? If the plist is the same with this >> option on and off, what is this option actually controlling? >> > > The dynlib option is to build that module into the same daemon: > > > https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#dynamic-library-module-options > Ohhhh, so it's about loading *third-party* modules as shared libs? (Looping in maintainer here) If the previous statement is correct, would you be okay with me updating DYNLIB_DESC to reflect that? As it's currently written it looks like turning it off would create a fully statically-linked sbin/unbound, which is not the case. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org