Re: git: 23e0e7b1c30f - main - multimedia/mediainfo: Use all-in-one tarball

On Sat, Feb 11, 2023 at 3:43 PM Daniel Engberg <diizzy@freebsd.org> wrote:

> Hi,
>
> Porters Handbook (indirectly) recommends you to sanitize sources.
>
> https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements


Do you mean the removal of USES=dos2unix?
This port does not install any text file but only 1 binary executable.
Therefore USES=dos2unix is unnecessary.

I also checked that the generated bin/mediainfo are identical.


> Best regards,
> Daniel
>
> On 2023-01-30 14:06, Po-Chuan Hsieh wrote:
> > The branch main has been updated by sunpoet:
> >
> > URL:
> >
> https://cgit.FreeBSD.org/ports/commit/?id=23e0e7b1c30fc6f86957a7428e51a5ea9c594291
> >
> > commit 23e0e7b1c30fc6f86957a7428e51a5ea9c594291
> > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > AuthorDate: 2023-01-30 12:27:47 +0000
> > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > CommitDate: 2023-01-30 12:59:06 +0000
> >
> >     multimedia/mediainfo: Use all-in-one tarball
> >
> >     - Update WWW
> >     - Remove unnecessary USES=dos2unix
> > ---
> >  multimedia/mediainfo/Makefile | 20 +++++++++-----------
> >  multimedia/mediainfo/distinfo |  6 +++---
> >  2 files changed, 12 insertions(+), 14 deletions(-)
> >
> > diff --git a/multimedia/mediainfo/Makefile
> > b/multimedia/mediainfo/Makefile
> > index 5766752579b5..9b7c3737d89f 100644
> > --- a/multimedia/mediainfo/Makefile
> > +++ b/multimedia/mediainfo/Makefile
> > @@ -1,13 +1,14 @@
> >  PORTNAME=    mediainfo
> > -DISTVERSION= 22.12
> > +PORTVERSION= 22.12
> >  CATEGORIES=  multimedia
> > -MASTER_SITES=
> https://mediaarea.net/download/source/${PORTNAME}/${DISTVERSION}/
> > \
> > +MASTER_SITES=
> https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/
> > \
> >               LOCAL/sunpoet
> > -DISTNAME=    ${PORTNAME}_${DISTVERSION}
> > +DISTNAME=    MediaInfo_CLI_${PORTVERSION}_GNU_FromSource
> >
> >  MAINTAINER=  sunpoet@FreeBSD.org
> >  COMMENT=     Provides technical and tag information for video and audio
> > files
> > -WWW=         https://mediaarea.net/en/MediaInfo
> > +WWW=         https://mediaarea.net/en/MediaInfo \
> > +             https://github.com/MediaArea/MediaInfo
> >
> >  LICENSE=     BSD2CLAUSE
> >  LICENSE_FILE=        ${WRKSRC}/../../../License.html
> > @@ -15,17 +16,14 @@ LICENSE_FILE=     ${WRKSRC}/../../../License.html
> >  LIB_DEPENDS= libmediainfo.so:multimedia/libmediainfo \
> >               libzen.so:multimedia/libzen
> >
> > -USES=                autoreconf compiler:c++11-lang cpe dos2unix
> libtool pathfix \
> > -             pkgconfig tar:xz
> > +USES=                compiler:c++11-lang cpe libtool pathfix pkgconfig
> tar:xz
> >
> >  GNU_CONFIGURE=       yes
> > -USE_CXXSTD=  c++11
> >  USE_LDCONFIG=        yes
> > -CPE_VENDOR=  mediaarea
> > -DOS2UNIX_GLOB=       *.c *.cpp *.h
> > -DOS2UNIX_WRKSRC=     ${WRKDIR}
> >
> >  PLIST_FILES= bin/mediainfo
> > -WRKSRC=              ${WRKDIR}/MediaInfo/Project/GNU/CLI
> > +WRKSRC=
> ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI
> > +
> > +CPE_VENDOR=  mediaarea
> >
> >  .include <bsd.port.mk>
> > diff --git a/multimedia/mediainfo/distinfo
> > b/multimedia/mediainfo/distinfo
> > index 0d9caebdc92b..995778948454 100644
> > --- a/multimedia/mediainfo/distinfo
> > +++ b/multimedia/mediainfo/distinfo
> > @@ -1,3 +1,3 @@
> > -TIMESTAMP = 1672606752
> > -SHA256 (mediainfo_22.12.tar.xz) =
> > 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc
> > -SIZE (mediainfo_22.12.tar.xz) = 2026408
> > +TIMESTAMP = 1674589524
> > +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) =
> > e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef1106947
> > +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = 3352944
>