From nobody Sat Dec 23 08:41:49 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SxyMN4cwdz54Ckr; Sat, 23 Dec 2023 08:41:52 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SxyMN4B2wz4JhY; Sat, 23 Dec 2023 08:41:52 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703320912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+bOSF49WDzKpI+ZXvKMkTGIM6zQNfT6YcbnjfhIJ0i0=; b=fdYHh6zcj0prWHtAiVCPRHLVVQcp5e9om3No0w3kao41/vt3GaCY7tV66Cuwor3nICfT0p rBiyAVRHxy8kR1QBJVCZFNYQTRFiPiOTeRAFXx0jFuBQANsAgtdDAxojYD3PGx0SvsorPj yotA/egFiVbaaf3zkHIQ+2JsOxMSYUgqm+2y/G714vC6F5aV5UBSrMEF/Hqf9WEouowzud zKCeIMskFHDRSbuNkrgbqkJAGQBxEYimxHntJfnZCRumum1x1W0PsZv0CuhvUSbBD/gdV0 rkKZGLieLWaRNCwzaCusUQhXHuCpli14nGx3oS6Pi1uNs2reeCkSgaKQfmteew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703320912; a=rsa-sha256; cv=none; b=MLGgiEM3V15Q5Mk/EtcJqm7sATNUc9+xFLTArKdZxEY3053jXvhknnOroF5wuMpEXqrfKU aQLup3sj9m1C5IkX9N6bLWfTsm+DGwOW/NyzsmAbVrUu39F2pjYIfDd918nPT+4irzBZJA fQBpg3+iv95aelMi55wnsmP2sEsvAyO5m60FC51Hk/zcmBDZIT86BMepcTl8tnakosUTQj 8fFyqzvrZBSqTL6uNXJizMLQkMyXPy+dDPwO8hcaCXbZeHt+ZqbFKWelhFCiiE/NhSe63w 3fnQw8KBygwU7KvsuUkX3H0UEUJ2+YmJtimxveVMOKPshfDA13MUkX+CgdaShA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703320912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+bOSF49WDzKpI+ZXvKMkTGIM6zQNfT6YcbnjfhIJ0i0=; b=FVRDQGV7D4k3bmR/oNpfAmdbJckeHDIErGv+zy6LbIGaXhGzUr1afCseYdxxHaBT7CVv6Y AByUQsteAgS/fFdMLeVm4qNW/VWtsX5LmsrPhfXpYWSRPkNk8Hw+EUfZ7AvqZTGfSTtCjy N2owRFo1xSL3z72+a8gs8cH1h3OFA03WY6aFc397F0WIKAqGn+/f1gXLTaoP9ru8qdsjiX ppuC9rqGvV1xb5mTxE1wOWIfW3AyFMDCbsO+PxUiwzMASeq1ul/95eH+EXWOcIk72V6YuP 54zteF/tpHCmTQhGZqYZN+DTsJ/4I64Pdh0xD3iCEdleojdoQ2qlP/iotZYGag== Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SxyMN1zrKz10rg; Sat, 23 Dec 2023 08:41:52 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:5d79:7093:233e:b07d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 09098942D81; Sat, 23 Dec 2023 08:41:51 +0000 (UTC) Date: Sat, 23 Dec 2023 09:41:49 +0100 From: Mathieu Arnold To: Mikhail Pchelin Cc: Muhammad Moinur Rahman , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e4b7e0154f5e - main - Mk/bsd.options.desc.mk: Expand ASLR Message-ID: References: <202312222344.3BMNivih098673@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dq5fx3o3xp3fyisv" Content-Disposition: inline In-Reply-To: --dq5fx3o3xp3fyisv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 23, 2023 at 11:15:01AM +0300, Mikhail Pchelin wrote: > On Sat, Dec 23, 2023 at 08:54:41AM +0100, Mathieu Arnold wrote: > > On Fri, Dec 22, 2023 at 11:44:57PM +0000, Muhammad Moinur Rahman wrote: > > > diff --git a/Mk/bsd.options.desc.mk b/Mk/bsd.options.desc.mk > > > index d20740cc888a..f877b04dd8d4 100644 > > > --- a/Mk/bsd.options.desc.mk > > > +++ b/Mk/bsd.options.desc.mk > > > @@ -30,7 +30,7 @@ APE_DESC?=3D Monkey's Audio lossless format support > > > ARCHIVE_DESC?=3D bzip2/zip/iso9660 archive support > > > ARMADILLO_DESC?=3D TPS transform computation via Armadillo > > > ASIO_DESC?=3D Asynchronous I/O support > > > -ASLR_DESC?=3D Enable ASLR support > > > +ASLR_DESC?=3D Enable Address Space Layout Randomization support > > > ASM_DESC?=3D Use optimized assembly code > > > ASPELL_DESC?=3D Spell checking support via GNU Aspell > > > ASSERT_DESC?=3D Enable debug assertions > >=20 > > To be a bit pedantic, it still means little to the user, does it mean it > > will build stuff with the random bits, or that it adds random bits to > > stuff when running... >=20 > If a user don't understand implications of enabling the option one > should not check or uncheck it and rely on the defaults, provided by the > maintainer. If the user is unable to understand what an option does, it is not the user's fault, it is the maintainer's. The maintainer has to provide meaningfull descriptions for the options so that the user can understand by reading the description if they want or not the option. If I build, say, libreoffice, and an option says : [ ] ASPELL - Spell checking support via GNU Aspell [ ] JAVA - Java support (XML filters, macros, DB connections) [ ] MMEDIA - Enable multimedia backend for Impress Ok, great, I understand what it does, the last one is a bit vague, but I don't plan on using impress, so I don't need it. If I build the same port and options saying : [ ] ASPELL - Enable Aspell support [ ] JAVA - Enable Java support [ ] MMEDIA - Enable multimedia support I have absolutely no idea if I need those or not. I know what aspell is, and if I don't, it has "spell" in it, so I assume it is about spell checking, ok, I can get that one. I know what Java is, but I have no idea what it implies for the context of this port, maybe it is java syntax highlighting, maybe it allows running java stuff. So, I am not a java developer, I say no. I know what multimedia means, so, I assume it is about adding pictures in documents, I'll need that, so I say yes. Now, I have made two wrong assumptions, I actually need java because I need macros and db connections, and I don't need multimedia because it's about Impress that I don't use. A user MUST NOT have to assume what the options will do, a user has to have a precise idea what it implies. Sometime, the description is too short to explain what it actually does, in those cases, the maintainer can add a pkg-help file, and when running make config (try in dns/bind918) the dialog will start with a line saying : 'Help' button for port info, 'F1' for Ports Collection help. And there is a help button beside the usual ok and cancel ones, hitting F1 or the help button will display the pkg-help file, that can go in much deeper explanation about what an option does. > If a user wants to know more - ASLR acronym is perfectly googlable with > wikipedia article being the first link. The user will learn what ASLR is, yes. My point is that the user will still not be able to know what enabling ASLR will do in that port. - Will it build the port with ASLR? - Will it allow the port to build stuff with ASLR? - Will it allow the port to run with ASLR? - Will it use ASLR while building the port? - ... --=20 Mathieu Arnold --dq5fx3o3xp3fyisv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmWGnUxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb5UoAv/Ukbjr8eX8Suvukpv5ZguPRGuhw9o3xPEzufqSVOsGujOoRrylMids16S Z+LoATGdBzaQPVVOGrMxbWrBsRENgUFdzApiahn1PB3fTaSrOsyCylgPt55TTic4 5kHQRIYGMOlZbuRkyDPuPy2FPZdGqcY0ioulm2p2jniMdJ/dfnmi1qs+Shrhpao9 oU+uKCPduasc5ajM/Aybz7tO4yz/s2wE7+sQI+VA/MVHlVSJ+NOyixsl/LsuZWuE uEgVdtO1BHuVEcNFmn/U5EISWg4ZUEb04uE5Lbe2jvTaC7dDyoFQPPDyVMt5GN4a jS2PpiFINpBj6nDlrEww+WLoP0XF3xIHWy7v4nzYiqMLF9MrRxsg/qjB7gHEBLD1 cxMh0LaCyvQ96GOEkEW/LEY+TiHTs9Fvr61huMXUYDLgkcNWA4n9wmuzfoGnX02M DduK+O+deImbmXrKY+4fWbQo5ZCzxE0BPEZCz1p2fIyh+xddv3+IqdkVqbaCJDPO IybC1gUH =6fEq -----END PGP SIGNATURE----- --dq5fx3o3xp3fyisv--